PK's Rebalancing Unofficial patch

if someone can provide the errors, this can be potentially fixed.
Once more, I’m interstate away from my computer until February, but can at least try fixing things and asking for testers.

>  DEBUG    : Deprecated foreground color suffix was used: (lt) in (ltgreen).  Please update mod that uses that.
> 
>      FUNCTION : nc_color color_from_string(const string&)
>      FILE     : src/color.cpp
>      LINE     : 563
> 
>      DEBUG    : sym is defined as number instead of string for overmap_terrain pit_topside (cave)
> 
>      FUNCTION : void oter_type_t::load(const JsonObject&, const string&)
>      FILE     : src/overmap.cpp
>      LINE     : 586

Just running PK on a test world, newest exp 101007

If someone knows a recent version that’s running fine for them I’d appreciate a heads up.

I didnt play for a while so I can’t go back to an ancient version, otherwise I’d just rollback

try 10090, works relatively OK for me

1 Like

DEBUG : Deprecated foreground color suffix was used: (lt) in (ltgreen). Please update mod that uses that.

FUNCTION : nc_color color_from_string(const string&)
FILE : src/color.cpp
LINE : 563

How to fix? 10224 Experimental

ah that ones easy

Go through the files in PK and where you see

ltgreen change it to just green

Nice. Now it doesn’t work at all

What’s new error.
Tbh I’m sure the latest version never had that issue so u might be using an old version any way.

But not 100% sure.

So what’s new error?

Nothing serious, just annoying warning on boot and that’s all. If I do as you said, then the world simply doesn’t load. Rather, those who play without tiles will have problems because of coloring.

new error after updating to latest experimental (10287)

1 Like

It’s easily fixable, you just have to add “id”: “insert whatever here” to each construction object, though someone will have to do this

i thought about it too but im afraid it will broke the mod’s structure.

i will try it.

1 Like

It won’t break it, don’t worry

tested it out, work as intended so far…

extensive test on progress.

1 Like

I’m alive and back home, resting up n such.
I merged all of the pull requests lovely people made for fixes too

6 Likes

Glad your back! Enjoy some well deserved rest. That was a long time to be away from home, friend.

1 Like

Just got this bug with lastest build:

DEBUG : Error: data/mods//PKs_Rebalancing-master 02052020/PKs_Rebalancing-master//pk_construction.json: line 3:28: requested non-existing member “id”

[
{
“type”: “construction”,
^
“skill”: “survival”,
“description”: “Construct makeshift post-fence”,
“category”: “CONSTRUCT”,

FUNCTION : bool main_menu::load_character_tab(bool)
FILE : src/main_menu.cpp
LINE : 1069

I’ll start working on all of this soon, sorry about all the delays, if anyone makes a PR I’ll merge it, but I’m just fairly busy with a lot smooshed into the next week or two right now!

1 Like

try write"id"-s like that

"type": "construction",
"id": "constr_mst_t_improvised_fence",
"skill": "survival",
"description": "Construct makeshift post-fence",
"category": "CONSTRUCT",
"required_skills": [ [ "survival", 2 ], [ "fabrication", 3 ] ],
"time": "20 m",
"qualities": [ [ { "id": "CUT", "level": 1 }, { "id": "HAMMER", "level": 1 } ] ],
"components": [
  [ [ "stick", 8 ], [ "2x4", 4 ] ],
  [ [ "rock", 8 ], [ "steel_chunk", 8 ] ],
  [ [ "pine_bough", 4 ], [ "willowbark", 8 ], [ "leather", 8 ], [ "rag", 10 ] ],
  [ [ "pine_bough", 4 ], [ "willowbark", 8 ], [ "leather", 8 ], [ "rag", 10 ] ]
],
"pre_terrain": "t_pit_shallow",
"post_terrain": "t_improvised_fence"
1 Like

No worries! I’ll try what katsureku is suggesting.

more fixes merged, lemme know if I broke anything, no time to test