Contributor badges

kevin.granade · 2018-11-24T01:47:12.595Z

Just a teensy feature I enabled, the forums will now look at the github project, and if it can match your forum account to your guthub account, it will award a badge based on your number of accepted pull requests.

SmartSelect_20181123-174324_Firefox.jpg698×772 81.1 KB

Trigon · 2018-11-24T02:20:06.005Z

Awesome. The people with actual skills deserve some recognition. I like it.

darktoes · 2018-11-24T03:34:36.405Z

How does one go about linking their Github account? My preferences seem to only list connecting a Google account.

kevin.granade · 2018-11-24T04:18:41.020Z

Looks like it wants to match email adresses to the ones listed in commits

github.com

discourse/discourse-github/blob/224116258e9d18074c52e99d4bf7cd9395b6a34e/app/lib/github_badges.rb

module ::GithubBadges

  BADGE_NAME_BRONZE ||= 'Contributor'.freeze
  BADGE_NAME_SILVER ||= 'Great contributor'.freeze
  BADGE_NAME_GOLD   ||= 'Amazing contributor'.freeze

  def self.badge_grant!
    return if SiteSetting.github_badges_repo.blank?

    # ensure badges exist
    unless bronze = Badge.find_by(name: BADGE_NAME_BRONZE)
      bronze = Badge.create!(name: BADGE_NAME_BRONZE,
                             description: 'contributed an accepted pull request',
                             badge_type_id: 3)
    end

    unless silver = Badge.find_by(name: BADGE_NAME_SILVER)
      silver = Badge.create!(name: BADGE_NAME_SILVER,
                             description: 'contributed 25 accepted pull requests',
                             badge_type_id: 2)

This file has been truncated. show original

Theundyingcode · 2018-11-24T17:55:09.010Z

not getting it… now to add forum/ github email debugging to my todo list. \(^v^)/
(cool addition though)

Theundyingcode · 2018-12-04T17:17:10.801Z

So I used different emails for my github and forum accounts…

kevin.granade · 2018-12-04T17:30:15.006Z

I think you can add the other email adress without changing anything else about your account, then it’ll start recognizing your commits.

Erk · 2018-12-05T00:38:43.427Z

I’m not sure we can have multiple emails… I am trying to add my anonymous github contributor email, but I can’t, because it seems to want me to remove my confirmed email to do it

kevin.granade · 2018-12-05T01:12:19.936Z

Hah, it seems you can have multiple emails, but you can’t set them.
It’s evidently a wip feature.

Discourse Meta – 4 Dec 18

Additional email address per user account support

@LeoMcA thank you so much for the work on this change. It made possible for my company to integrate our products with the community without having to deal with merging or deleting stuff.

hydroplatypus · 2019-04-17T23:34:58.416Z

What are the conditions necessary to get the contributor badge? Because I’ve had two pull requests merged, and have my github account linked. And I’ve checked, and the email is the same with all accounts. Is there a configuration that I am missing or something? Anyone got any suggestions to figure out what’s missing here?

TheMurderUnicorn · 2019-04-17T23:36:59.330Z

Ah, I forgot these were a thing. I also have contributed several PRs that got merged. Same e-mail for here and Github. Linked my accounts. No badge for me, though?

Axema · 2019-04-17T23:38:30.419Z

Well, I thought I’m the only one without it…

jokermatt · 2019-04-18T02:06:12.402Z

I think mine went thru but I had contributed when I made this account thru the github account
Edit: yup, badge in profile