Vehicle Additions Pack (Updated December 8)

Might be interesting. Just, er, do keep in mind I’d mucked about with things on the github version. ^^"

I can wait until it’s been merged and then work from there; copy-pasting is fairly simple after all.

Hmm? Er, the changes I PM’d you about already been merged, yeah. Unless you mean you want me to PR whatever changes from the mediafire version haven’t been updated on the github side? ^^"

EDIT: A PR is up. https://github.com/CleverRaven/Cataclysm-DDA/pull/13128

Augh. Blaze, for the love of God/Odin/Buddha/Tiamat/Something you need to remember to use double spaces in-between sentences in description entries, and to format things with spaces instead of tabs. I’m getting griped at because my PR re-introduced all the formatting errors they already fixed for you.

Is there a reason that you have to format things like that?

Because Kevin told me to. ;_;

Because we want a modicum of readability, both in the messages and the code.
Two-spaces after sentence-ending periods is the right thing™ to do in fixed-width fonts, and never ever using tabs is the right thing to do in source code :slight_smile:

Aye. Between that and my adding missing turrets, I would hope Blaze just copies the Gitgub version after the merging. @_@

That’s what I was thinking actually.

What exactly do you mean by “Double spaces in-between sentences”? Do I need to put two spaces between each word?

It’s for sentences. End a sentence with the usual punctuation, then two spaces, then the beginning of the next sentence.

Personally I don’t care and find it looks fine either way, but Kevin insists on it and I’m the one getting yelled at for unfixing everything by copy-pasting your stuff.

What exactly are the differences between the Laser cannon and the turbolaser?
From the description it is only 6 or so more range in excahange for the burstmode.
Is that everything?

The PR for updating your mod ( https://github.com/CleverRaven/Cataclysm-DDA/pull/13128 ) has been out for a while.

And again, note that I SHOULD have weeded out all the tab abuse and single spaces in description fields by now, and should be up to date with the actual changes in your version of Mediafire. I had to go through all the files trying to find changes that were actually changing properties, and not simply reverting format fixes. If/when this gets merged, it might be good to borrow from the Github version next time.

Otherwise you’re going to have to either find and remove all the formatting issues on your end (trust me, that would be a pain in the ass), or we’ll be repeating this cycle of “PR update, get griped at for re-breaking stuff, fix it again piece of piece” forever. ;_;

Meh. Fucking merge conflicts. PR is closed until I finish other unrelated things.

I submit that given the nerfs to multiple engines, the vortex engine and generator in this mod could use large buffs. The generator in particular gives energy equal to one crappy generic solar panel, in exchange for counting as an extra engine. Sure it doens’t need sunlight, but who really cares?

That, and if I recall it fucks up the ability to actually USE vortex systems due t

Between that and the fact that the Mediafire version is hopelessly out of sync with the Github version…

Yeah you can’t just slap six of these onto a vehicle anymore. If they’re to be useful they need to have some power.

Oh my god looking at the jsons it looks like a vortex generator couldn’t power a headlight by itself, lol.

Yeah. I would assume Blaze is on hiatus, juggling real-life issues, burnt out on the game, or otherwise unable to unfuck the growing list of issues with this mod. ._.

Let’s just buff the outputs of the vortex engine and generator until they’re worth the effort to build. It’ll take five seconds, and if Blaze pops back up and goes “Your change is terrible, these are supposed to be useless!” then I dunno, we can apologize and nerf them again I guess.

I’m thinking 3x the output at least. Maybe more like 5x. These are a serious pain in the ass to build and are incredibly wimpy currently, and the text description makes them sound like they’re supposed to be pretty powerful.

I mean right now you’d need 3 generators just to run a fridge continuously, and with the escalating skill requirements for engine stacking, that would take like 12 mechanics. Cripes.

Hmm. Doable, Would also want to port over whatever other changes to the mod Blaze has on the mediafire version, and maybe make turret versions of the BAR and other recent mounted weapons.

Either way, after my last attempt to PR an update for Blaze, I’m not a happydragon. :V