Vehicle Additions Pack (Updated December 8)

Blaze · 2015-05-17T16:37:36.000Z

Thwap:

[quote=“Random_dragon, post:216, topic:7616”]He told me it’s just a matter to removing one no-longer-needed file from the experimental version’s folder for the mod.

That’s why I deleted the mod entirely and replaced it with the version from the OP of this thread. Error persists.[/quote]
Well that fixed the old error (Erroneous entries in the vehicle menu).

But it seems that this is a new one about installing frames on vehicles.

Let me download the latest experimental and see what’s going on.

Random_dragon · 2015-05-17T17:03:10.000Z

Frame errors too? I hadn’t encountered that before, scheisse. ;w;

Blaze · 2015-05-17T17:07:22.000Z

Something is keeping mods from altering existing vehicles.

In any case, the update is in.

Vanilla vehicles no longer come with frames, but the M249, M2, and Mk19 can be installed without a frame.

Random_dragon · 2015-05-17T17:25:47.000Z

Hmm, odd. Will be glad to see it PR’d then. owo

Blaze · 2015-05-18T06:06:38.000Z

One tiny change. There were some concerns about players switching from the old version into the new version and having their turrets disappear. So I made a small dummy file to help ease it over.

Any removed turrets now appear on the vehicle as “Vehicle Anomaly”. There are two ways to deal with them. You can either break them, or uninstall and disassemble them. You’ll get a turret frame and the new version of the turret.

All of these changes are contained in the blaze_dummy_parts file.

dovla · 2015-05-18T06:45:48.000Z

[s]Ok, so I’ve been playing development version and started getting these messages about placing turret frames on various vehicles on game load after building the latest version yesterday. I’m guessing it happens while the game is processing vehicles already discovered (which makes me wanna go back and search for some that I did not actually see but my toon did).

Does this mean I’ll be stuck with these error messages forever and ever in the current save? It would be a massive shame since it’s one of my best runs so far…[/s]

Ok nevermind, I can place the mod version from the original post in the game folder and it fixes the error. I guess the fixes haven’t been merged yet then?

Random_dragon · 2015-05-18T15:10:21.000Z

Ah, I see. It might be smart to link people to the PR though. o3o

Random_dragon · 2015-05-21T16:03:25.000Z

Das bumpen. I’d like to point out that if you either don’t PR this fix, or at least give someone permission to do it for you, people will continue complaining about it being a broken clusterfuck in the main game. =w=

Also, it appears that the current version on Github is even more broken, causes errors on load.

Blaze · 2015-05-21T17:40:14.000Z

By all means, if someone could update it, please do.

Random_dragon · 2015-05-21T17:51:33.000Z

If my net wasn’t being derpy due to bandwidth, I likely would.

I’m guessing the version on Mediafire is the most current one?

EDIT: I am become Derp, destroyer of worlds. Have a thing. https://github.com/CleverRaven/Cataclysm-DDA/pull/12431

dovla · 2015-05-21T21:37:49.000Z

Just an update, in the latest development build most of the on-load errors have gone away, only one remains: vehicle part laser_guns has the TURRET flag, but is not made of a gun item

Errors in the part install menu persist for laser turrets.

Blaze, which parts are blocking installation of mountable guns? I had visions of installing a mountable hypervelocity driver on top of my driver seat but no dice it seems. Also, it doesn’t require a turret chassis to be installed first (contrary to the description)?

Random_dragon · 2015-05-21T21:49:15.000Z

No idea what all Blaze has done with the current version, but test to see how error-filled the PR is.

dovla · 2015-05-21T22:04:37.000Z

[spoiler]If you mean this one: https://github.com/CleverRaven/Cataclysm-DDA/pull/12431, it’s been merged to master. I already pulled and compiled the latest version and am still getting these notices on game load. As for part installation, seems that undefined errors persist for mountable weapons shown here, except for hypervelocity gun:

YLPaHov.png1216×677

4CORiIw.png1216×677

[/spoiler]

Sorry my bad, it has NOT been merged, the request is open.

Random_dragon · 2015-05-21T22:11:20.000Z

Derp. Exactly why that PR exists at the moment, to fix that. Do you need me to link you to the fork page so you can download and test it? Technically you can presently get it from the mediafire link on the first page too, as that’s where I got the most-updated version of the mod.

dovla · 2015-05-21T22:22:18.000Z

If you fork the PR into a branch I can do a checkout and build and see if it’s fixed.

Random_dragon · 2015-05-21T22:49:50.000Z

Not entirely sure how to do that. Also, delayed by an argument over on the page for my most recent update to More Survival Tools. ._.

Coolthulhu · 2015-05-21T23:24:03.000Z

Update on vehicle jsons:
“fuel_type” tag is obsolete on weapons. It will not cause errors, but keeping it around could be misleading. Turrets now use their item’s ammo type.

Random_dragon · 2015-05-21T23:29:56.000Z

About to switch branches and change that for Blaze, waiting on him would take longer. ;w;

Blaze · 2015-05-22T04:37:38.000Z

[quote=“Coolthulhu, post:237, topic:7616”]Update on vehicle jsons:
“fuel_type” tag is obsolete on weapons. It will not cause errors, but keeping it around could be misleading. Turrets now use their item’s ammo type.[/quote]
Bah, now I have to remove and change a few turrets.

Random_dragon · 2015-05-22T04:46:07.000Z

Already yanked that fuel_type thing from the PR. =w=