Please Fix Boats (or help me figure out how to fix boats)

Straume21 · April 11, 2018, 8:50am

Boat boards disable wheels. When a vehicle has boat boards attached, it is anchored into the ground and will not move even when you smash it with a semi truck going 200 mph.

How can we make it so that boat boards will allow the vehicle to float in water, and wheels will work on land normally without needing to rip the boat boards off. Why is it this way, code-wise? Is there some way (however messy) we could make it so that boat boards and wheels can work at the same time?

I have been looking through the source code trying to figure where the function that makes the vehicle sink in water is. I really want this to be fixed, and I am willing to try to fix it myself, but I need some help/ideas, both practically in terms of finding the part of the code that causes this behavior of vehicles being unable to work on land and sea, and conceptually in terms of ideas for how we could change this.

Zhilkin · April 11, 2018, 6:43pm

You can start here:

github.com

CleverRaven/Cataclysm-DDA/blob/446c2f4930a98627fc83becef2b26cf871144007/src/veh_interact.cpp#L1721




    if (x == 0 && y == 0) {
        col = hilite(col);
        cpart = p;
    }
    mvwputch (w_disp, hh + y, hw + x, col, special_symbol(sym));
}
wrefresh (w_disp);
}


static std::string wheel_state_description( const vehicle &veh )
{
bool is_boat = !veh.all_parts_with_feature(VPFLAG_FLOATS).empty();
bool is_land = !veh.all_parts_with_feature(VPFLAG_WHEEL).empty();


bool suf_land = veh.sufficient_wheel_config( false );
bool bal_land = veh.balanced_wheel_config( false );


bool suf_boat = veh.sufficient_wheel_config( true );
bool bal_boat = veh.balanced_wheel_config( true );
float steer = veh.steering_effectiveness();

github.com

CleverRaven/Cataclysm-DDA/blob/b4a409fb411876a996a02c6f32c4691eef2f5a76/src/vehicle.cpp#L3337


if( mv <= sv ) {
    mv = sv + 1;
}
if( velocity < sv && velocity > -sv ) {
    return 0;
} else {
    return (float) (abs(velocity) - sv) / (float) (mv - sv);
}
}


bool vehicle::sufficient_wheel_config( bool boat ) const
{
std::vector<int> floats = all_parts_with_feature(VPFLAG_FLOATS);
// @todo: Remove the limitations that boats can't move on land
if( boat || !floats.empty() ) {
    return boat && floats.size() > 2;
}
std::vector<int> wheel_indices = all_parts_with_feature(VPFLAG_WHEEL);
if(wheel_indices.empty()) {
    // No wheels!
    return false;

Topic		Replies	Views
Are boats still broken? The Garage	11	1736	June 16, 2019
Amphibious vehicles? The Bunker	31	3640	June 7, 2019
Boats The Bunker	1	186	November 9, 2014
Walking on Boat Hulls, or around a boat-type vehicle gives Wet debuff and plays water splash sound effect The Garage	6	602	April 30, 2020
I'm keep sinking inside my own boat for some reason The Garage	9	1103	January 25, 2019

Please Fix Boats (or help me figure out how to fix boats)

Related Topics