DangerNoodle's mining mod

[User1]

Ah, around lava makes sense, that was my second thought.

[quote=“User, post:18, topic:12576”]i tried it in my base and it just says “halfway down the way down becomes blocked off”.

Someone fucked up construction and never fixed it.[/quote]
Do you know which commit did it or how long ago it happened?
Or is mugling fixing it already so he can implement the ideas given in the git thread to make mining more fun?

[Random_dragon]

[quote=“User, post:21, topic:12576”]Do you know which commit did it or how long ago it happened?
Or is mugling fixing it already so he can implement the ideas given in the git thread to make mining more fun?[/quote]

The issue that Mining Mod’s author posted (https://github.com/CleverRaven/Cataclysm-DDA/issues/18452) has gone nowhere so far. There’s been speculation from Rivet, Coolthulhu, and Mugling, but none of them have actually made an effort to fix this.

[User1]

If anyone pulled the mod from dangernoodle’s git repo, there is a bug which breaks latest experimentals.
Fix it like this:

[code] Fix “byproducts”:“ammonia” in recipes_medsandchemicals.json

Byproducts must be in an array now.

diff --git a/data/json/recipes/recipe_medsandchemicals.json b/data/json/recipes/recipe_medsandchemicals.json
index d384384…9ce6819 100644
— a/data/json/recipes/recipe_medsandchemicals.json
+++ b/data/json/recipes/recipe_medsandchemicals.json
@@ -2447,7 +2447,9 @@
{
“type” : “recipe”,
“result”: “chem_saltpetre”,

• “byproducts”: “ammonia”,

• “byproducts”: [

•   [ "ammonia" ]
  

• ],
  “category”: “CC_CHEM”,
  “subcategory”: "CSC_CHEM_C[/code]
  I guess the same applies to the dropbox version. Dropbox is evil btw, you should share stuff through torrents or less evil services.
  And github isn’t exactly the best place to host git repos either ;D

[Random_dragon]

…you aren’t supposed to dump the entire data folder into a later experimental. That is a good way to break shit. >.o

And the dropboxing is because the mod author is apparently reluctant to post it themselves. Dunno why they don’t dropbox it on their own, but eh. If they upload it on mediafire or elsewhere, hopefully they’ll mention it on the PR page so I won’t have to keep poking my head onto github to keep the dropbox’d version up to date.

[User1]

i believe mediafire needs javascript to download so is even worse than dropbox.

...you aren't supposed to dump the entire data folder into a later experimental.

wtf, i didn't dump any data folders anywhere, i just merged two of his branches, which is exactly how people are supposed to install mods as it is way easier to update and also invites people to do some development of their own. but maybe it wasn't modified in the mining-mod branch.

[Random_dragon]

Either way, some shenanigans ensued, given the error cited was part of the mainline folders.

[Random_dragon]

Derp ensues, as seen here: https://github.com/CleverRaven/Cataclysm-DDA/pull/19130 Saw that finally show up on Github, only to be irked by the ideas ensuing there, but it did lead to the mod author finally dumping the mod into a repo I don’t have to keep updated.

For now though, I have implemented my Mining Mod at [url=https://github.com/DangerNoodle/mining-mod]https://github.com/DangerNoodle/mining-mod[/url], if it can be presented to others on the forum?

[saltmummy626]

Updated the OP with a link to the mods github page where it can be downloaded. It’s the link RD just posted.

[BorkBorkGoesTheCode]

DangerNoodle has added a bone pickaxe and the ability to convert some boulders into stone anvils using the construction menu. The only outstanding issue affecting Mining Mod also affect coregame: https://github.com/DangerNoodle/mining-mod/issues/12

[Rose]

Hmm. I’ve just started mining today. Found some silver in the first vein, found nothing in the second one, though it’s clearly marked as a vein. Do you by any chance know, why?

[BorkBorkGoesTheCode]

Did it have a question mark next to its name?

[Rose]

Yes, it did. As did the first one. So the mark on the map is not guaranteed to be a real vein?

[BorkBorkGoesTheCode]

Sometimes yes. https://github.com/DangerNoodle/mining-mod/blob/master/Mining_Mod/overmap_specials.json https://github.com/DangerNoodle/mining-mod/blob/master/Mining_Mod/mapgen_deep.json

[Rose]

Sorry, can’t really get much info out of the code. Could you explain? Does it mean that veins are visible on surface?

Upd: ah, got it. Got it, thanks.

[BorkBorkGoesTheCode]

Spoiler

Some veins appear unmarked under overmap specials.

[Nymall1]

The version in the launcher does not include the “MINEABLE” tag, meaning in present versions rock walls are not minable.