1799: Gallon Jug won't hold water

system · 2014-07-18T19:41:31.000Z

I just emptied a gallon jug of ammonia then tried to fill it with water. It goes through the process of filling it with water, but when I look at it in my inventory it shows it to be empty.

qurvax · 2014-07-19T20:17:37.000Z

Got this too. 1796

SuicideRey · 2014-07-22T05:11:41.000Z

Still in 1806 it wastes the water and also works for gasoline and jerrycans I’m sure that this is an issue with all the liquids atm. However it works with regular bottles.

Unloading from a bottle to a gallon jug doesn’t work as well.

gcaliber · 2014-07-23T07:47:35.000Z

I don’t have this problem in 1813 updated from 1774.

system · 2014-07-23T18:10:49.000Z

Seems to be fixed now.

system · 2014-07-24T01:09:42.000Z

Never mind, the jug holds water but the 55 gallon drum won’t.

Daidalon · 2014-07-24T01:22:51.000Z

Repressive:

Never mind, the jug holds water but the 55 gallon drum won’t.

Which version are you looking at? I just looked at the JSON and it appears to have all the flags it needs.

qurvax · 2014-07-24T05:12:00.000Z

On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

kevin.granade · 2014-07-24T06:54:17.000Z

That seems to be the issue, and I’m poking at it. The inventory code is seriously screwey, and interfering with a clean fix to the problem.

noname1208 · 2014-07-24T16:47:28.000Z

I’m curious.

To anyone with this problem: Can you fill them using a funnel in the rain?

system · 2014-07-25T00:26:24.000Z

qurvax:

On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

You mean wielded right? Because I was confused there for a second thinking that by welded you meant reinforced.

KA101 · 2014-07-25T00:29:29.000Z

Just merged a fix. Update and let us know if there’s still problems, please.

kevin.granade · 2014-07-25T02:02:40.000Z

The specific problem was that if you were wielding (holding in your hands) a container, it would fail to accept liquid you tried to pour into it.
The technical issue was that the item the player is wielding (internally refered to as player::weapon) is treated specially, and the code that operates on inventory/weapon/clothes had a bug where it would make a copy of player::weapon instead of storing a reference to it. Later on the code would try to act on this copy instead of on the real weapon.

qurvax · 2014-07-26T12:05:19.000Z

Repressive:

[quote=“qurvax, post:8, topic:6829”]On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

You mean wielded right? Because I was confused there for a second thinking that by welded you meant reinforced.[/quote]

Yes, misstyped.

Tested galon jugs, plastic jerrycans and 3L jar’s - all working as they should. Thank you KA101.

KA101 · 2014-07-26T15:05:24.000Z

qurvax:

[quote=“Repressive, post:11, topic:6829”][quote=“qurvax, post:8, topic:6829”]On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

You mean wielded right? Because I was confused there for a second thinking that by welded you meant reinforced.[/quote]

Yes, misstyped.

Tested galon jugs, plastic jerrycans and 3L jar’s - all working as they should. Thank you KA101.[/quote]

Thank Kevin, he found and wrote the fix.

qurvax · 2014-07-26T17:01:18.000Z

KA101:

Thank Kevin, he found and wrote the fix.

I express my gratitude to everyone involved in fixing that annoying bug