Split rail fence gate terrain blocking vehicles on dairy farm - stable 0.F

Soymilk · August 25, 2021, 6:47pm

From terrain-fence-gates json:
“id”: “t_splitrail_fencegate_o”,
“description”: “A commercial quality gate made of wood with a latch system. The gate is wide open, allowing anything to travel through.”,
“flags”: [ “TRANSPARENT”, “FLAMMABLE_ASH”, “FLAT”, “ROAD”, “BURROWABLE” ],

Seeing the description, and the automatically spawned cube van and quad inside a completely fenced-in dairy farm, I think vehicle collision with this gate terrain is unintended. Is it possible to modify this via json to allow vehicles, such as a shopping cart, to pass through? Must I drive through this as well?

Valase · August 25, 2021, 6:55pm

It’s possible that this issue is already known, see:

github.com/CleverRaven/Cataclysm-DDA

Bashable terrain with FLAT flag always receives collision from vehicle frames

opened 01:05AM - 18 Jun 21 UTC

pjf

<Bug> Map / Mapgen Vehicles Fields / Furniture / Terrain / Traps

# Describe the bug The `farm_dairy` and `farm_dairy_2` maps have lines of `t_…splitrail_fencegate_c` and `t_gate_metal_c` gates respectively at the end of roads, and sometimes even with vehicles spawning behind them. However these gates act as a line of individual gates, and do not allow vehicle access, even when all are open. # Steps To Reproduce 1. Explore or debug until you find a `farm_dairy` or `farm_dairy_2` map. 2. Look at the gates that connect it to the road # Expected behavior Vehicle-accessible sections of dairy farms have multi-tile gates with pully systems, so vehicles can pass. # Extra notes - @jtgibson01 has tracked this down to #49173, which adds bash data for split-rail fences, which causes them to participate in collisions. # Versions and configuration - Version: af4b28f40907e9807b3916f76deb62fe6ec8c673 (cdda-experimental-2021-06-17-2045)

Also from that report, as a possible fix:

Soymilk · August 25, 2021, 7:18pm

EDIT: Sorry, ignore below. I misunderstood and thought bash data was a flag. Removing bash data from the json does seem to be the simplest current fix. Thanks!

Thank you. That issue does seem relevant. However, 0.F does not have BASH tag on these gates, but I just tested and vehicles are still colliding, even with all open gates.

Valase · August 25, 2021, 7:26pm

From what I can see, both my local version and the online version do (t_splitrail_fencegate_o 0.F version):

github.com

CleverRaven/Cataclysm-DDA/blob/8c7366e8615d924cea231762147fb93787500082/data/json/furniture_and_terrain/terrain-fences-gates.json#L653-L667


      
          "bash": {
            "str_min": 4,
            "str_max": 20,
            "str_min_blocked": 6,
            "str_max_blocked": 30,
            "sound": "crack.",
            "sound_fail": "wham.",
            "ter_set": "t_null",
            "items": [
              { "item": "2x4", "count": [ 1, 4 ] },
              { "item": "nail", "charges": [ 2, 8 ] },
              { "item": "splinter", "count": [ 1, 2 ] },
              { "item": "hinge", "count": [ 1, 2 ] }
            ]
          }

Try removing this part and see if it works.

Topic		Replies	Views
Vehicle spawning question - map creation The Toolbox	4	516	March 13, 2020
Diagonal vehicle fix The Drawing Board	26	1277	July 15, 2015
External vs Internal vehicle tile tags - fixin holes in walls The Drawing Board	14	179	April 9, 2014
Diagonal Vehicles Causing Undead Passengers The Garage	4	523	September 15, 2021
RNG roadway wackiness The Bunker	8	553	August 11, 2022

Split rail fence gate terrain blocking vehicles on dairy farm - stable 0.F

Related topics