I have just submitted a PR for an entirely new mutation category on the github. Now I’m adding the ability for survivors to potentially become a snake monster if they so choose. Essentially the Lamia Mutations can be summed up as a little bit of the good and bad sides of Lizard and Elf. You get to be more sneaky at night, and are arguably more effective than a lizard survivor at a bunch of different things(having better night vision, more stat bonuses). But you also get some major downsides such as rank 2 cold-bloodedness, the entire loss of your leg slots(Which are made up for later in the post-threshhold), and becoming a carnivore.
Essentially you can become an adorable sneeki snake girl. Have fun trawling the dark for prey to eat!
And actually if I’m not mistaken, you can still use ‘soft’ clothing with restricted gear slots. So I think the theory is that a lamia should be able to wear a skirt, but not like kneepads.
I took the token straight from the bird beak, as that’s where I knew to find the function. Right now the only thing I think I need to fix is the Recipe, as right now it uses cooking oil as a cheeky reference to snake oil. But that’ll be done tomorrow. I’m going to add in a new material called Snakeskin, and hopefully get snakes to drop it. That could also probably be used to make various other items out of snakeskin too!
Okay, the last change I made tonight has to do with the recipe. It still requires cooking oil(heh, snake oil) and chitin, but being a Tier 3 mutation category it also now requires other mutagens. In this case I took Slime, Lizard, and Bird. Tomorrow’s changes will be replacing both the cooking oil and chitin with actual snake hide.
This morning I made some fixes to the lamia tree. Now Pre-threshhold Lamia Tail properly turns into a full tail at post-threshhold. The only remaining problem I have is that evidently it’s possible to wear X-Large Boots with a lamia tail. Which is odd, and I honestly have no clue how to stop that from happening. My intention is that you should only be able to wear ‘soft’ clothing like socks or skirts with the tail.
Wearing a sleeping bag over your noodle? That’s a hilarious mental image.
[quote=“evilexecutive, post:9, topic:12508”]This morning I made some fixes to the lamia tree. Now Pre-threshhold Lamia Tail properly turns into a full tail at post-threshhold. The only remaining problem I have is that evidently it’s possible to wear X-Large Boots with a lamia tail. Which is odd, and I honestly have no clue how to stop that from happening. My intention is that you should only be able to wear ‘soft’ clothing like socks or skirts with the tail.
Wearing a sleeping bag over your noodle? That’s a hilarious mental image.[/quote]
Well, I guess if the boots big enough, you could slip the end of the tail into it, so long as you keep the tip of the tail mostly vertical. I’m finding the mental imagery for that quite amusing, to be honest. Who doesn’t want to be the snek in the boot.
Final updates happened tonight. I’ve added Forked Tongue to the lamia category, so now you can get a snake tongue. And I made some small text formatting changes to make it look nicer ingame, as rivet requested. Also the text for lamia scales now correctly states that you have scales on your CHEEKS, and not mouth.
Whelp, I’m sorry guys, I guess this isn’t happening. My PR sat untouched on the github for such a great length of time that it became incompatible with the current experimental. And of course, rather than let me fix the damn thing or let me know what’s wrong, muggling instead closed the PR and got rid of everything.
I think maybe you might be misunderstanding how github works?
The pr is still there, just closed, and can be re-opened.
It looks like mugling was going through merging things, and was reviewing your pull and found a bunch of unrelated file changes in data/json/recipes/recipe_medsandchemicals.json to your mod, where you added/removed a slew of flags to a bunch of recipes that seem unrelated to the mod.
These changes would have caused a regression in the codebase so it would have broke stuff to merge it, but not merging it was blocking a bunch of other PRs. Mugling closed it pending changes.
If you change the files on your local repository to not include the random unrelated-to-lamia mutation changes you made to that file, I’m sure you can ask mugling to re-open it and consider it.
It’s also possible (though I didn’t check) that you could be working off an older version of recipe_medsandchemicals.json, and that you didn’t actually change them, per-say, as someone else changed it and you have an older version before the change and github is interpreting it as a change. To fix it you can make a backup of your changes, rebase your git branch, and then specifically copy in your changes to the files.
Also, is it possible that these changes could be done in the form of a mod, rather than a modification to the base files? That might make this 100x easier to add into the main branch.
Drag the folder inside into data\mods\ and load it into a new world like a mod. (or add it to an existing world save, by editing the mods json in the save folder to include “Lamia” as a mod)
It seems to all work fine. I tried it out and the mutagens/recipes/book it came from/levels/injecting seemed to function as intended.
I would however suggest tweaking things, possibly how long it knocks you out for. I made a new character and binge injected serums and couldn’t seem to get into lamia threshold before he dehydrated to death. shrug
You also might want to double check I didn’t miss anything. I might have accidentally because I was kind of copy pasting and reformatting from github’s history.
[quote=“evilexecutive, post:12, topic:12508”]Whelp, I’m sorry guys, I guess this isn’t happening. My PR sat untouched on the github for such a great length of time that it became incompatible with the current experimental. And of course, rather than let me fix the damn thing or let me know what’s wrong, muggling instead closed the PR and got rid of everything.
I’m pretty sad, and so very disappointed.[/quote]
I pulled that PR and tested it. It contained errors and didn’t load. Would you prefer I merged it and broke everyone’s game until you fixed it?
Separately, and as an other poster has pointed out, you don’t understand github. A PR is a request to merge and this wasn’t possible in your case. Touching a lot of unrelated lines also blocks other PR’s. I told you in the comments what to do next and resubmit.