[C.2858] Can't mass scrap piles of clothes anymore

kentable · 2015-03-13T01:57:32.000Z

I can no longer stand over a pile of junk and (B)utcher to mass scrap everything. The game says no corpse to butcher or it will attempt to disassemble the top item only. Further key presses result in the no corpse message. I’m surprised no one has reported this yet since the easy scrapping of junk was a real keyboard/sanity saver.

Coolthulhu · 2015-03-13T04:18:51.000Z

I though it was the aftermath of the multi-use-item rework, but it seems to work on my side.

Do you have an item that can cut clothes when used? Old system checked for an item with cutting quality, new one wants specifically an item capable of cutting clothing. So a pocket knife should work, but a toolbox won’t (it’s easy to update the toolbox to allow that, though).

kentable · 2015-03-13T06:25:14.000Z

I’ve picked up a few steak knives, hunter knives. I’ll hack in a few other knives to test if it might just a json error.

[edit] It seems the system stopped looking at knives that are not sitting in inventory when determining whether you have a knife for scrapping actions. Wielded and stashed knives don’t count. Once I had at least one knife in inventory, mass scrapping is enabled again.

kevin.granade · 2015-03-13T15:40:26.000Z

thanks for the feedback, that is a bug then, and an easy one to fix. (one that keeps happening over and over again sigh)

Coolthulhu · 2015-03-13T16:26:51.000Z

Added back long salvage with wielded and worn items, but didn’t manage to add it to sheathed items.

github.com/CleverRaven/Cataclysm-DDA

Allow long salvage with wielded and worn items

by Coolthulhu on 04:25PM - 13 Mar 15

5 commits changed 6 files with 104 additions and 22 deletions.

Zero · 2015-03-13T16:35:54.000Z

Re: your comment about it being difficult to fix for sheathed items - is it possibly to make the sheath virtually a tool for this purpose? Is that too hacky?

Coolthulhu · 2015-03-13T16:41:31.000Z

Zero:

Re: your comment about it being difficult to fix for sheathed items - is it possibly to make the sheath virtually a tool for this purpose? Is that too hacky?

Probably doable, but it may be harder than it sounds.
The problem is that uses are assigned to item types rather than instances of items.

It may be as simple as adding an use function getter to item. If this is the case, it is easy and will also be useful for item action menu.

I’ll check if it’s as easy as I think it is.

EDIT: Was a bit more complex than I thought, but I got it to work.