The problem with adding encumbrance is that currently bonuses are pitiful. Having +1 encumbrance for the amazing addition of 4 (FOUR) storage?[sup]*[/sup] No thank you, I’ll just wear another backpack for significantly better results.
[sup]*[/sup][size=8pt]Equivalent of four pockets on the in-game pants. Seriously? If I’d sew pockets and straps on my pants, they’d get to be cargo and have +10 to storage.[/size]
If the upgrades provided more substantial improvement, and worked intelligently (adding pockets to underwear? Enjoy your encumbrance. Adding pockets to outerwear? Naw, free to move.) then I’d agree with adding encumbrance. As it currently stands, it would just make tailor’s kit never used.
P.S. Also, maybe in the far future upgrades will be jsonized? I’d kinda like being able to, say, add chainmail upgrade as low-tech kevlar alternative (dangers of getting shot through chainmail notwithstanding), or a stronger version of pockets that adds encumbrance. It could take any parameters ARMOR and TOOL_ARMOR types have, and ignore the absent ones, and modify the clothing’s parameters accordingly. Or have a second set of parameters that are multiplicative and are added to item first. E.g. “storage”: 4, “storage-mult”: 1.1, add to cargo pants, 10*1.1=11, 11+4=15 storage as result.
Oh, speaking of embroidery! If it gets added, it simply must include being able to add a customized description of what you’ve embroidered/emblazoned!
[i]A thick leather full-length duster without sleeves, leaving your arms unencumbered. Has plenty of storage space due to its many pockets. It’s emblazoned with United States commonwealth flag on the back.
This piece of clothing fits you perfectly.
This piece of clothing is fancy.[/i]