Now that you mention it, reloading doesn’t produce any sort of sound, it just adjusts your current recoil. I think it’d be worth calling for sound just for the sake of hooking a sound file to it.
The reasons why it’d be better to go for weaponid rather than ammoid on weapon_fire are because some weapons that fire the same caliber have different firing mechanism (Think pump shotgun vs auto loading shotgun, bolt rifle vs auto rifle, crossbow vs pneumatic gun, etc…) and it’d be nice to assign specific sounds to them. The other reason is that I couldn’t for the life of me figure out how to add sound to the laser guns. Maybe I’m missing something really obvious but I tried adding UPS as an ammo variant and it didn’t seem to work.
Another thing I noticed is that smash->door/window plays the assigned sound when you destroy the terrain by shooting it, but it doesn’t seem to play when you smash it with the S key, only the bash sound plays.
Anyway, some more suggestions: Maybe add support to call for random sounds out of a set, so that you can have a range of sounds defined (Say, m16shot1.ogg through m16shot4.ogg) for any given sound event and have the game call a random one when that sound plays.
Any particular reason why the mixer is set to run at 22050hz in sdltiles.cpp? I changed it to 44100hz, recompiled and other than clearer sounding audio, I didn’t notice any negative effects.
For the footstep event, is it possible to only allow one instance of the sound to be playing at any given time? I tend to hold down my keypad keys a lot in this game, and doing this produces overlapping versions of the sound to play on top of each other.
I spent most of yesterday tinkering with audio files on Audition slowly filling out most of the provided events. It’s a great feature, thanks for adding it to the game!
Edit: Sometimes it’s the most obvious things- the reason why the laser guns weren’t producing any sound is because they don’t have a loudness tag in the json file. Adding “loudness : 4” makes them play sounds when using UPS as a variant.