Code diving, documentation correction for criticals

Unawares · 2018-10-07T05:50:32.263Z

Doesn’t affect gameplay at all, but the example cases for calculating critical hits in the code documentation has an error. The dexterity / perception “roll” (one of three rolls that work together) for a character with stats 20/20/20/20 would be at 85% not 100%. It starts at 25% and you would get an extra 20 from the Dex and an extra 40 from the Per.

Would be nice if someone could correct it just for better clarity.

mlangsdorf · 2018-10-07T14:04:33.740Z

If you have enough knowledge to dive through the code to figure that you, you can open a PR with the fix yourself. This is an open source project and everyone is welcome to contribute.

Unawares · 2018-10-07T14:26:53.687Z

Ha, I’m not there yet. If I was already able to do that stuff it would be done, I’d have skipped the forum post.

mlangsdorf · 2018-10-07T16:02:56.089Z

How hard is it to edit a comment string and open a PR? You can do it entirely through github’s web interface if you don’t feel up to dealing with git on your personal machine.

Unawares · 2018-10-07T21:49:13.556Z

Glad to hear it’s easy once you know how. Don’t know what a PR thingy is yet, but I’m sure I can figure it out at some point.

Happy Thanksgiving good sir >salute<

kevin.granade · 2018-10-08T17:04:18.592Z

Check out https://github.com/help and https://github.com/CleverRaven/Cataclysm-DDA/blob/master/.github/CONTRIBUTING.md

Unawares · 2018-10-10T01:17:37.766Z

Thanks Kevin, much appreciated