Code diving, documentation correction for criticals

Doesn’t affect gameplay at all, but the example cases for calculating critical hits in the code documentation has an error. The dexterity / perception “roll” (one of three rolls that work together) for a character with stats 20/20/20/20 would be at 85% not 100%. It starts at 25% and you would get an extra 20 from the Dex and an extra 40 from the Per.

Would be nice if someone could correct it just for better clarity.

If you have enough knowledge to dive through the code to figure that you, you can open a PR with the fix yourself. This is an open source project and everyone is welcome to contribute.

Ha, I’m not there yet. If I was already able to do that stuff it would be done, I’d have skipped the forum post. :slightly_smiling_face:

How hard is it to edit a comment string and open a PR? You can do it entirely through github’s web interface if you don’t feel up to dealing with git on your personal machine.

Glad to hear it’s easy once you know how. Don’t know what a PR thingy is yet, but I’m sure I can figure it out at some point.

Happy Thanksgiving good sir >salute<

Check out and

Thanks Kevin, much appreciated