Battery System CBM can't 'eat' car batteries

Game Talk The Garage
1

You can’t use 'E’at to charge your bionic power with the Battery System CBM from car batteries or storage batteries. Maybe it’s because they are ‘VEHICLE PART’ not SPARE PART unlike the other batteries. Is that ‘as intended’ or a bug?

2 
{
    "id": "light_battery_cell",
    "type": "MAGAZINE",
    "category": "spare_parts",
    "name": "light battery",
    "name_plural": "light batteries",
    "description": "This is a light battery cell, universally compatible with all kinds of small devices.",
    "weight": "50 g",
    "volume": "75ml",
    "price": 3500,
    "material": [ "iron", "plastic" ],
    "symbol": "=",
    "color": "yellow",
    "ammo_type": "battery",
    "capacity": 100,
    "looks_like": "battery",
    "flags": [ "NO_SALVAGE", "NO_UNLOAD", "RECHARGE" ]
},
{
    "id": "battery_car",
    "type": "MAGAZINE",
    "category": "veh_parts",
    "name": "car battery",
    "name_plural": "car batteries",
    "description": "A 12v lead-acid battery used to power car electrical systems.",
    "weight": "18000 g",
    "volume": "6250 ml",
    "price": 4000,
    "material": [ "plastic" ],
    "symbol": ":",
    "color": "light_cyan",
    "ammo_type": "battery",
    "capacity": 2500,
    "//": "58Ah @ 12VDC. Could supply ~700 watts for an hour",
    "flags": [ "NO_SALVAGE", "NO_UNLOAD", "NO_RELOAD", "RECHARGE" ]
  }

Yeah, you can’t “eat” a car battery (or any battery for vehicles) because of their size…

EDIT: wasn’t suppose to eat it XD

3

Cable CBM + portable geny if you want to use vehicle parts for bionic power effectively.

4

May I make a small change suggestion to the CBM text then?

:stuck_out_tongue:

5

Well, sorry for my misunderstanding… I dig deep into the source, so it might explain the whole “thing”:

bool player::can_feed_battery_with( const item &it ) const
{
    if( !it.is_ammo() || can_eat( it ).success() || !has_active_bionic( bio_batteries ) ) {
        return false;
    }

    return it.ammo_type() == ammotype( "battery" );
}

bool player::feed_battery_with( item &it )
{
    if( !can_feed_battery_with( it ) ) {
        return false;
    }

    const int energy = get_acquirable_energy( it, rechargeable_cbm::battery );
    const int profitable_energy = std::min( energy, max_power_level - power_level );

    if( profitable_energy <= 0 ) {
        add_msg_player_or_npc( m_info,
                               _( "Your internal power storage is fully powered." ),
                               _( "<npcname>'s internal power storage is fully powered." ) );
        return false;
    }

    charge_power( it.charges );
    it.charges -= profitable_energy;

    add_msg_player_or_npc( m_info,
                           _( "You recharge your battery system with the %s." ),
                           _( "<npcname> recharges their battery system with the %s." ),
                           it.tname() );
    mod_moves( -250 );
    return true;
}

bool player::can_consume( const item &it ) const
{
if( can_consume_as_is( it ) ) {
    return true;
}
// checking NO_RELOAD to prevent consumption of `battery` when contained in `battery_car` (#20012)
return !it.is_container_empty() && !it.has_flag( "NO_RELOAD" ) &&
       can_consume_as_is( it.contents.front() );
}

The only “edible” power source is the battery ammunition without NO_RELOAD flag. Car batteries (and such) has NO_RELOAD flag, which makes them not “edible” to “eat” :smiley:

6

I always thought it was a battery acid thing, in the case of you absorbing the potential chemical energy stored in the acid by breaking it open and “drinking” it. Guess I was wrong.

7

Do we still have this CBM with the same description? As I remember, Battery System CBM allows to “eat” old-fashion batteries, the ones which were an “ammo” for flashlights, welders etc. But now we have modern battery system with rechargeable small, medium and heavy batteries, which are some kind of “magazines” and can be loaded with “ammo” charges on recharge, but their “ammo” cannot be unloaded. Thus, that CBM became useless, or at least it was in one of spring experimental builds which I played.

Not sure about fresh experimental builds, is it possible to consume any battery at all with Battery System CBM?

Just to note: I saw something like “floating battery charges” few times, I believe those were renamed old-fashion unloadable batteries, remainings of some outdated disassemble recipys.

8

Not sure about fresh experimental builds, is it possible to consume any battery at all with Battery System CBM?

Pretty sure everyone in this thread was talking about the fresh experimental builds. I certainly was. For all that it says 'Eat’you just suck out that juicy battery charge. Only electrons (and possibly spit) are exchanged.

With that image in mind, I hope everyone keeps some wet-wipes around to clean the terminals before sharing batteries with their NPC companions. :stuck_out_tongue:

2 Likes
9

Yea in experimental just use battery charge only battery get really eaten(discarded) if is disposable battery normal battery can be used as long you recharge them afterward