Adrenaline Pump CBM Not working: 0.C-8587-gc2fef2a

evilexecutive · 2016-01-04T17:26:19.000Z

As of the latest experimental(Within an hour of this posting), activating the Adrenaline Pump CBM instantly causes Adrenaline Comedown, without applying any of its positive effects at all.

Screenshot of the effect:

Unfortunately the Debug menu isn’t showing anything going on, so I’m at a loss for why this is happening.

BeerBeer · 2016-01-04T22:47:15.000Z

0.C-8653-g3561067

Same thing. Instant comedown.

BTW, I don’t understand the version numbering system. Mine was downloaded like a week ago. Are versions being numbered backwards, counting down instead of up?

Malkeus · 2016-01-04T23:02:18.000Z

No, it’s not counting down. He’s using an older experimental. The most recent experimental is 0C-8780-g7b0c1c4. I’ll try out the adrenaline pump…

It’s still broken though, instant comedown, no bonus. If nobody else gets to it in the next few hours I’ll try my hand at it.

Malkeus · 2016-01-05T01:52:38.000Z

Ok…Did some experimenting. It’s giving an error “Bad Intensity, ID:adrenaline” and initially gives the adrenaline comedown. However, after one turn passes the adrenaline comedown becomes adrenaline rush, and proceeds to countdown as expected. So it does work, but not instantly. I will keep poking at it, I brought a sharp stick.

Malkeus · 2016-01-05T02:10:19.000Z

I put an issue up on github, this is kinda beyond my skills.

evilexecutive · 2016-01-05T02:13:56.000Z

Malkeus:

I put an issue up on github, this is kinda beyond my skills.

Thanks man! I’m just now learning how to do github, and I’ve only got a very minor amount of experience with coding. But this kind of issue is well beyond my experience. I just know how to take existing code and adapt it for my purposes.

Malkeus · 2016-01-05T03:10:22.000Z

Hah, same here. I’m learning as I go. Github is an intimidating bastard, but it’s worth the effort. I’ve learned some more about the code trying to figure out this little problem, but I’m stumped now. I don’t know why it starts out with the comedown and then kicks in. It has something to do with the intensity as it initializes the effect, but I can’t figure out what’s going on with that. Essentially if the intensity is less than 1, that error message is thrown, but I’m not sure where it gets the intensity to begin with…
The adding duration to existing effect thing turned out to be correct for the cbm, it works out to 50 * 15 / 100 = 7.5, which is what I saw while testing. Adrenaline injector still makes no sense though it gives 30 but 80 * 15 / 100 =12. We’ll see if anybody chimes in on Git.

Malkeus · 2016-01-05T17:48:48.000Z

I PR’d a fix for this. Mycus Rush also had the same issue, probably more effects do, but noone notices bc they aren’t time critical. I want my adrenaline rush MEOW!

BeerBeer · 2016-01-05T20:26:42.000Z

The better question is how did they get screwed up in the first place. o_O
First they work, then somebody did something.

Malkeus · 2016-01-05T20:43:50.000Z

[quote=“BeerBeer, post:9, topic:11195”]The better question is how did they get screwed up in the first place. o_O
First they work, then somebody did something.[/quote]

Not a clue, not interested enough to go digging either.

i2amroy · 2016-01-05T23:57:14.000Z

It looks like the problem is just that when they are being applied they are applied at intensity level 1, and it isn’t until the next tick that the duration-linked intensity is properly applied. As the person who wrote this code I can assure you that this bug has been there from the beginning in this particular case, it was just something I forgot to do.

I also posted on your github PR about the proper way that you should go about fixing this particular issue, which just requires a small tweak to the add_effect() code rather than changing all of the possible application points for any duration-based intensity effect.

Malkeus · 2016-01-05T23:59:44.000Z

Thanks for pointing me in the right direction. I’m learning as I go and tend to get fixated on the first thing I figure out. I had considered making a change to the add_effect function, but I didn’t have a good idea of where to start. Now I do.

Malkeus · 2016-01-06T06:59:57.000Z

Ok, I made another attempt and this one seems a lot more solid. To me, anyway. PR here, long winded explanation of what I did in there, mostly for my own benefit. This involved a lot more thinking and a lot less lines of code than my original idea would have needed to do the same thing. I learned a few things though, so it was enjoyable.