Some Old Basement Designs/Redesigns

Rogue_Yun · 2018-12-11T02:58:07.061Z

Here are some links to some old basement designs of mine. I couldn’t seem to get them to work. Something to do with linting. The goal was to add more diversity to the basements of the game.

If someone wants to help move forward with these I’d appreciate the help. I couldn’t figure out how linting works

github.com

RogueYun/Cataclysm-DDA/blob/dda5ba67baca87440654eb5c10b8aeb2896b74ae/data/json/mapgen/basement/basement_basic_01.json

[
  {
    "type" : "item_group",
    "id" : "workout_food",
    "items":[
      ["protein_powder", 15],
      ["sports_drink", 20],
      ["water_clean", 90]
    ]
  },{
    "type" : "item_group",
    "id" : "workout_clothes",
    "items":[
      ["sneakers", 80],
      ["socks", 70],
      ["stockings", 20],
      ["tshirt", 80],
      ["longshirt", 70],
      ["tank_top", 50],
      ["sports_bra", 30],

This file has been truncated. show original

Note: As a side note for this one, the flooded basement version of the above basement wasn’t seen too favorably.

github.com

RogueYun/Cataclysm-DDA/blob/basement_pets/data/json/mapgen/basement/basement_pets.json

[
  {
    "type" : "item_group",
    "id" : "pet_supplies",
    "items":[
      ["fish_bowl", 5],
      ["magnifying_glass", 10],
      ["rock", 40],
      ["stick", 40],
      ["pine_bough", 20],
      ["one_year_old_newspaper", 40],
      ["months_old_newspaper", 40],
      ["weeks_old_newspaper", 40],
      ["newest_newspaper", 40],
      ["survnote", 1],
      ["mag_survival", 40],
      ["mag_traps", 40],
      ["trappers_companion", 20],
      ["textbook_traps", 10],
      ["dog_whistle", 10],

This file has been truncated. show original

github.com

RogueYun/Cataclysm-DDA/blob/basement_chem_update/data/json/mapgen/basement/basement_chem.json

[
  {
    "type" : "item_group",
    "id" : "chem_clothes",
    "items":[
      ["coat_lab", 40],
      ["apron_leather", 10],
      ["gloves_medical", 40],
      ["boots_rubber", 20],
      ["gloves_rubber", 20],
      ["glasses_safety", 40],
      ["jumpsuit", 20]
    ]
  },{
    "type" : "item_group",
    "id" : "chem_misc",
    "items":[
      ["tongs", 10],
      ["laptop", 5],
      ["battery", 50],

This file has been truncated. show original

github.com

RogueYun/Cataclysm-DDA/blob/basement_generic_01/data/json/mapgen/basement/basement_basic_01.json

[
  {
    "type" : "item_group",
    "id" : "workout_food",
    "items":[
      ["protein_powder", 15],
      ["sports_drink", 20],
      ["water_clean", 90]
    ]
  },{
    "type" : "item_group",
    "id" : "workout_clothes",
    "items":[
      ["sneakers", 80],
      ["socks", 70],
      ["stockings", 20],
      ["tshirt", 80],
      ["longshirt", 70],
      ["tank_top", 50],
      ["sports_bra", 30],

This file has been truncated. show original

Wayticus · 2018-12-11T03:05:06.298Z

What errors are you getting when linting?
I ran the first one through, http://dev.narc.ro/cataclysm/format.html, and it seemed to work.

Rogue_Yun · 2018-12-11T03:15:32.260Z

It’s been a long time. If I recall correctly I couldn’t perform linting at all even though I was requested to do so.

Wayticus · 2018-12-11T03:21:22.872Z

Took me a but to find that page and figure out what linting was when I tried submitting stuff, but your first one ran, so try them again see if it works.
Far as I know it is just changing the formatting to be consistent (but I am far from an expert on git) like where you have },{ on one line, they want it to be
},
{
that page should sort it for you.

Ricky_Van · 2018-12-12T23:47:41.436Z

the separator seems wrong there… or just me?

i saw one of those separator is shaped like this :
{
},{

it should be shaped like this :
{
},
{

Malkeus · 2018-12-13T02:40:11.689Z

GitHub

Malkeus/Basement_Extension

3 new flavors of basement for your world. Contribute to Malkeus/Basement_Extension development by creating an account on GitHub.

I put this together from your data, it loads ok. I’ll jack up the weights and see if they spawn. I don’t think I need to add anything else to have these show up, right?

edit: ran it all through the linter, it made a few formatting changes. all good now.

Rogue_Yun · 2018-12-13T05:30:22.815Z

Look great! Thank you very much!

I appreciate the help with this. I’m sure hand holding is frowned upon but sometimes I just get stuck in a mental rut and I can’t figure it out on my own.

dissociativity · 2018-12-13T06:44:00.068Z

make a pull request when you can, this would be excellent in the base-game!