Small coding projects to help out with cataclysm

youtoo · 2013-10-29T14:23:35.000Z

To the developers: what are some smaller projects that you guys could use help with ? I am not very good with C. I am sure there are others out there that would like to help out. We don’t want to dump alot of junk into github that may not merge well. What are some small things we can help with?

what about stuff that is already in jsons? What are some smaller projects that those of us that are not as adept at could help out with without getting in your way.

kevin.granade · 2013-10-29T14:55:43.000Z

There’s actually a ton of stuff in json, so tweaking that is an easy entry point (by design).
Also we try and mark issues as “easy fix” if we think they will be, so check out the filtered list of issues at https://github.com/CleverRaven/Cataclysm-DDA/issues?labels=Easy-fix&page=1&state=open
(Yes, some will turn out to not be all that easy, the label is a guess)
Another relatively easy task is to import building layouts people have posted on the forums into the code in mapgen.cpp. A lot of this code is a bit of a mess, but adding a building layout is actually quite simple, since it’s wrapped in a function that accepts an almost graphical layout. We could really use a guide for how that works too.

i2amroy · 2013-10-29T15:18:23.000Z

Kevin Granade:

Another relatively easy task is to import building layouts people have posted on the forums into the code in mapgen.cpp. A lot of this code is a bit of a mess, but adding a building layout is actually quite simple, since it’s wrapped in a function that accepts an almost graphical layout. We could really use a guide for how that works too.

Actually don’t import it into mapgen.cpp if possible. You will want to put it into the building_generation.cpp/.h files and then link to it in the mapgen.cpp file (just copy the format that the early buildings in mapgen.cpp/building_generation.cpp/.h follow).

youtoo · 2013-10-29T17:31:01.000Z

thanks. I started looking at the code last night. Ill look at it some more before I upload stuff. I dont want to waste anyones time by dumping a bunch of bugs.

when I upload code, github will set up a branch right?

i2amroy · 2013-10-29T17:47:00.000Z

The best way I’ve found to do it is to use the github app (just google “github app”). It’s got a fairly basic UI and takes only minimal online/terminal usage.
Basic steps to do will be:

Go to the CleverRaven github Cata repository online
Click the “fork” button in the top right
Open up the app and click the “clone” button on your fork (it should be listed)
Make a new branch (name it after your changes; always select the “master” branch before doing this step!)
Make your changes in the code, commit then and click “sync” (On windows I think the default repository location is Documents/Github).
Go to your github Cata repository online
Change the branch to the changed one and click the green arrow button
Input a description and submit your PR!
You can check comments on your PR here, once it gets pulled you can delete your branch (do it through the app). If you need to change/update your PR just make your changes in the PR branch locally and then sync them through the app, it will automatically update the online version.

As long as you follow these steps there’s only two other things you need to do:

Open up the shell and type “git remote add upstream https://github.com/CleverRaven/Cataclysm-DDA.git” You should only need to do this once when you first make the repository.
When you want to update your main branch (do this anytime before making a new PR branch) switch to your master branch (which you should never be making changes on), open up the shell, and type “git pull upstream master” followed by “git push”.

youtoo · 2013-10-30T14:37:22.000Z

i have used git at work before. i generally have to write the commands down. i found them to be goofy. we should take these instruction and sticky them in the mod section.