Overmap Specials: 72 Limit

druidniam · 2017-12-14T06:37:16.794Z

Is this still a thing or did it get upped sometime in november and I missed a PR for it. Suddenly noticed Pk’s, Cata++, Urban Development, More Buildings and More Locations (129 overmap specials) stopped throwing warnings at me.

Edit: @kevin.granade since this came up in another post and was never answered.

druidniam · 2017-12-27T11:34:55.301Z

2 week ping of @kevin.granade since this still hasn’t been answered.

DaWhatTheFox · 2017-12-27T15:41:16.497Z

It is still a thing. I am on version #7026, which is the second latest build.

Zhilkin · 2017-12-27T16:57:30.345Z

github.com

CleverRaven/Cataclysm-DDA/blob/7ee93bc46d19f23a44f80fb948796ee702f7d5a7/src/overmap.cpp#L334




void overmap_specials::finalize()
{
for( const auto &elem : specials.get_all() ) {
    const_cast<overmap_special &>( elem ).finalize(); // This cast is ugly, but safe.
}
}


void overmap_specials::check_consistency()
{
const size_t max_count = ( OMAPX / OMSPEC_FREQ ) * ( OMAPY / OMSPEC_FREQ ) / 2;
const size_t actual_count = std::accumulate(  specials.get_all().begin(), specials.get_all().end(), static_cast< size_t >( 0 ),
[]( size_t sum, const overmap_special &elem ) {
    return sum + ( elem.flags.count( "UNIQUE" ) == ( size_t )0 ? ( size_t )std::max( elem.occurrences.min, 0 ) : ( size_t )1 );
} );


if( actual_count > max_count ) {
    debugmsg( "There are too many mandatory overmap specials (%d > %d). Some of them may not be placed.", actual_count, max_count );
}


specials.check();

proxiehunter · 2017-12-27T20:35:41.855Z

So, what is the reason for the limit and is there any way to be rid of it? It makes combining some mods very difficult.

mlangsdorf · 2017-12-27T22:39:32.611Z

An overmap is divided into 72 regions, each of which can have its own overmap special. It works out to roughly 2 specials in any 15 by 15 overmap tile space.

OMSPEC_FREQ is set in omdata.h, so if you can compile your own versions, you can change the spacing. It starts at 15, and if you made it 10, there could be 180 or so mandatory map specials.

BorkBorkGoesTheCode · 2017-12-27T22:49:14.220Z

What would the visual effect be? Would the map look crowded?

proxiehunter · 2017-12-27T23:23:15.132Z

If not it sounds like it could stand to be made a configurable option in the settings menu. That way people who want to use mods that add a lot of mandatory specials don’t need to mess around with compiling their own versions and people looking for a little more challenge can make specials more rare.

mlangsdorf · 2017-12-28T01:17:57.441Z

I can’t currently compile the game but I suspect as you lower the frequency value (which decreases the square size and increases the number of specials), the map is going to start looking crowded. At OMSPEC_FREQ 6, some of the larger specials (the new mansions, for instance) are going to start intruding on each other.

I do agree that it should be a configurable option. I may try coding up a patch for it in January.

kevin.granade · 2017-12-28T02:24:04.888Z

The limit reflects what the engine is capable of, the bug here is with mods misusing the mandatory specials list to force spawning of “nice to have” map entities.

The mandatory specials list should only contain specials that will break the game if they are missing.

psyxypher · 2017-12-28T02:29:33.937Z

kevin.granade:

The mandatory specials list should only contain specials that will break the game if they are missing.

That makes it so much more simpler.

druidniam · 2017-12-28T02:33:01.194Z

There must be an error message I globally set to ignore then at some point. I’ll go through UD and fix all 48 locations so they aren’t on the mandatory spawning list and that should clear up the loading of all the various mods. Who maintains that anyway, @Chezzo?

Zhilkin · 2017-12-28T07:03:27.414Z

kevin.granade:

The limit reflects what the engine is capable of, the bug here is with mods misusing the mandatory specials list to force spawning of “nice to have” map entities.

The mandatory specials list should only contain specials that will break the game if they are missing.

I guess there are two uses for mandatory specials:

place at least X buildings of certain type on the overmap;
make all of start/quests locations spawn at least once on the overmap.

The latter one is aimed to fix game break, but former one is also valid case sometimes.

kevin.granade · 2017-12-28T15:23:09.104Z

Zhilkin:

The latter one is aimed to fix game break, but former one is also valid case sometimes.

Not if it is resulting in hitting the limit, which it clearly is.