So I was having trouble fishing in a classic zombies game and I may have found a gap.
Fish are spawned in GROUP_FISH and GROUP_RIVER, but it looks like GROUP_FISH isn’t called anywhere in overmap.cpp. I think the difference between the groups is to remove the “mutated” fish from the rivers in classic zombies because GROUP_RIVER is removed from classic zombies, but it appears that it may have been an oversight that GROUP_FISH isn’t used instead (or anywhere).
I’m no expert, but a copy/paste of the river spawn made without the !CLASSIC check might work?
if (ACTIVE_WORLD_OPTIONS["CLASSIC_ZOMBIES"]) {
// Figure out where rivers are, and place swamp fauna (fish/wildlife instead of mutated monsters when classic zombies is on)
for (int x = 3; x < OMAPX - 3; x += 7) {
for (int y = 3; y < OMAPY - 3; y += 7) {
int river_count = 0;
for (int sx = x - 3; sx <= x + 3; sx++) {
for (int sy = y - 3; sy <= y + 3; sy++) {
if (is_river(ter(sx, sy, 0))) {
river_count++;
}
}
}
if (river_count >= 25)
add_mon_group(mongroup( mongroup_id( "GROUP_FISH" ), x * 2, y * 2, 0, 3,
rng(river_count * 8, river_count * 25)));
}
}
}
Looks like GROUP_FISH was also made so you don’t fish up zhark, but do you more code-savvy people think this hack would work?