A script to make a mod out of uncommitted changes in data/json

Game Talk The Lab
1

Hi! I was looking at the state of Firearms Overhaul pull request and noticed that it gets stale again and again, and that all proposed changes could as well be in a mod.

So I made this little script:


And here’s the mod: https://github.com/fungusakafungus/Cataclysm-DDA/releases/tag/PR22756-v1.0

2

So this mod implements the various changes that have been suggested or what?

3

Yes, the mod implements exactly the changes proposed in Firearms Overhaul pull request. It’s just an automatic conversion.

4

I appreciate your effort, but the PR doesn’t actually fix what it sets out to, which is one if the reasons it hasn’t been merged.
https://github.com/CleverRaven/Cataclysm-DDA/issues/22753 discusses what the balance should be, but additionally setting the range on guns doesn’t set effective range, just a range cap.