Massive and reproducible slowdown (git425255a5)

Valase · March 9, 2021, 3:08pm

Still seems a bit weird to me…

Known bug, see:

and it was fixed already:

github.com/CleverRaven/Cataclysm-DDA

Fix aim item duplication

CleverRaven:master ← Jamuro-g:Fix-aim-item-duplication

opened 05:41PM - 05 Mar 21 UTC

Jamuro-g

+8 -8

#### Summary Bugfixes "AIM item duplication" #### Purpose of change A pre…vious pr of mine (#47796) caused a bug that duplicated items in certain cases. (When moving partial stacks via AIM, with both destination and target location being floor tiles) Fixes #47884 #### Describe the solution - My stolen items pr turned a reference into a copy ... reverted this change to the original code. - Instead now the check for item ownership is moved up before any charge/stack count manipulation could happen. This should prevent the duplication issue and still prevent the player from moving/hauling stolen goods without picking them up first. (and prevent the original crash) #### Testing - Spawn in a bunch of ammo - Get into AIM and move a portion of that amo stack from one floor tile to another - The total amount of ammo should remain the same (no duplication) Stolen flag handling - Download linked save in issue #47726 - Try to move the item stack with stolen flags (!) either via AIM or the hauling action - Examine the items - Should not crash and the items that aren't owned by the player should still be in the same tile they originally were (not moved)