Hello everyone.
Been playing CDDA for quite a while, on and off since 2021 or so, Recently I’ve been encountering a pretty annoying crash thats been preventing me from playing the game. I havent done any tests or anything, but it seems like every time I kill an entity, dosent seem to matter, the game crashes to desktop. I do have my log file, and I am updated to the latest version as of 9:34 pm, 03/23/23. I cant seem to post my log file here, but yeah, very unfortunate, and I hope someone can help.
Might be related to this issue where achievements crash the game, there’s an achievement for first kill. No fix yet, but the thread mentions a workaround where you open the achievements window first [Default is ) hence the square brackets lol] and that may prevent the crash.
1 Like
Ill try that and see if it works
So far so good! thank you so much!
That WAS the fix, buuut, now I cant access the achievement menu. I updated literally once, and the option is 100% gone. I looked it up in the keybind menu, no dice, its just gone. Am I just stupid or is there something else going on?
CleverRaven:master ← strategineer:move_kill_count_and_achievements_keybinds_to_diary
opened 12:29PM - 22 Mar 23 UTC
<!-- HOW TO USE: Under each "#### Heading" below, enter information relevant to … your pull request.
Leave the headings unless they don't apply to your PR.
Please read carefully and don't delete the comments delimited by "< !--" and "-- >"
Once a pull request is submitted, automatic stylistic and consistency checks will be performed on the PR's changes.
The results of these can be either seen under the "Files changed" section of a PR or in the check's details.
NOTE: Please grant permission for repository maintainers to edit your PR. It is EXTREMELY common for PRs to be held up due to trivial changes being requested and the author being unavailable to make them. -->
#### Summary
None
<!-- This section should consist of exactly one line, edit the one above.
1. Replace the word "Category" with one of these words: Features, Content, Interface, Mods, Balance, Bugfixes, Performance, Infrastructure, Build, I18N.
2. Replace the text inside the quotes with a brief description of your changes.
Or if you don't want a changelog entry, replace the whole line with just the word "None" (with no quotes).
For more on the meaning of each category, see:
https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/CHANGELOG_GUIDELINES.md
If approved and merged, your summary will be added to the project changelog:
https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/changelog.txt -->
#### Purpose of change
<!-- With a few sentences, describe your reasons for making this change. If it relates to an existing issue, you can link it with a # followed by the GitHub issue number, like #1234. If your pull request *fully* resolves an issue, include the word "Fix" or "Fixes" before the issue number, like: Fixes #xxxx
If there is no related issue, explain here what issue, feature, or other concern you are addressing. If this is a bugfix, include steps to reproduce the original bug, so your fix can be verified. -->
See issues below for more details.
Fixes #59686
Fixes #59685
#### Describe the solution
- Remove global "scores" keybind from code and replace it with a VIEW_SCORES keybind accessible only from the diary menu.
- Re-use "scores" keybind's default use of ')' for the key to access the diary by default.
- Implement VIEW_SCORES keybind and hint at its use from the diary menu.
#### Describe alternatives you've considered
None.
#### Testing
- Checked changed keybinds and ensured that they appeared in the right places and worked as expected.
#### Additional context
diary menu:
diary keybindings:
achievements/scores/killcount menu showing overlaid on top of diary menu:
Maybe this is why you cannot see the achievement menu / keybinding anymore.
What are the chances this gets shoved out within 30 mins of me figuring out a fix for that lol.