Draw knife from survivor utility belt, crash

Thwap · 2015-08-25T11:00:05.000Z

Version 3609, every time. Can draw fine from a sheath.

Coolthulhu · 2015-08-25T14:23:04.000Z

Can’t reproduce. Could be a save thing.

What kind of knife?

Thwap · 2015-08-25T17:55:03.000Z

Yeah sorry, looks like a save thing

Random_dragon · 2015-08-25T19:15:33.000Z

Did you transfer the save from an older version to one of the more recent experimentals?

If so, is the knife in question a tanto or survival knife?

Thwap · 2015-08-30T05:00:36.000Z

Still happening, no save shenanigans at all. v3609

EDIT: Bingo! Non-reinforced knives do not cause crash, only reinforced, exact type seems irrelevant.

Random_dragon · 2015-08-30T15:31:50.000Z

Alright, testing in build 3626, or a3a5eb2.

Survivor utility belt? Check. Steak knife? Check. Soldering iron? Check.

If you haven’t already reported this to Github, I’m gonna do some more !!SCIENCE!! on this to see what other variations yield a crash, then report it.

EDIT: Attempts to muck with this further led me to disassemble the SUB rather than debug another survivor’s belt. New bug: it ate my knife.

EDIT 2: Debugged another knife and scrap metal. Drawing knife from survivor’s belt works fine.

EDIT 3: Drawing it from a normal sheath and boots are also fine.

EDIT 4: No wait, found my knife. Didn’t eat it.

EDIT 5: Guess what? It isn’t just reinforced knives.

EDIT 6: Issue reported on github ( https://github.com/CleverRaven/Cataclysm-DDA/issues/13453 ).

Thwap · 2015-08-30T17:15:11.000Z

Good times

Random_dragon · 2015-08-30T18:08:38.000Z

Plenty of science ensued. Dunno what the cause is. I have another hunch though, lemme test what happens when I reinforce or damage the belt…

EDIT: Nope. Condition of belt does not affect results.

Thwap · 2015-09-01T05:26:12.000Z

Poked at this a little more, can’t figure out anything else. Thought it might have to do with the reinforcement status of the survivor belt used to make the utility belt but nope.

Slax · 2015-09-01T11:09:39.000Z

It’s a survivor belt, man. It’s seen some shit. It’d rather take out the whole world than give you back that knife.

Thwap · 2015-09-01T17:43:19.000Z

Someone on Gith is saying they can’t reproduce this, but I’m reproducing it right now, using the exact steps they describe, in the latest experimental.

Random_dragon · 2015-09-01T18:55:22.000Z

They rattled off some Cygwin or whatever stuff, so I’m assuming they aren’t using the pre-compiled versions from the main site like sane people use. :V

Thwap · 2015-09-01T20:44:05.000Z

Confirmed: Turning off item health bars in the interface settings prevents the crash.

Random_dragon · 2015-09-01T20:49:51.000Z

Oh that is weird.

Thwap · 2015-09-01T21:39:10.000Z

Yeah this is such a weirdly specific bug. Only damaged/reinforced knives, only the utility belt, only with item health bars on, and only with certain compilers.

Random_dragon · 2015-09-01T22:07:22.000Z

Go home Cataclysm, you’re drunk. >.<

Thwap · 2015-09-01T23:29:52.000Z

You know what’s especially odd? The fact that it crashes when the utility belt containing the reinforced knife is activated. Not when the knife itself is drawn. You don’t even get the menu. That means the game isn’t even trying to draw the item health bars at the moment it crashes.

Here’s something else funny: I went looking through the jsons and it looked like the utility belt was the only item that both had tool uses and functioned as a sheath. Well, since the utility belt is also the only item causing this problem, that seemed noteworthy.

So I went into tools.json and slapped SHEATH_KNIFE into the USE_ACTION line for the toolbox. Fired up a new game, left item health bars on, made a reinforced knife, used the toolbox, and could sheath and unsheath it from the box without issue.

Then I went and replaced the entire USE_ACTION line for the toolbox with the one from the utility belt. Fired up a new game, spawned a toolbox, and sure enough had a toolbox with all the same functions as the utility belt. Except I could still sheath and unsheath reinforced knives from it, with item health bars on, without issue.

I don’t know if any of this is helpful or not but there it is.

Random_dragon · 2015-09-01T23:47:36.000Z

That’s…what the fuck.

Thwap · 2015-09-02T00:09:31.000Z

So I took the radiation biomonitor and did the same thing, replaced the USE_ACTION line with the one from the utility belt. Did the whole rigamarole. Crash. So I guess it has something to do with the item being wearable? Maybe the fact that it has an item health bar itself? Or just that they’re both in the tool_armor json? I don’t know.

Random_dragon · 2015-09-02T00:15:45.000Z

Hmm, odd. Did you copy the use actions to a non-wearable item and try that?

If it works in that case, it might be because armor displays a health meter by default, whereas other items only display it when damaged or reinforced.