Crashes, bugs, etc

OS: WIN7 64
Mods:
“dda”,
“no_npc_food”,
“filthy_morale”,
“novitamins”,
“growable-pots”

Below i changed every @ to & in the crash log, because the forum engine refused to allow them, because they looked like as usernames.

8583

  • NPC accept filthy clothes as trading item. What a deal!
  • Fail to make a headlight still waste the flashlight. Old and very annoying problem especial at the first days in the game…
  • siphon from a Hippie Van with 0% gasoline, got 2 errors messages +200 fuel and still 0% syphonable gasoline in the tank. The 1. error: Tried to drain something without any liquid: vehicle tank (60L) ammount:0 ammo:0 Function int vehicle::drain(int, int) File: src/vehicles.cpp Line: 2812. The 2. error was the same except the ammount was 200.
  • Squirrels can’t go through chain link fence. All small creatures should be able to do it.
  • Armored Car with M249 mount at the back has an ordinary ammo also 1 ammo which can be take infinite times.

8613

  • load bad ter! ter cementery_4square_xx
  • boring sandwich (2 cornbread, 1 pesto) gives 2x84 kcal while 1 pesto gives 244 kcal…
  • recraft last recipe doesn’t works (“craft something first!”)
  • can’t siphon gasoline from one vehicle to another, the game crash:

CRASH LOG FILE: config/crash.log
VERSION: 0.D-498-g5b6a055
TYPE: Signal
MESSAGE: SIGABRT: Abnormal termination
STACK TRACE:
&0x554E45[cataclysm-tiles.exe+0x154E45]
&0x5559F2[cataclysm-tiles.exe+0x1559F2]
raise+0x235&0x7FEFD651925[msvcrt.dll+0x41925]
IMG_LoadWEBP_RW+0xFDCCB&0x100A2EB[cataclysm-tiles.exe+0xC0A2EB]
IMG_LoadWEBP_RW+0xFDDA7&0x100A3C7[cataclysm-tiles.exe+0xC0A3C7]
&0x71F499[cataclysm-tiles.exe+0x31F499]
&0x73B6D5[cataclysm-tiles.exe+0x33B6D5]
&0xD29DD1[cataclysm-tiles.exe+0x929DD1]
&0x4E9863[cataclysm-tiles.exe+0xE9863]
&0x427EF7[cataclysm-tiles.exe+0x27EF7]
&0x432AEC[cataclysm-tiles.exe+0x32AEC]
&0xB7FF3B[cataclysm-tiles.exe+0x77FF3B]
&0x646EA4[cataclysm-tiles.exe+0x246EA4]
&0x686557[cataclysm-tiles.exe+0x286557]
IMG_LoadWEBP_RW+0x4D2619&0x13DEC39[cataclysm-tiles.exe+0xFDEC39]
&0x4013ED[cataclysm-tiles.exe+0x13ED]
&0x4014FB[cataclysm-tiles.exe+0x14FB]
BaseThreadInitThunk+0xD&0x76D4571D[kernel32.dll+0x1571D]
RtlUserThreadStart+0x1D&0x76FA385D[ntdll.dll+0x5385D]

8615

  • load bad ter! ter cementery_4square_xx hdwr_large_*
  • fruit slice material is plastic. If i try to craft it then the game crash:
    assertion failed file: src/optional.h, line:45 Experssion:full

CRASH LOG FILE: config/crash.log
VERSION: 0.D-498-g5b6a055
TYPE: Signal
MESSAGE: SIGABRT: Abnormal termination
STACK TRACE:
&0x554E45[cataclysm-tiles.exe+0x154E45]
&0x5559F2[cataclysm-tiles.exe+0x1559F2]
raise+0x235&0x7FEFD651925[msvcrt.dll+0x41925]
IMG_LoadWEBP_RW+0xFDCCB&0x100A2EB[cataclysm-tiles.exe+0xC0A2EB]
IMG_LoadWEBP_RW+0xFDDA7&0x100A3C7[cataclysm-tiles.exe+0xC0A3C7]
&0x71F9B9[cataclysm-tiles.exe+0x31F9B9]
&0x5407F3[cataclysm-tiles.exe+0x1407F3]
&0x40EAF0[cataclysm-tiles.exe+0xEAF0]
&0x432C0C[cataclysm-tiles.exe+0x32C0C]
&0xB7FFF0[cataclysm-tiles.exe+0x77FFF0]
&0x646EA4[cataclysm-tiles.exe+0x246EA4]
&0x685D7C[cataclysm-tiles.exe+0x285D7C]
IMG_LoadWEBP_RW+0x4D2619&0x13DEC39[cataclysm-tiles.exe+0xFDEC39]
&0x4013ED[cataclysm-tiles.exe+0x13ED]
&0x4014FB[cataclysm-tiles.exe+0x14FB]
BaseThreadInitThunk+0xD&0x76D4571D[kernel32.dll+0x1571D]
RtlUserThreadStart+0x1D&0x76FA385D[ntdll.dll+0x5385D]

Siphoning is fixed by this: https://github.com/CleverRaven/Cataclysm-DDA/pull/28700

Fruit slices fixed by this: https://github.com/CleverRaven/Cataclysm-DDA/pull/28725

You can just click the “ignore” on the error until the message goes away. Things will probably work fine.

After the update, siphoning 6.3 litre gasoline from another vehicle turned the 49.6 L gasoline into 2.3 litre in my car. Syphoning another 6.3 litre gasoline (that vehicle had 2 tanks) changed nothing, still 2.3 litre…

Ookay. Found the reason for that.

As long as you use containers that are less than 4 liters and are empty the bug shouldn’t happen with gasoline (I think).

Making pull request for the fix now…

Edit: Actually it kind of completely breaks refueling a car if you want to put more than 4l of fuel in its tank.
#28732 fixes this.