Crafting progression

[kevin.granade]

Technical point, it’s not that hard to store an in-progress craft.
That’s definitely the route I want to take.

[ecchi_squid]

I just thought of the fact that the idea might not be compatible with the current crafting design. The game gives you a chance that you may not succeed, or you fail. If the incomplete item doesn’t succeed, it would have to store the component data and refund it when it fails to succeed. That sounds like a mess.

[mlangsdorf]

It could/should calculate success at the start of the project and consume resources at the same time. You wouldn’t know if the craft was successful until it was complete, though you might let some failures opt out early, as a kind of “you screwed up but realized it early enough”.

[Trigon]

What Dorf said would also be an interesting skill roll. If you’re closer to the level needed to craft an item but fail you may realize your mistake early and save precious time. Or on the other end you fuck up a vital component of the craft at the start and need to get new materials.

[TheKobold]

Bladesmiths don’t make mistakes, they make shorter blades =P…

I guess I will digress on the incomplete component path. If it means that pausing crafting and resuming gets some much needed love.

[mlangsdorf]

So crafting already works by creating a player_activity and advancing the crafting process every game turn, then calling craft_complete when the activity ends. The game already keeps track of the recipe in the player_activity.

Two ways I can see to handle this:

1. The better way is to give player_activity:: a call_cancel() function, which would let each player_activity have its own optional, specialized function to handle canceling. For the craft activity, craft_cancel could calculate how much of the process you’d completed, possibly generate a subset of the crafted items for batch crafting, and create the continuation item.You would then activity the continuation item to continue long crafting, and that would check that you still meet the requirements.
2. The less good way is to generate the continuation item at the start, and update it continuously in in craft_do_turn. Which is a perfectly valid solution, don’t get me wrong, it’s just adding a cancel path would be more generally useful.

It’d be an interesting coding project for someone.

[kevin.granade]

If you wanted to have intermediate progress, you could have it under the hood, but not expose it as distinct items.
So if your recipe takes 10 components, it could specify when each of them is consumed.

Not sure how much value there is in that though.

[darktoes]

It’d be really nice if it didn’t just annihilate all materials on a failure. Destroying a few materials, or the things most likely to be destroyed, would make more sense. For some things I don’t see how you even can destroy the materials. Take making a sword, unless you somehow evaporate the steel, how do you destroy a bunch of scrap metal? Wouldn’t you just have scrap metal again?

[Azure_Soul_Azur]

You can fuck up so bad the metal is not really that useable anymore… really you can.

[darktoes]

You’re already at the point where you melt it down (based on the crucible in most recipes), and you don’t seem to be adding anything to the metal. What could you do to it that you couldn’t melt it back down into a new ingot/blank/whatever?

[TheKobold]

While forging weapons, you should never be melting the steel, you burn off the carbon that way and end up with weird iron and slag. Smelting steel is pretty difficult to get right, 9 times out of 10 you will end up with something other than what you want.

What weapon recipes use the crucible?

[darktoes]

Not the ones I thought. Wonder what recipe I was thinking of that always has me running around looking for a crucible midgame?
Either way, I can’t imagine what you can do to steel to make it more useless than the mangled assorted steels that scrap metal currently is.

That was just an example though. There are plenty of other things you can craft that really shouldn’t be destroyed if you mess up. Things like the tools in a toolbox, the baseball bat in a barbed wire bat, or probably some other stuff I can’t think of. And it still makes sense that not all of the materials would be destroyed. It would probably make more sense if recipes were divided into sections (eg. sew torso, sew left arm, sew right arm, sew hood, attach pockets, attach zipper) and each section had certain components assigned to it. Each section could have a check, and if you fail a check you fail that section, but would only lose some of the components, or only the components involved in that section.

It would make recipes far more complicated, but I think it would make crafting and grinding a bit more interesting.

[TheKobold]

I agree with you on how some items shouldn’t be destroyed during the crafting process.

Maybe it could resulted in a unusable product that could be disassembled for most of the components back

[darktoes]

Perhaps, though it would make sense if you could continue where you left off if you, say, failed to make the stopper on a waterskin, but still made the rest without issue.

[Malakh]

Reading all this made me realize that my issue wasn’t with the actual crafting progression and whether or not weapon tiers were a good idea, but rather the pacing of crafting skill progression in relation to world difficulty progression.

The main way the world gets harder is that as the seasons pass, the zombies become more powerful.

However, with a few books (all of which can be found in bookstores or libraries), a player can get get a full suit of heavy survivor armor and a great melee weapon before Spring is over.

Perhaps there could be a limit to how fast, calendar-wise, crafting can improve irrespective of books / grinding, and in that way keep a more even relationship between player strength and monster strength to keep the challenge going for longer. Also, making at least some elements of crafting require broader exploration so that the player is forced to actually go beyond the first town to achieve good gear.

[darktoes]

There’s been a lot of discussion on improving skill levelling so that you can’t sit and read books for a few hours to master everything. A lot of the ideas involved including both a book portion and a practical portion, which would do nicely since players would need to do a lot of crafting and resource gathering to get to the point where they can make the good stuff.

[Malakh]

Is that discussion happening on discourse, git or offline?

[mlangsdorf]

See Practice makes perfect

[Malakh]

The last comment in there is from January …

[mlangsdorf]

That’s the lot of discussion. It’s not a lot of recent discussion, but it’s a lot of discussion, and I pulled the Practice makes perfect link from the github projects page: https://github.com/CleverRaven/Cataclysm-DDA/projects