The Minor JSON Questions Thread

africalinguist · 2017-05-19T01:25:06.000Z

i am making a mod that adds more energy weapons but when the world loads it says “result: c-23 in recipe c-23 is not valid” or something like that

Alec_White · 2017-05-19T01:28:20.000Z

africalinguist:

i am making a mod that adds more energy weapons but when the world loads it says “result: c-23 in recipe c-23 is not valid” or something like that

You probably have a recipe that has the wrong item ID as result.

africalinguist · 2017-05-19T01:59:27.000Z

thanks alec white yes you were right. the item id was s-23 not c-23

pisskop · 2017-05-25T21:56:23.000Z

Anyone know why my custom lighter can start overworld fires but wont spark a cigar?

{
“id”: “ref_lighter_string”,
“type”: “TOOL_ARMOR”,
“name”: “wearable lighter”,
“copy-from”: “lighter”,
“description”: “A lighter with a bit of string and taping to allow it to be worn about the neck like a lanyard. A bit fumbly to get a hold of, but perfectly servicable.”,
“weight”: 25,
“volume”: 0,
“price”: 3000,
“material”: “aluminum”,
“symbol”: “,”,
“color”: “light_gray”,
“coverage”: 1,
“encumbrance”: 0,
“storage”: 0,
“warmth”: 0,
“material_thickness”: 1,
“ammo”: “gasoline”,
“max_charges”: 50,
“rand_charges”: [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 2, 3, 5, 7, 11, 13, 17, 21, 27 ],
“charges_per_use”: 1,
“use_action”: [
{
“type”: “firestarter”,
“moves”: 60,
“moves_slow”: 600
}
]
},

Zhilkin · 2017-05-26T14:42:56.000Z

[quote=“pisskop, post:107, topic:12858”]Anyone know why my custom lighter can start overworld fires but wont spark a cigar?

{
“id”: “ref_lighter_string”,
“type”: “TOOL_ARMOR”,
“name”: “wearable lighter”,
“copy-from”: “lighter”,
“description”: “A lighter with a bit of string and taping to allow it to be worn about the neck like a lanyard. A bit fumbly to get a hold of, but perfectly servicable.”,
“weight”: 25,
“volume”: 0,
“price”: 3000,
“material”: “aluminum”,
“symbol”: “,”,
“color”: “light_gray”,
“coverage”: 1,
“encumbrance”: 0,
“storage”: 0,
“warmth”: 0,
“material_thickness”: 1,
“ammo”: “gasoline”,
“max_charges”: 50,
“rand_charges”: [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 2, 3, 5, 7, 11, 13, 17, 21, 27 ],
“charges_per_use”: 1,
“use_action”: [
{
“type”: “firestarter”,
“moves”: 60,
“moves_slow”: 600
}
]
},[/quote]

github.com

CleverRaven/Cataclysm-DDA/blob/4bcc67a9d0b5dc3d2b8844fb3705e4b524fdcb23/src/iuse.cpp#L397-L409


int iuse::smoking(player *p, item *it, bool, const tripoint&)
{
bool hasFire = (p->has_charges("fire", 1));


// make sure we're not already smoking something
if( !check_litcig( *p ) ) {
    return 0;
}


if (!hasFire) {
    p->add_msg_if_player(m_info, _("You don't have anything to light it with!"));
    return 0;
}

int iuse::smoking(player *p, item *it, bool, const tripoint&)
{
    bool hasFire = (p->has_charges("fire", 1));

    // make sure we're not already smoking something
    if( !check_litcig( *p ) ) {
        return 0;
    }

    if (!hasFire) {
        p->add_msg_if_player(m_info, _("You don't have anything to light it with!"));
        return 0;
}

ref_lighter_on = refillable lighter (lit) also does not provide fire for cigarettes.

You can check this in LUA console by this command:

game.add_msg(tostring(player:has_charges(“fire”,1)))

Probably same issue as described in https://github.com/CleverRaven/Cataclysm-DDA/issues/21005

pisskop · 2017-05-26T16:09:23.000Z

oh hey, thanks for the update edit.

I was doing my own doodadaling with the jsons and came to the conclusion that it must be a hardcode somewhere?

Taberone · 2017-08-03T22:57:02.000Z

how do I reduce the number of mandatory overmap specials in More Locations and Z-Level Buildings mod?

pisskop · 2017-08-03T23:33:40.000Z

Inside the overmap special.json file there are tags for [occurances].

You mod those two bracketed numbers.

Numbers range from [-1,-1] to … … whatever.

-1 means 'no limit’
0 means 'none’
A number represents its contemporary quantity.

The first number is a minimal amount. the second a max.

… and for the record, Id shy away from using -1. it scares the game.

DeWolf · 2017-08-22T20:59:26.000Z

So is there anything in the Jason’s for the latest experimental s that determines how much engine power a combustion engine has or is this something that is hard coded now?

pisskop · 2017-09-01T17:01:09.000Z

Is it possible to get a turret to run off battery charge any longer?

Coolthulhu · 2017-09-02T07:05:21.000Z

DeWolf:

So is there anything in the Jason’s for the latest experimental s that determines how much engine power a combustion engine has or is this something that is hard coded now?

It needs to be declared in its item definition Json now.

pisskop:

Is it possible to get a turret to run off battery charge any longer?

It should be. If not, it’s probably a bug. Provide an example though - I’m not sure what kind of battery powering do you have in mind. Battery as magazine, vehicle battery, battery-using-gun specified to use UPS not working or what?

pisskop · 2017-09-02T13:29:21.000Z

Well, I have a gun that uses battery to fire. A tesla coil, if you will.

The gun was originally intended to be too unwieldy to use by hand, but could be mounted. Back when car batteries could be charged via standard batteries it worked fine when mounted, drawing 100 charge per shot, doing minimal damage per shot, but stunning, lighting up, and bouncing off enemies.

The gun, Ive been informed, will still require batteries when mounted, due to the new turret mechanics.

Anywho, the issue may be the ups version of the gun not drawing power at all from ups.
Which is another issue entirely, but this shockcannon is incompatible with a ups conversion kit. I got around that by making an actual ups powered version, but it will not draw power from ups, making it an infinite ammo gun.

Coolthulhu · 2017-09-03T10:20:22.000Z

Weapons may have problems consuming electricity directly, if ammo is specified to be battery, as there is no instance of this happening in core game.
If you want to use it that way, report it, but it may later bitrot again for as long as there is no turret in the core that works this way.

The UPS part however is an obvious bug. UPS weapons are supposed to properly draw power from vehicle storage.

pisskop · 2017-09-03T14:04:30.000Z

it actually works now, with some tweaking. thanks!

needed some adjusting, but i do think if battery is an ammo than conversation kits should work on any type of item that could accept them

Taberone · 2017-09-05T01:25:10.000Z

How do I add in a custom monster? Not looking to have it naturally spawn yet, just want a custom monster I can spawn through debug menu for now.

Noctifer · 2017-09-05T02:03:06.000Z

Look at monsters.json and copy the entry that most matches your monster in question. Then modify it and slap the file with that bit of code in a mod.

pisskop · 2017-09-05T02:05:21.000Z

easiest way is to copy one from

/data/json/monsters

and give it a new id. if you felt like it you could give all the monsters exactly identical stats. except the id. id has to differ.

try to take a mon that is somrwhat similar to your own idea.

p:. you evil ninja

Taberone · 2017-09-05T14:41:38.000Z

What about default_faction and species? Thinking of adding in a Touhou character as an enemy.

EDIT: Nevermind, I found it. Monster_factions.json and species.json. Going to experiment with those to fit what I have in mind, since it probably won’t fit into any existing factions and I’m not sure about setting it to “humans”, since the character I was going to add isn’t technically human. On a side note, I’ve noticed that no monster seems to use “human” as the default faction.

pisskop · 2017-09-05T14:55:18.000Z

‘human’ is meant to be player/npc. its likely that the ‘human’ flag and the npcs themselves obsoleted that species.

harison86 · 2017-09-15T23:38:38.000Z

Trying to make a balancing mod, wanted to adjust the stats of various armors but when I looked at the json I realized it didn’t work quite like what I anticipated. Is there a way to adjust the bashing and cutting protection stats of armor directly in the json, or do I just have to work with “material_thickness” of the armor and the properties of the materials in the materials json? And how is bashing and cutting protection for armor calculated?