Rainwater Catch & Funnels

[Miloch]

Ok, I have a question about these. I don’t really understand the current implementation of them. I understand they are a funnel setup in the rain… This would catch very little. A raincoat/poncho would work. Sheet Metal would work. It’s all about surface area. Heck, in a pinch you could use tight fitted wood. But plastic bottles to make a funnel…? This seems a bit ridiculous to me. If you were trying to use the least efficient method, sure go for it. You should fill an entire tile with buckets and all that.
Hell, a sheet would work (though much less efficiently) better then just a funnel. Spread it out at a 45 degree angel and there you go. Most of the water it catches could be directed into a container.

[Random_dragon]

If we had constructed funnels of some sort, that would be a useful feature. But multi-tile rain-catchers condensing into a single collection point, I’m unsure how practical that’d be to code.

[Miloch]

Shouldn’t be difficult. But I’m not even talking about that. Just the point that raincatchers are about area and not a single funnel.

[Random_dragon]

Granted, the makeshift funnels are absolutely awful at rain-catching, but I have had the proper funnels rapidly fill entire steel jerrycans. >.>

[Miloch]

Well imagine IRL. You stick a Jerrycan with a funnel out in the rain. How fast do you really think it’d fill?
Compare this will a sheet of sheet metal and a Jerry can.

[Random_dragon]

Understandable. Personally, I think makeshift funnels don’t need tweaking, but regular funnels might. They have a collection radius of 380, whereas leather and makeshift funnels only have 85.

I could maybe see if I can implement constructable funnels using sheet metal, tarps, or such, possibly as an addition to More Survival Tools…

[Miloch]

I say funnels should catch what makeshift do now. Makeshift should catch about the same. Having a construction Menu item that sets up a raincatch to catch what regular funnels do now.
Three kinds me thinks…
Rain Coat catch - Chance of being disabled in high winds.
Wooden Catch - Less efficient as wood is porous and tends to leak.
Sheet Metal Catch - Requires a welding torch to setup well. (maybe a makeshift one that doesn’t as the fourth kind?)

[Random_dragon]

Hmm. Either way I’m working out the details of a rain catch as terrain. Will have to see how doable it is. If it is we can then implement it, either as mainline or mod content, then re-balance the trap funnels accordingly.

I wish Kevin or whoever statted the funnels could give us reasoning behind WHY the funnels have these specific catch rates. Rebalancing would be easier if we knew how the funnel radius stat correlated to catch rates of real-world equivalents.

[Miloch]

Alright, awesome. Thanks Random.

[Random_dragon]

Looks promising so far, can make a terrain also produce a trap, which is how pits work. Mucking about with trap properties to try and get it to stop prompting me if I want to take it down, only for it to not take itself down because I removed the drop option. XD

“That funnel looks too dangerous to mess with. Best leave it alone.”

EDIT: Well…shit. So many bug fixings and now I’m stumped by an inability to get the fucking thing to collect water. ;_;

[Coolthulhu]

EDIT: Well…shit. So many bug fixings and now I’m stumped by an inability to get the fucking thing to collect water. ;_;

Looks like it’s in map.cpp:
map::actualize checks existence of traps with submap::get_trap, which only returns actual traps as opposed to “terrain traps”.
The trap is then set in traplocs. Entry traplocs is necessary for funnels to work. No other trap uses traplocs, I think.

To fix it, you’d have to add a check for “terrain trap” in map::actualize. Terrain trap is checked with something like current_submap->get_ter( x, y ).obj().trap

[Random_dragon]

Oh. HAHAHAH. Right as I posted it in the Toolbox forum. I guess I could PR that?

EDIT: I’d need to figure out how without breaking it though.

[Belteshazzar]

One might try using the vehicular framework for a large raincatch rather than the trap system (just considering that solar panels already use a tile or multiple tiles collect sunlight/energy for batteries.)

[Random_dragon]

Hmm. So what, add vehicle parts for other funnel types?

I like the idea of a constructed raincatcher though. We just need to lay the foundation for terrain-deployed traps to do that, and I have no idea how.

[kevin.granade]

The funnel is a LARGE plastic funnel, 380mm in radius, or 760mm across, OR 0.76 meters wide, in other words it fills most of the tile it’s on. This isn’t a random kitchen or automotive funnel you stick in a can, it’s purpose-built for catching rain.
The makeshift funnel OTOH is exactly that, a small plastic funnel made by cutting and unrolling a plastic bottle.
All the pertinent calculations are spelled out in detail in weather.cpp in funnel_charges_per_turn() and funnel_turns_per_charge.

Now that I take a look at the stats, the funnel item is very misleading, it should be pretty light, but I hadn’t noticed that the volume is massively off, it should be 10+, not 2.

Feel free to add more funnel-type items or clarify the descriptions, but I don’t see any issues with the existing items. If you want to add a chance of things blowing away though, the funnel is a great candidate for that due to it’s surface area and low weight.

[Random_dragon]

Hmm. Still, it would be nice if we had a way to construct alternatives.

Can anyone gimme more info on what I’ve have to do to allow funneling to work with terrain-traps? ;A;

[Random_dragon]

Well. Tarp-based constructed funnel is now a thing, as Series 14 of More Survival Tools ( https://github.com/CleverRaven/Cataclysm-DDA/pull/13271 ) has been merged.

[Miloch]

Nice!

[Random_dragon]

Also gives you free reign to PR mainline versions using other materials if you so wish, and are able to. X3

[Invalid_Username]

The idea, or the thread necromancy?