Places of interest

[Aenye]

LEAK_DAM means that whatever was stored in the item will slowly fall out of the container in question.

Thanks for the info ! If it falls out, can I make it instantly vanish and create a cloud (say like a bloated zombie) ? The idea was to have gas cylinders leak on damage - say LPG - and form a small-but-extremely-flammable cloud.

[KA101]

[quote=“Datanazush, post:63, topic:7085”]LEAK_DAM means that whatever was stored in the item will slowly fall out of the container in question.

Thanks for the info ! If it falls out, can I make it instantly vanish and create a cloud (say like a bloated zombie) ? The idea was to have gas cylinders leak on damage - say LPG - and form a small-but-extremely-flammable cloud.[/quote]

That would need new compiled-code, whether to support new JSON or to hardcode the effect you’re asking to a flag. A hypothetical “LEAK_FLD” might create fields when damaged (specify in the item JSON), but then the field would need coded in C++. I’m not certain how best to write up the field, but I’m sure one could be written that greatly facilitates fire, maybe even explodes when a flame is present.

That said, I’m all for it, as this would allow for actual rather than Bug thermobaric devices.

[Aenye]

[quote=“KA101, post:65, topic:7085”]That would need new compiled-code, whether to support new JSON or to hardcode the effect you’re asking to a flag. A hypothetical “LEAK_FLD” might create fields when damaged (specify in the item JSON), but then the field would need coded in C++. I’m not certain how best to write up the field, but I’m sure one could be written that greatly facilitates fire, maybe even explodes when a flame is present.

That said, I’m all for it, as this would allow for actual rather than Bug thermobaric devices.[/quote]

This would be lovely to have - unfortunately I’m nowhere near the skill required to code something like this in. That said, I’ll prepare all the necessary items and maybe in the meantime someone will have a go at this… I’ve actually got some that could be flammable and some that would be explosive. With the level of chemical ability the PC can achieve, making a basic gas mixture would be almost trivial - one could actually make pretty high-payload bombs quite easily…

[Aenye]

Sorry for double-posting, but I had to do an update even if there were no comments since last time. I’ve pretty much wrapped up the first batch of items in terms of conceptual work. The only thing that’s left is to code them in - would love some help in implementing all of the functionalities I had planned, but even if they are “to be added” for some time, I believe that adding the items will help flesh the world out a bit more.

I’ve went ahead and tried implementing a few basic items - stackable limestone bits / quicklime / sand and cement (well, bricks too, but I’m not happy with the description yet) along with a few recipes for them - could you please take a look at them (and voice your opinions - would like to hear your thoughts on constructing walls with cement and bricks, instead of only with wood/stone). Used one template on the four new items:

Cement: (modifies melee.json)

{ “type” : “AMMO”,
“id” : “material_cement”,
“category” : “spare_parts”,
“price” : 5000,
“name” : “cement”,
“name_plural” : “cement”,
“symbol” : “=”,
“color” : “dark_gray”,
“description” : “Portland is most likely long gone, but it’s memory persists in cement. This ubiquitous binder can be used for all kinds of advanced masonry. Just add water.”,
“material” : “ceramic”,
“volume” : 1,
“weight” : 20,
“bashing” : 1,
“cutting” : 0,
“to_hit” : 0,
“ammo_type” : “components”,
“casing” : “NULL”,
“damage” : 0,
“pierce” : 0,
“range” : 0,
“dispersion” : 0,
“recoil” : 0,
“count” : 50
},

Limestone bits:

{ “type” : “AMMO”,
“id” : “material_limestone”,
“category” : “spare_parts”,
“price” : 5000,
“name” : “limestone”,
“name_plural” : “limestone”,
“symbol” : “=”,
“color” : “dark_gray”,
“description” : “A handful of small chunks of limestone. Useful for experiments at science fairs, but pretty useless as ammo. Maybe something could be crafted from this stuff…”,
“material” : “ceramic”,
“volume” : 1,
“weight” : 14,
“bashing” : 1,
“cutting” : 0,
“to_hit” : 0,
“ammo_type” : “components”,
“casing” : “NULL”,
“damage” : 0,
“pierce” : 0,
“range” : 0,
“dispersion” : 0,
“recoil” : 0,
“count” : 50
},

Quicklime:

{ “type” : “AMMO”,
“id” : “material_quicklime”,
“category” : “spare_parts”,
“price” : 5000,
“name” : “quicklime”,
“name_plural” : “quicklime”,
“symbol” : “=”,
“color” : “dark_gray”,
“description” : “The product of burning limestone, this white powder is a crucial ingredient in making cement. That said, it is also extremely caustic and will cause severe burns to any tissue it comes in contact with. Could also be used to neutralise acid spills…”,
“material” : “ceramic”,
“volume” : 1,
“weight” : 15,
“bashing” : 1,
“cutting” : 0,
“to_hit” : 0,
“ammo_type” : “components”,
“casing” : “NULL”,
“damage” : 0,
“pierce” : 0,
“range” : 0,
“dispersion” : 0,
“recoil” : 0,
“count” : 50
},

Sand:

{ “type” : “AMMO”,
“id” : “material_sand”,
“category” : “spare_parts”,
“price” : 5000,
“name” : “sand”,
“name_plural” : “sand”,
“symbol” : “=”,
“color” : “dark_gray”,
“description” : “A handful of New England sand. If you had a stoked furnace, you could turn it into glass. Otherwise, it’s only good for making cement. And soaking up blood - something particularly useful nowadays.”,
“material” : “ceramic”,
“volume” : 1,
“weight” : 10,
“bashing” : 1,
“cutting” : 0,
“to_hit” : 0,
“ammo_type” : “components”,
“casing” : “NULL”,
“damage” : 0,
“pierce” : 0,
“range” : 0,
“dispersion” : 0,
“recoil” : 0,
“count” : 50
},

Quicklime recipe: (modifies recipe_ammo.json ?)

{
“type” : “recipe”,
“result”: “material_quicklime”,
“category”: “CC_OTHER”,
“subcategory”: “CSC_OTHER_MATERIALS”,
“skill_used”: “fabrication”,
“skills_required”: [ “cooking”, 2 ],
“difficulty”: 3,
“time”: 90000,
“reversible”: false,
“autolearn”: true,
“tools”: [
[
[“crucible”, -1]
],
[
[“forge”, 250], [“char_forge”, 50], [ “oxy_torch”, 50]
]
],
“components”: [
[
[ “material_limestone”, 50 ]
]
]
},

Cement recipe:

{
“type” : “recipe”,
“result”: “material_cement”,
“category”: “CC_OTHER”,
“subcategory”: “CSC_OTHER_MATERIALS”,
“skill_used”: “fabrication”,
“skills_required”: [ “cooking”, 3 ],
“difficulty”: 4,
“time”: 90000,
“reversible”: false,
“autolearn”: true,
“tools”: [
[
[“crucible”, -1]
],
[
[“forge”, 250], [“char_forge”, 50], [ “oxy_torch”, 50]
]
],
“components”: [
[
[ “material_quicklime”, 50 ],
[ “material_sand”, 50 ]
]
]
},

Limestone shard: (modifies melee.json ?)

{
“type”:“GENERIC”,
“id”: “material_shrd_limestone”,
“symbol”: “,”,
“color”: “light_gray”,
“name”: “limestone shard”,
“category”: “spare_parts”,
“description”: “A small shard of limestone. Pretty flimsy and not much of a weapon, but could be used to neutralise acid spills.”,
“price”: 1000,
“material”: “steel”,
“weight”: 700,
“volume”: 4,
“bashing”: 2,
“cutting”: 0,
“to_hit”: -2
},

Limestone shard deconstruction: (modifies recipe_deconstruction.json ?)

[spoiler]{
“type” : “recipe”,
“result”: " material_shrd_limestone ",
“id_suffix”: “uncraft”,
“category”: “CC_NONCRAFT”,
“subcategory”: “CSC_NONCRAFT”,
“time”: 10000,
“reversible”: true,
“autolearn”: false,
“qualities” : [
{“id”:“HAMMER”,“level”:1,“amount”:1}
], “tools”: [
[
[ “crucible”, -1 ]
]
],
“components”: [
[
[ “material_limestone”, 10 ]
]
]
},

Will this one give 10 units of limestone or ten stacks of limestone (each 50 units, as defined by their “count”) ?[/spoiler]

Making sand drop in the field, as rocks do, but slightly less often: (modifies item_groups.json ?)

{
“type” : “item_group”,
“id” : “field”,
“items”:[
[“rock”, 40],
[“material_sand”, 30]
]
},

Making limestone shards drop in mines:

{
“type” : “item_group”,
“id” : “mine_storage”,
“items”:[
[“shovel”, 10],
[“pickaxe”, 2],
[“rock”, 40],
[“toolbox”, 5],
[“coal”, 20],
[“material_shrd_limestone”, 20]
},

Question: If we dump water on fire, it goes out - can it be done (easily) for dumping quicklime on acid streaks and sand on blood splatters to remove them ?

[Zireael]

10 units, methinks, and apart from putting all this into ammo, I love this!

[Snaaty]

Yeah, those items look nice.

Putting all those things in AMMO is probably not the way to go, generic stuff usually goes into melee.json AFAIK.
Some of your things should go in tools.json instead, I guess.

Still, well done Aenye! You said you already have a github account, right? Generall, it is probably a good idea to merge all that great stuff in baby steps. Otherwise you get annoying merge conflicts. Also, for a scope of all those additions, it is a really good idea to keep precise track of what is already in and what still has to go in. (As you already do.)

[Aenye]

10 units, methinks, and apart from putting all this into ammo, I love this!

[quote=“Snaaty, post:69, topic:7085”]Yeah, those items look nice.

Putting all those things in AMMO is probably not the way to go, generic stuff usually goes into melee.json AFAIK.
Some of your things should go in tools.json instead, I guess.[/quote]

Thanks ! I wasn’t sure about stackables - originally I thought of having the game handle limestone bits (and some other resources as well) like it does lead/gold/silver, e.g. putting into a single stack, rather then generating huge numbers of “a bit of lead”-type items. Virtually all instances of such items are stored as “type” : “AMMO” and most of them are in the ammo.json, so I wanted to adopt the same approach. I’ve looked a bit more and found that paints and carpets are also stackable and while they are “type” : “AMMO”, they’re stored in melee.json, so I could pretty send my stuff down there as well.

That said, wouldn’t it be prudent to get all of the not-really-ammo-but-stackables into a different .json or even a different item type, such as type" : “resource” ? Would this be allowable and if so, would it be just a matter of adding a new file and moving all the items in question to it ?

Back to the topic: Which ones should go into tools.json ? Please excuse my newbie question (yet another), but most of the stuff there has some action on activate or has some kind of ‘ammo’ it drains - should I make the items into such ?

Still, well done Aenye! You said you already have a github account, right? Generall, it is probably a good idea to merge all that great stuff in baby steps. Otherwise you get annoying merge conflicts. Also, for a scope of all those additions, it is a really good idea to keep precise track of what is already in and what still has to go in. (As you already do.)

Yup, I’ve even managed to file a proper pull request (though that one took a lot of fidgetting on my part before I clicked the ‘confirm’ button). Thanks - I’ll be trying to go over all the stuff bit by bit and marking off what gets implemented.

Also, noticed that Rivet added the oxygen-acetylene torch (something that was looming in my mind as another application of the gas cylinders) - great job ! Wouldn’t want to change anything about it without Rivet’s permission. While I feel it could be made refillable from an acetylene/oxygen gas cylinder, that is merely a suggestion.

Nevertheless, this gave me another idea and some more questions - would making it refillable from a gas cylinder just need the same code as using a source of gasoline ? What about making it draw from two different containers at once, when reloading ?

How about dumping quicklime on acid streaks and sand on blood splatters to remove them ?

[Aenye]

How about dumping quicklime on acid streaks and sand on blood splatters to remove them ?

Looked at the code for mop/moppable stuff and found, what seems to be the piece used to remove spills from the map:

[spoiler] From map.cpp

void map::mop_spills(const int x, const int y) {
for (size_t i = 0; i < i_at(x, y).size(); i++) {
item *it = &(i_at(x, y)[i]);
if (it->made_of(LIQUID)) {
i_rem(x, y, i);
i–;
}
}
field &fld = field_at(x, y);
fld.removeField(fd_blood);
fld.removeField(fd_blood_veggy);
fld.removeField(fd_blood_insect);
fld.removeField(fd_blood_invertebrate);
fld.removeField(fd_bile);
fld.removeField(fd_slime);
fld.removeField(fd_sludge);
int vpart;
vehicle *veh = veh_at(x, y, vpart);
if(veh != 0) {
std::vector parts_here = veh->parts_at_relative(veh->parts[vpart].mount_dx, veh->parts[vpart].mount_dy);
for(size_t i = 0; i < parts_here.size(); i++) {
veh->parts[parts_here[i]].blood = 0;
}
}
}[/spoiler]

Utilising this code, I could make a map::neutr_acid_spills function, that would work on a field with acid spills (fd_acid, correct ?), right ? Then to exploit this piece of code (as in adapt a new instance of it) for checking whether a neutralisable field is present:

[spoiler] From map.cpp

bool map::moppable_items_at(const int x, const int y)
{
for (auto &i : i_at(x, y)) {
if (i.made_of(LIQUID)) {
return true;
}
}
field &fld = field_at(x, y);
if(fld.findField(fd_blood) != 0 || fld.findField(fd_blood_veggy) != 0 ||
fld.findField(fd_blood_insect) != 0 || fld.findField(fd_blood_invertebrate) != 0
|| fld.findField(fd_bile) != 0 || fld.findField(fd_slime) != 0 ||
fld.findField(fd_sludge) != 0) {
return true;
}
int vpart;
vehicle *veh = veh_at(x, y, vpart);
if(veh != 0) {
std::vector parts_here = veh->parts_at_relative(veh->parts[vpart].mount_dx, veh->parts[vpart].mount_dy);
for(auto &i : parts_here) {
if(veh->parts[i].blood > 0) {
return true;
}
}
}
return false;
}[/spoiler]

Would have to add a line to make a boolean of whether neutralisable items are present at a field, bysupplementing map.h, which has this:

bool moppable_items_at(const int x, const int y);

Then it’s onwards to iuse.cpp, which has:

int iuse::mop(player *p, item *it, bool)
{
int dirx, diry;
if (!choose_adjacent((“Mop where?”), dirx, diry)) {
return 0;
}
if (dirx == p->posx && diry == p->posy) {
p->add_msg_if_player((“You mop yourself up.”));
p->add_msg_if_player((“The universe implodes and reforms around you.”));
return 0;
}
if (g->m.moppable_items_at(dirx, diry)) {
g->m.mop_spills(dirx, diry);
add_msg((“You mop up the spill.”));
p->moves -= 15;
} else {
p->add_msg_if_player(m_info, _(“There’s nothing to mop there.”));
return 0;
}
return it->type->charges_to_use();
}

By adding an iuse::quicklime, which checks with a “has neutralisable items at” flag, from the previous step, this would let me bestow a “neutralise acid” action to items, right ?

Also, iuse.h has this piece:

int mop (player *, item *, bool);

This checks whether using the item consumes a charge. My quicklime is stackable (with a “count” of 50) - would it work with the code (some of it being used up) or would it need to have some “charges” that would be drained ? If possible, please advise me on this one in more detail.

Apart from giving items the proper “action on use”, this seems to be everything I need to do. Please verify my reasoning and help me get all of my newbie misconceptions straightened out.

Update:
Added the first bit necessary for the facilities- a single tile warehouse building: HERE. It would be lovely if anyone could provide me with some tips/hints on making this building actually be generated during mapgen.

[KA101]

Oops, somehow this got on the second page. Let’s fix that.

Anyway, the cement, warehouse, and road-roller are all in. Huzzah! Aenye’s tests with the roller hit on a pretty important vehicle change, but that’s probably better discussed in a separate thread.

Lookin’ kickass, Aenye. Keep 'em coming, please.

[Aenye]

Thanks ! I wouldn’t have stood a chance were it not for your, vache’s and Mschock’s help and encouragment.

Lookin’ kickass, Aenye. Keep 'em coming, please.

Went crazy today and posted two more bits I was working on lately - a few chemicals for the chem system overhaul (sorry, I forgot who was postulating that one) and the water-spewing fire engine. Both seem to work, though the water cannon damage remains an issue (on it ATM).

Does the code in the post above make sense ? Wouldn’t want to break anything more…

[KA101]

One of those times when I haven’t really had the chance to look, sorry.

[alRashid]

Two questions.
One: Would you be interested in some assistance making some of the building/map tiles?
Two: If so, is there a list of buildings similar to the list of items posted a few pages back?

I should be doing more to help with the game myself, and feel most comfortable working with building layouts. Not that I couldn’t work with code, too, but I feel I’m a bit better at design than code.

[Aenye]

Hi guys !

First of all, sorry for my long absence - hell of a story there, but let’s not go too much off-topic. In short, the airlines managed to ship me and my luggage (personal laptop included) to two different places. Got it back this friday and posting now to let you know, that I’m good and ready to get back to work (well, have to prepare X-mas for my family first).

[quote=“alRashid, post:75, topic:7085”]Two questions.
One: Would you be interested in some assistance making some of the building/map tiles?
Two: If so, is there a list of buildings similar to the list of items posted a few pages back?[/quote]

If your offer is still standing, I’d love some assistance, especially that my “Cata-scrapbook” has swollen to the size of four notebooks filled with a lot of content for the facilities (concept work virtually done).

The list of buildings for the game ? Most are in data\json\mapgen, while a few are hardcoded (not sure where exactly ). If You want the list of buildings I’ve got planned, I can send You some of my work notes, that I’ve managed to get digital (pretty much most of the tiles I’ve wanted to get in there are listed, but only short comments on what can be inside them).

[Snaaty]

I’d also appreciate it, if you could send me the stuff you want to do, so perhaps I can help implementing it.

[jokermatt999]

Add me to the list of willing assistants. I can json buildings and items fairly well (although I need to be better about triple checking my work), and I’m ok at coding. I wouldn’t want to tackle anything memory intensive or too much OOP as I’m still shaky on C++'s way of handling it, but I think I could work on the quests.

I gotta say, that is damn fine design work. You’ve put a lot into these, and your hard work and enthusiasm has gotten myself and a lot of other people excited to work on it.

Edit to not double post: I’ve started a topic for beginning work on a machine shop. Could you send me your design notes on that (or all of them, either way)? I figure that’s a good place to start doing some work on NPCs.

[Aenye]

I’d also appreciate it, if you could send me the stuff you want to do, so perhaps I can help implementing it.

Most gladly - is there anything specific You would like to work on ?

[quote=“jokermatt999, post:78, topic:7085”]Add me to the list of willing assistants. I can json buildings and items fairly well (although I need to be better about triple checking my work), and I’m ok at coding. I wouldn’t want to tackle anything memory intensive or too much OOP as I’m still shaky on C++'s way of handling it, but I think I could work on the quests.

I gotta say, that is damn fine design work. You’ve put a lot into these, and your hard work and enthusiasm has gotten myself and a lot of other people excited to work on it.

Edit to not double post: I’ve started a topic for beginning work on a machine shop. Could you send me your design notes on that (or all of them, either way)? I figure that’s a good place to start doing some work on NPCs.[/quote]

Thanks ! I’ve been trying to code a lot of this stuff in, but I’m mostly good for items / maps - the advanced stuff is taking me large amounts of time to understand. Machine shop ? I’ve done some work on a repairman’s shack for one of the specials - will digitalise the notes ASAP and send them / link them in tomorrow.

One of the things, we could try making, would be the component maps for the facilities - there’s 65+ uniques to draw up and I got a bit sidetracked by the chems and steel / aluminium rework. If You’d like, I’ll also post an Excel spreadsheet, I made to help me with drawing up the building maps (nothing special, but gets the row/column strings done without errors).

[Snaaty]

Hm, what precisely do you mean with “component maps”?

Also, I am willing to work on a couple of things, but I am severely lacking in the creative department, so I’ll have a look at anything you thought of.

[Aenye]

Well, most of the facilities, I’ve drawn up, are multi-tile “buildings”, including several types of zones (please see the grids for the facilities in my original post). Hence, while there are only several facilities, the number of map tiles associated with them is significantly larger.

Well, I am currently doing the black gunpowder ammo / guns that Kevin requested (along what was said in the machine shop thread). While I’ve got the creative stuff sorted out, there’s a number of features I would like to add, but would take days to figure out how to do it. It would be lovely if You were interested in helping me sort this out.

Is there any time that You are available via IRC, so that we could talk ?

[jokermatt999]

I’m available on irc most days after 6 pm est. If I’m not on there, send me a pm as I check the forums occasionally. I’m willing to work on json or coding, just send me the notes. If email is easier, mine’s my forum name @gmail.com

[Aenye]

I’m available on irc most days after 6 pm est. If I’m not on there, send me a pm as I check the forums occasionally. I’m willing to work on json or coding, just send me the notes. If email is easier, mine’s my forum name @gmail.com

Thanks ! I’m trying to add the black gunpowder guns ATM and thought up an addition to the ranged combat system - will send You an e-mail with the notes in a day or two (sorry for the long wait, it’s travelling time for me again, these two weeks).