PK's Rebalancing Unofficial patch

[TooDAMNMuch]

not positive this is something PK’s would need to address, but the only other time i’ve seen error messages involving irradiated potatoes it was the case, so my bad if not but is this yours?

02:59:46.366 ERROR : src/init.cpp:126 [void DynamicDataLoader::load_deferred(DynamicDataLoader::deferred_json&)] JSON contains circular dependency. Discarded 2 objects:
{
“type”: “COMESTIBLE”,
“id”: “potato_raw”,
“name”: “raw potato”,
“name_plural”: “raw potatoes”,
“copy-from”: “potato_raw”,
“freezing_point”: -1000
},{
“type”: “COMESTIBLE”,
“id”: “potato_irradiated”,
“name”: “irradiated potato”,
“name_plural”: “irradiated potatoes”,
“copy-from”: “potato_irradiated”,
“freezing_point”: -1000
},

using the latest experimentals #8912.

[dissociativity]

I’ll take a look at it a bit later, thanks for the report.
It doesn’t look like it’ll affect the game, but it’s still nice to eliminate warnings!

[TooDAMNMuch]

i also wonder if it’s from the no freeze mod now that i think about it again considering the weird -1000 freezing point value plus i still see some things freeze, i’ll have to try updating that manually soon.

[dissociativity]

it’s possible the no freeze mod has not been updated to reflect vanilla potato changes, PK rebalancing doesn’t actually touch them other than the potato’s ID in a couple of recipes previously not being the same as the newer one in vanilla, which I fixed.

[Ziko]

DEBUG : In overmap special “Triffid Grove”, no location is defined for point [0,0,-2] or the overall special.

FUNCTION : void overmap_special::check() const
FILE : src/overmap.cpp
LINE : 984

0.D-9010

[CPA]

To Creeperus
If you delete lines 294 and 295 (at irrated_potato and potato) of “pk _recipe.json” and replace them with [“potato_raw”, 1], the error will not occur.
Although it is first aid.

[Udai_Shankar]

I’d like to play with pks but I worry it’ll cause the world to break and become unstable. It’s there a remedy?

[Orange01]

Doesn’t break the game often if you download the most current version of pk when you update the game. But as always, back up your save. I always do that when I update the game. Game breaking bugs are common on experimental even without pk.

[Carrnage]

Is the consolidated cata++ and rebalancing spawnlist sub-mod up to date? if not any plans to update it in the future?

[dissociativity]

I don’t personally use the mod, but in theory you shouldn’t need it if Cata++ does spawn lists the smart way and has override turned to false like I’ve set it up to be more compatible.
I have however aimed to clean up the spawn list on PK’s so that other mod’s spawns will appear /more often/ as the current system likely decreases the likelihood.

The way I updated this a while ago should ensure it’s all compatible.

[Carrnage]

There seems to be an incompatibility with the new roofing system, when generating an evac shelter many of the the new roof structures will not be there and instead there’ll be a hole in the ceiling.

EDIT: if it was unclear i am talking about an incompatibility with standard unstable rather than cata++

[dissociativity]

fixed that, it wasn’t all shelters, it was just one particular arrangement that comes with the barn nearby

[TooDAMNMuch]

i’m really not sure, but i believe this mod may be an interactor in the problems i’ve been having with the no fungal mod, here is the github issue:

Issue: no fungal mod does not actually properly stop fungal creatures and structures from spawning

[dissociativity]

You can make a patch yourself if you like, just remove all fungal things from pk_regional_overlay.json
I’m not sure why you’d want triffids not to spawn, they’re not fungal and don’t spread like fungals do, they’re useful for unlimited vegetable matter for cooking and plant fiber from the stalks so you never run out of thread.

pk_spawnlist_triffgus.json too, you figure it out, the mod isn’t intended for playing with removing things, so you’ll probably see fungal ants or zombies even with the no fungus mod occasionally unless you purge it all.

Unfortunately you can’t expect a mod that makes the game harder to also cater to things you’ve done that make it easier.

I’d make a patch, but I have little time to maintain the mod as is.

[Orange01]

Hey dissociativity, just tried to run the game with the latest experimental and got the following message. Thank you again for maintaining this amazing mod!

DEBUG : Error: data/mods//PKs_Rebalancing-master/PKs_Rebalancing-master//pk_map_furniture.json: line 4:21: missing mandatory member “description”

[
{
“type”: “furniture”,
“id”: “f_spike”,
^
“name”: “hooked spike”,
“symbol”: “J”,
“color”: “ltgray”,

FUNCTION : bool main_menu::load_character_tab()
FILE : src/main_menu.cpp
LINE : 977

[Love_osu]

I got that same error, so I tried to fix it according to the error log.
Simply added the “description” in the json file data/mods//PKs_Rebalancing-master/PKs_Rebalancing-master//pk_map_furniture.
Then the game tells me that I need to add description to EVERY GOD DAMN file in PKs mod !

[Orange01]

Yeah i reverted back to version 9111, which is right before the mandatory descriptions. Works fine.

[dissociativity]

working on it, fairly busy but I’ve at least progressed a bit in fixing all these new changes up

[dissociativity]

Alright, seems to work fine now!

[Drakonsgear]

Hey dissociativity, tried to run the game with the latest experimental (9120) and got the following message.

DEBUG : Error: data/mods//PKs_Rebalancing-master//pk_map_terrain.json: line 4:32: missing mandatory member “description”

[
{
“type”: “terrain”,
“id”: “t_improvised_fence”,
^
“name”: “makeshift fence”,
“symbol”: “_”,
“color”: “brown”,

FUNCTION : bool main_menu::new_character_tab()
FILE : src/main_menu.cpp
LINE : 709