Mention if a food is perishable in the description

Ian_Strachan · 2013-12-21T20:30:43.000Z

desrik beat me to it, but I have one up as well: https://github.com/CleverRaven/Cataclysm-DDA/pull/5162

@infectedmochi: The problem is that now that we have fridges, the spoil time of food can change. You can’t really tell just by looking at something how quickly it will spoil, and the best-by date is just a rough approximation at best.

desrik · 2013-12-21T21:27:10.000Z

[quote=“infectedmochi, post:10, topic:4586”]I know you intended it to only tell the player whether the food will spoil or not, but personally I think it’s would be better to give an estimate.
For example: This food will not spoil --> This food will last for a long time --> This food will last for awhile --> This food will be spoiled easily. The wording could be better but you get the idea. The problem I see is it’s too “binary”. Surely the character can read the expiration day on the can/carton box or have gut feeling if the food is a fruit or juice? “This food will rot” can range from 2-3 days to weeks or months.

Not sure if the current system allow for that, just my 2 cents.[/quote]

There have been talks about implementing literal expiration dates, but the way I look at it, you would have to either express the expiration in number of days, or implement actual months and years instead of just seasons.

GrizzlyAdamz · 2013-12-21T22:41:30.000Z

Hmm, maybe have sight/smell indicators instead of [rotten].

-maybe have the color coding tied to a perk, like gourmand

On a mobile, can’t type everything up.

Coyote · 2013-12-21T22:56:37.000Z

Dang, nice. That was quick. Thanks and good job!

Ferodaktyl · 2013-12-21T23:30:16.000Z

if the spoil point is not temperature dependent and it is expressed as expiration time, it’s another metagaming feature.
A note mentioning if it is perishable or not would be more than enough imo.

DG123 · 2013-12-21T23:45:06.000Z

Canned soup rots? That sounds a bit ridiculous. Can we get that fixed?

Canned food should last for years.

GrizzlyAdamz · 2013-12-21T23:57:52.000Z

Heh, this must’ve been brought up before, but yeah;

Instead of a single counter for ‘rotten’:

2 counters, 1 for smell 1 for appearance.

Milk
Smell
<2: This smells like milk!
2<days<4: This smells rather sweet.
4<: This smells pretty awful.
Sight
<4: This looks fine!
4<days<7: There are pretty obvious curdles.
7<: This is sludge.

Each level increases chance to be poisoned by a certain amount depending on the food, (milk would be 20% for lvl3 smell, 30% for lvl2 sight & 50% for lvl3 sight).

Include yet another counter almost identical to ‘rotten’, but is instead ‘expired’ for pre-packaged foods only, (cans, bags, cartons). This is to handle foods that wouldn’t be apparently bad unless you open them up & look, and would be part of the item name.

Tons & tons of work, but would be a pretty intuitive & more involved system.

Rivet · 2013-12-22T00:39:23.000Z

Coyote:

Okay, folks, I live in America and honestly have never run into some of the food pickups I see.

I’m still wondering how we got salmaic powder in-game. I thought the Finns were the only ones crazy enough to eat that stuff. It’s definitely not a North American thing.

If it were Pixie Stix or something similar it wouldn’t stick out, but here in the USA we tend to think of ammonium chloride as fertilizer, not food.

DG123 · 2013-12-22T00:46:46.000Z

… So that’s… liquorice powder with ammonium chloride? Yuck.

Rivet · 2013-12-22T00:55:10.000Z

DG123:

… So that’s… liquorice powder with ammonium chloride? Yuck.

Yeah. I can’t figure out how it’s even considered food in the first place.

Seems like a waste of good licorice.

The other foods are pretty normal stuff for the Northeastern USA though.

Dominae · 2013-12-22T01:10:34.000Z

Rivet:

[quote=“DG123, post:19, topic:4586”]… So that’s… liquorice powder with ammonium chloride? Yuck.

Yeah. I can’t figure out how it’s even considered food in the first place.

Seems like a waste of good licorice.

The other foods are pretty normal stuff for the Northeastern USA though.[/quote]

There was a “food expansion thread” not too long ago. A buncha’ stuff got rolled into the merger and made it into the game I guess. The salmaic powder was one of them … a couple of us pointed out the “Americans won’t get what that is, nor understand why it is in the Northeast US” thing but I think it just went through as-is.

I think theres like, some weird Pork-Sticks thing in game too that felt “off” because it wasn’t found in the US.

Changing salmaic powder to pixie stix like you said, or even just “sugar/powdered candy” or whatever … and like, the Pork Sticks to Pork Rinds or Slim-Jims may smooth them?

Not to beat a dead horse but it kinda’ ties into the “too many cooks” aspect of things though, stuff slips into the main game that might not fit and then it becomes a game of finding it again and letting the right people know it might need fixin’. Easier to halt stuff at the gate and give it a once-over then try and find things once they’re loose in the zoo.

desrik · 2013-12-22T03:32:19.000Z

[quote=“DG123, post:16, topic:4586”]Canned soup rots? That sounds a bit ridiculous. Can we get that fixed?

Canned food should last for years.[/quote]

If the food is in a tin can it is automatically set to not rot. So it shouldn’t even have a chance to happen. Anyone have pics?

Inadequate · 2013-12-22T03:43:47.000Z

Don’t think I have pics offhand, but canned soup definitely rots, at about the same rate as regular soup. Always assumed it was intended, though.

GrizzlyAdamz · 2013-12-22T03:46:10.000Z

Inadequate:

Don’t think I have pics offhand, but canned soup definitely rots, at about the same rate as regular soup. Always assumed it was intended, though.

this

desrik · 2013-12-22T04:30:31.000Z

That’s weird. I see in the json that it does have a “spoils_in” of 120, but these lines in the code should change that:

in item::in_its_container(std::map<std::string, itype*> *itypes)

if (dynamic_cast<it_comest*>(type)->container == "can_food") food->spoils = 0;

Perhaps I am wrong about the lines and their actual function?

Rivet · 2013-12-22T04:51:29.000Z

Perhaps that’s how it’s supposed to function, but in practice (admittedly I haven’t tested this recently so it may have changed at some point) food inside cans rots just as fast as food that’s not contained in any fashion.

But again, I may be wrong. I haven’t tested this in quite a while and perhaps it’s finally been fixed.

Inadequate · 2013-12-22T05:09:43.000Z

Most food in cans keeps indefinitely, only some things rot, like soup. Maybe something in the soup code overrides it?

Ian_Strachan · 2013-12-22T06:09:38.000Z

Stuff in cans rots because containers have no special functions relating to food beyond being containers.

The birthday/spoil time is stored on the food itself, just in case you were to decant it into a plastic bottle or something. Or if it were some sealed non-liquid (like perhaps a can of corn) and you simply removed it.

To fix it you’d basically need to have it always assume canned stuff is non-rotten, and if something gets de-canned, to have it set the birthday to the current turn (and adjust the spoil date correctly).

Zaweri_Runewright · 2013-12-22T10:39:45.000Z

Rivet:

I’m still wondering how we got salmaic powder in-game. I thought the Finns were the only ones crazy enough to eat that stuff.

I suggested that stuff because I saw that stuff for sale last time I visited America. And if you have really never tasted salmiac, I suggest you should. It’s actually very good.

Dominae · 2013-12-22T18:35:30.000Z

Zaweri Runewright:

[quote=“Rivet, post:18, topic:4586”]I’m still wondering how we got salmaic powder in-game. I thought the Finns were the only ones crazy enough to eat that stuff.

I suggested that stuff because I saw that stuff for sale last time I visited America. And if you have really never tasted salmiac, I suggest you should. It’s actually very good.[/quote]

Where did you see it for sale, though? lol … a big common chain store that is everywhere, or a specialty market/market that deals in imported foods? … oh, and where in America were you, btw? If for instance, New York City, it definitely isn’t a good baseline to use for what New England would have on hand in a regular old town for instance.

Tweaking things to make, like, small versions of the grocery store that spawn foods from out-of-region to simulate small specialty food stores would make sense though if people wanted to leave a bunch of non-standard stuff in. It wouldn’t break immersion much to raid a corner store and see all kinds of “weird by American standards” food that I have to Google to know what it is, if its spawn location made sense in the world.