Mansion Upgrade Project

[egomassive]

I have been poring over the source, the documentation, the github, the forum… I cannot figure out why maps do or don’t rotate. Overmap specials marked [glow=red,2,300]“rotate” : false[/glow] still rotate! But mine only rotate if I mark them true, but while the whole mansion rotates the individual sections do not. If I add [glow=red,2,300]“rotate” : true[/glow] to any of my overmap terrains they fail the validation check while other structures have it and pass. I’m so frusterated. This is the specific error I get if anyone cares to shed some light on it:
Debug : Invalid terrain “mansion_c” in overmap special “Mansion_Road”.
Function : void overmap_special::check() const
File : src/overmap.cpp
Line : 986

Sidenote: I discovered that the 2 floor motel is rooved with shrubs. I think I’ll get into the gethub side of things by submitting a fix for it.

[acidia]

This is going to be a bit new but what you need to do to get a multi-tile building to rotate as a single unit is to add “_north” to the end of all of the entries in overmap_specials.json, but no where else. This tells the game that the existing orientation of the map is north… I haven’t tried it but something like the below may work… but I’ve never used anything but _north to designate orientation.

{ "type" : "overmap_special", "id" : "mansion_new", "overmaps" : [ { "point":[0,0,0], "overmap": "mansion_new_corner_north"}, { "point":[1,0,0], "overmap": "mansion_new_side_north"}, { "point":[2,0,0], "overmap": "mansion_new_corner_east"}, { "point":[0,1,0], "overmap": "mansion_new_side_west"}, { "point":[1,1,0], "overmap": "mansion_new_center_north"}, { "point":[2,1,0], "overmap": "mansion_new_side_east"}, { "point":[0,2,0], "overmap": "mansion_new_corner_south"}, { "point":[1,2,0], "overmap": "mansion_new_entrance_north", "connect":"road"}, { "point":[2,2,0], "overmap": "mansion_new__corner_west"} ], "locations" : [ "wilderness" ], "city_distance" : [3, 5], "city_sizes" : [1, 12], "occurrences" : [75, 100], "rotate" : true }

[egomassive]

Wow, I was so close! I saw this in the source code and went searching for examples with _east and then _south and came up empty. sigh Thank you so much acidia!

[edit]Update: Rotation is working great now (as long as the mansion doesn’t rotate as a whole.) Each corner and t-section can rotate to the correct orientation. That was an extremely fast turnaround from concept to implementation. Now, I need to tie the z-levels together and finish adding in all the item and monsters.[/edit]

[StopSignal]

Man, that’s really good to hear. Keep it up! Can’t wait to test it out!

[egomassive]

I’ve added items to all 54 maps. It took 1341 lines of json just to declare my item groups, and my mansion blueprint file is now at 4387 lines. wipes brow with back of hand

To Do List:
[ul][li]add monsters[/li]
[li]figure out some items that aren’t working correctly[/li]
[li]z-level linking and rotation issues dealt with[/li]
[li]test, balance, repeat.[/li][/ul]

I’ll push it to my github branch after I’ve knocked out a few of these points. I’ll be wanting feedback on balance, and you’ll probably be wanting to check it out.

[SpadeDraco]

[quote=“egomassive, post:20, topic:12888”]I’ve added items to all 54 maps. It took 1341 lines of json just to declare my item groups, and my mansion blueprint file is now at 4387 lines. wipes brow with back of hand

To Do List:
[ul][li]add monsters[/li]
[li]figure out some items that aren’t working correctly[/li]
[li]z-level linking and rotation issues dealt with[/li]
[li]test, balance, repeat.[/li][/ul]

I’ll push it to my github branch after I’ve knocked out a few of these points. I’ll be wanting feedback on balance, and you’ll probably be wanting to check it out.[/quote]

Awesome!

[egomassive]

I have a dilemma. One of the center maps of my mansions is an indoor basketball court. The problem is pavement, yellow pavement, and the backboards are all outdoor terrain. I could use the waxed floor and create new indoor terrain for the other 2 types I need, or I could replace the gym with something else. On one hand, I hesitate to add anything that will require updating every tileset. On the other hand, I like my gym and its little sauna. Feedback/ideas welcome.

[123nick]

[quote=“egomassive, post:22, topic:12888”]I have a dilemma. One of the center maps of my mansions is an indoor basketball court. The problem is pavement, yellow pavement, and the backboards are all outdoor terrain. I could use the waxed floor and create new indoor terrain for the other 2 types I need, or I could replace the gym with something else. On one hand, I hesitate to add anything that will require updating every tileset. On the other hand, I like my gym and its little sauna. Feedback/ideas welcome.

[/quote]

maybe you could look at what the dojo or gym does, and use that as a flooring instead? pavement indoors is a bit odd, maybe wood flooring would be better? like the ones seen in the dojo ?? i think.

[egomassive]

maybe you could look at what the dojo or gym does, and use that as a flooring instead? pavement indoors is a bit odd, maybe wood flooring would be better? like the ones seen in the dojo ?? i think.

No luck there. The gyms all have regular floors. The boxing gym has a canvas boxing ring and the dojo has tatami mats. I never realized those floor coverings were both considered furniture. (I heard it rains inside the tents at the FEMA camps. If that’s true then fixing it can be as simple as placing dirt floors beneath the canvas floors.) It was worth a look though, good thinking 123nick.
[hr]
Edit: Now that codemime’s Overmap Overhaul (Step 4) has been merged, rotation problems are history. I’m going with new terrain based on waxed floors for the basketball court. Once I get monsters to spawn I think I’ll push it to my github branch for previewing. There will still be z-level linking issues, so it wont be ready to merge for some time. (By “z-level linking” I mean I need to get mapgen to pick a piece of the mansion at random, and have that piece be able to specify it’s z-level neighbors. It’s necessary for stairwells and balconies to match up.)

[egomassive]

I’ve created a test pack for this project.

Download CDDAMansionTestPack.zip 33KB

It’s a little different from my ultimate goal. This will only produce 4 variations of the mansion to ensure z-levels are stacked properly. Please try it out and then criticize it without mercy give me helpful feedback here.

[Zhilkin]

Not bad.

[AdonaiJr]

Hey! I’ll download and test this later today. Thanks for your work!

[egomassive]

So, feedback is trickling in slowly. I haven’t run into any problems in my own testing. I’m likely to throw this up for a pull request soon. It’s not the final form I’m going for, but it’s still better than the old mansions as is. The chief reason is so this will get better exposure and people will make threads like, “mansions are effed up!” which I can read for angry feedback.

In the meantime I’ve been reading through the source, figuring out all the pieces I need to link z-levels. Progress is slow. Also, I’ve been working on the MShock32XottoPlus graphics.

[Nibelung44]

Ah sorry, I’ll definitively test your mansion project for my next game! Or … can I add the mod in my current game and have the new areas generated with your mansions? Yes I believe I can!! But I will hit again the ‘can’t place more than 72 specials’ issue problem that I never really understood in a game with an infinite map…

As for you working on the MShock32XottoPlus graphic pack, that is awesome! Please keep me updated, this the one I’m using and it is simply the best around for me. I’m not much into the Chestholes style graphics (aka big baby heads)

[egomassive]

Ah sorry, I’ll definitively test your mansion project for my next game! Or … can I add the mod in my current game and have the new areas generated with your mansions? Yes I believe I can!! But I will hit again the ‘can’t place more than 72 specials’ issue problem that I never really understood in a game with an infinite map…

If you add this to your current game you should keep getting the old mansions until you enter a new region. There’s no obvious way to tell if you’re in a new region or not. Your world options also need the Tall Buildings mod enabled. Regions are something like 30 square kilometers, and the 72 special structure limit applies to each region. So, if you’ve started in one region and entered a second, then there will be 144 special structures in your world.

[Nibelung44]

The 72 can be different you mean?

[egomassive]

[quote=“Nibelung44, post:31, topic:12888”]The 72 can be different you mean?[/quote]The structures you get in a region can be different. Each region can have another 72 structures.

[Greiger]

Probably quite late but I’ve pretty thoroughly explored one of these new mansions and just wanted to give you my 2 cents.

First off: It’s awesome I would love these to be the new mansions. Especially if we had some way to randomize the tiles to a point so seeing the first few rooms won’t eventually give you a full mental map of the rest of the mansion.

Second: A bug/inconvenience you may not be able to do anything about. On the 2nd floors some of these balconies can’t really be determined when you don’t know they are there. I actually accidentally dropped down a floor above the central basketball court because the ascii for a floor in the dark is identical to the tile for open space in the dark. After coming back there the railing makes it obvious in hindsight, but it might throw off some new folks.

And third, more of a suggestion: So far I’ve only located one mansion out in the woods, but if you haven’t placed some in others already, a garage might be a good addition to some mansions. They are supposedly the toys of the rich by the time of the cataclysm after all.

Awesome work mate

[egomassive]

Thanks for the input Greiger.

Randomized mansions are the goal, but I’ve got to figure out how to get the matching upstairs on a randomly chosen ground floor. The relevant parts of the hard code are a difficult read.

I’ve no idea what could be done about open air and un-lit flooring appearing the same in ASCII. I play with tiles so it’s good to hear about these sorts of issues.

I’ve considered making a garage piece. Because of the way mansions connect to roads, it would need to be a front-center piece of a near-to-town mansion. I never had a clear image of how to make that look appropriate for a rich estate, so I’m not going to worry about that until I get everything else working correctly.

[Nibelung44]

Are your mansions supersede or additional to the vanilla ones? Because this can lead to ‘too many mansions’