# Mansion Spawn Bug (Build 7179)

**URL:** <https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073>\
**Category:** The Garage\
**Created:** [March 6, 2018, 3:25am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073 "2018-03-06T03:25:02Z")\
**Posts on this page:** 15\
**Page:** 1

<div class="post-metadata">

**Author:** ![EnDSchultz](https://avatars.discourse-cdn.com/v4/letter/e/e95f7d/32.png) [@EnDSchultz](https://discourse.cataclysmdda.org/u/EnDSchultz)\
**Post date:** [March 6, 2018, 3:25am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/1 "2018-03-06T03:25:03Z")

</div>

Hello, something’s up with the mapgen as it pertains to the new mansion layouts. Looks like the game is spawning tiles of the mansion as “house” on the map, resulting in a disjointed and incomplete mansion. The up/down stairs lead to nowhere and hurt you if you try to climb them. Can anyone else confirm/reproduce, or is my install corrupted somehow? Build 7179. Edit: screencapped the wrong mods.json. I think it may be an incompatibility with the More Buildings submod.

 ![](https://us1.discourse-cdn.com/flex016/uploads/cataclysmdda/original/2X/a/ab7bfa65cca55d4e086b19c34430a464328d0a96.png) ![](https://us1.discourse-cdn.com/flex016/uploads/cataclysmdda/original/2X/c/c11b772162c4378550dd3e57e3085dc4892a3cf7.png) ![](https://us1.discourse-cdn.com/flex016/uploads/cataclysmdda/original/2X/b/b70de47a0d6fef3d746b92d03c22c25400c6d032.png)

---

<div class="post-metadata">

**Author:** ![mentos046](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/mentos046/32/11932_2.png) [@mentos046](https://discourse.cataclysmdda.org/u/mentos046)\
**Post date:** [March 6, 2018, 12:24pm UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/2 "2018-03-06T12:24:20Z")

</div>

I’ve seen the one in the top right corner, with the square consisting of three beds and a bookshelf around a few times. It looks like it shows up four times here, so it must be pretty common. I had no idea that it was related to the mansions, though.

Sorry I can’t be of any help regarding what might cause it. More Buildings is among the mods I usually use, but the list of mods I usually use is also kind of large.

---

<div class="post-metadata">

**Author:** ![hobophobe](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/hobophobe/32/1785_2.png) [@hobophobe](https://discourse.cataclysmdda.org/u/hobophobe)\
**Post date:** [March 7, 2018, 3:13am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/3 "2018-03-07T03:13:58Z")

</div>

I’m seeing the same bug, perhaps it has something to do with changes to mansions going on recently?

---

<div class="post-metadata">

**Author:** ![Zhilkin](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/zhilkin/32/3749_2.png) [@Zhilkin](https://discourse.cataclysmdda.org/u/Zhilkin)\
**Post date:** [March 7, 2018, 5:32am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/4 "2018-03-07T05:32:22Z")

</div>

Most certainly. I’m looking into this.

---

<div class="post-metadata">

**Author:** ![Zhilkin](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/zhilkin/32/3749_2.png) [@Zhilkin](https://discourse.cataclysmdda.org/u/Zhilkin)\
**Post date:** [March 8, 2018, 9:26am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/5 "2018-03-08T09:26:20Z")

</div>

> [@EnDSchultz](#):
>
> Edit: screencapped the wrong mods.json. I think it may be an incompatibility with the More Buildings submod.

You do not have More Buildings mod on the screenshot (its ident is `more_buildings`).

---

<div class="post-metadata">

**Author:** ![Zhilkin](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/zhilkin/32/3749_2.png) [@Zhilkin](https://discourse.cataclysmdda.org/u/Zhilkin)\
**Post date:** [March 8, 2018, 10:28am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/6 "2018-03-08T10:28:19Z")

</div>

Would someone please provide savegame with affected mansions? I tried to reproduce it, but can’t yet.

---

<div class="post-metadata">

**Author:** ![hobophobe](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/hobophobe/32/1785_2.png) [@hobophobe](https://discourse.cataclysmdda.org/u/hobophobe)\
**Post date:** [March 9, 2018, 1:07am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/7 "2018-03-09T01:07:45Z")

</div>

Here ya are; [http://www.filedropper.com/manualbackup](http://www.filedropper.com/manualbackup)

---

<div class="post-metadata">

**Author:** ![hobophobe](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/hobophobe/32/1785_2.png) [@hobophobe](https://discourse.cataclysmdda.org/u/hobophobe)\
**Post date:** [March 9, 2018, 1:27am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/8 "2018-03-09T01:27:22Z")

</div>

By the way, I updated my game and created a new world, mansions are working again. And they look great too!

---

<div class="post-metadata">

**Author:** ![EnDSchultz](https://avatars.discourse-cdn.com/v4/letter/e/e95f7d/32.png) [@EnDSchultz](https://discourse.cataclysmdda.org/u/EnDSchultz)\
**Post date:** [March 9, 2018, 7:22am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/9 "2018-03-09T07:22:45Z")

</div>

Yeah, I updated as well and subsequent mansions I’ve come across appear normal. Must have been some transient change with one of the builds… seems resolved now. Sorry for the wild goose chase!

---

<div class="post-metadata">

**Author:** ![Zhilkin](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/zhilkin/32/3749_2.png) [@Zhilkin](https://discourse.cataclysmdda.org/u/Zhilkin)\
**Post date:** [March 9, 2018, 8:03am UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/10 "2018-03-09T08:03:13Z")

</div>

> [@EnDSchultz](#):
>
> Yeah, I updated as well and subsequent mansions I’ve come across appear normal. Must have been some transient change with one of the builds… seems resolved now. Sorry for the wild goose chase!

Do you remember by chance which version/build you had before the update?

I suspect this bug:

> <https://github.com/CleverRaven/Cataclysm-DDA/issues/22358>
>
> Game version:
> 0.C-24831-g6a32f4f
> Operating system:
> Win10 64
> Tiles or curses:…
> Tiles (MShock32Modded)
> Mods active:
> Vehicle Addtions Pack, Filthy Clothing, Prevent Zombie Revivication, Simplified Nutrition
> \### Expected behavior
> Map gen was far more natural 1-2 weeks ago and forever before
> \### Actual behavior
> As of week or so ago and continuing in latest build, buildings are unnaturally lumped together at times and/or in the middle of roads, leading to some very odd road networks in cities compared to the past.
> \### Steps to reproduce the behavior
> Create world, load in, view map. Suicide and repeat a few times to see constency in oddness.
> 
> Examples:
> !\[image\](https://user-images.githubusercontent.com/33404851/32420761-c746677e-c24c-11e7-953d-2a9f2f01a5ea.png)

Which was fixed in:

> <https://github.com/CleverRaven/Cataclysm-DDA/pull/22723>
>
> Closes #22358.
> Closes #21497.
> 
> \## Overview
> 
> @kevingranade was right in his …suspicions regarding the first issue. The @Coolthulhu's idea of unifying town buildings with overmap specials is really great, the implementation, however, has a minor bug which caused #22358. \`find\_max\_size()\` performs checks after it increments its counters, so the result value isn't always correct. #21497 is fixed by allowing buildings to override marshlands. Also, buildings can't spawn by themselves like other overmap specials do. This was definitely possible, but I didn't find a corresponding issue.
> 
> \## Implementation details
> 
> \- Town buildings are now yet more like the real overmap specials. They both use the same check (\`can\_place\_special()\`) which obsoletes \`building\_size\` along with the functions that operate on it. So they all were removed (\`find\_max\_size()\` was among them).
> \- Added \`locations\` and a check for max occurrences to the fake overmap specials (zero \`max\_occurrences\` prevents their spawn "in the wild").
> \- Introduced \`overmap::get\_default\_terrain()\` which allows minor code deduplication and localization of a couple hard-coded terrain ids.
> \- Tiny code improvements.

---

<div class="post-metadata">

**Author:** ![EnDSchultz](https://avatars.discourse-cdn.com/v4/letter/e/e95f7d/32.png) [@EnDSchultz](https://discourse.cataclysmdda.org/u/EnDSchultz)\
**Post date:** [March 9, 2018, 11:54pm UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/11 "2018-03-09T23:54:22Z")

</div>

Afraid not. Best I have is that my backup of the previous version (which Im fairly certain is the version the bug occurred on) was downloaded on 2/28.

---

<div class="post-metadata">

**Author:** ![NuG](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/nug/32/7057_2.png) [@NuG](https://discourse.cataclysmdda.org/u/NuG)\
**Post date:** [March 10, 2018, 3:34pm UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/12 "2018-03-10T15:34:13Z")

</div>

I didn’t realize this was a bug. I also have found a mansion like this. Also, DO NOT try to go up the stairs… OUCH LOL.

edit: I updated from 7183 to 7192 and found the mansion in 7192 yesterday, but it was just outside the “fog of war” so am not sure if it was newly generated or how that exactly works. It’s in my latest video if you want to see for yourself (not trying to promote in this thread, just thought it might be useful info).

---

<div class="post-metadata">

**Author:** ![Zhilkin](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/zhilkin/32/3749_2.png) [@Zhilkin](https://discourse.cataclysmdda.org/u/Zhilkin)\
**Post date:** [March 10, 2018, 5:24pm UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/13 "2018-03-10T17:24:52Z")

</div>

Link please? Sorry for me being lazy. 🙂

---

<div class="post-metadata">

**Author:** ![EnDSchultz](https://avatars.discourse-cdn.com/v4/letter/e/e95f7d/32.png) [@EnDSchultz](https://discourse.cataclysmdda.org/u/EnDSchultz)\
**Post date:** [March 10, 2018, 6:45pm UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/14 "2018-03-10T18:45:12Z")

</div>

So it might indeed be related to this “unifying of town and overmap specials” referenced in that Github bug… I stumbled upon a house on the outskirts of a city that was using a chunk from the mansion set, complete with the unclimbable stairs.

So, somewhere in the code there is apparently a mixup that is confusing house and mansion templates. I’ll get back to you when I’ve got more.

---

<div class="post-metadata">

**Author:** ![NuG](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/nug/32/7057_2.png) [@NuG](https://discourse.cataclysmdda.org/u/NuG)\
**Post date:** [March 11, 2018, 10:02pm UTC](https://discourse.cataclysmdda.org/t/mansion-spawn-bug-build-7179/15073/15 "2018-03-11T22:02:46Z")

</div>

> [@Zhilkin](#):
>
> Link please? Sorry for me being lazy.

I actually just realized the previous episode doesn’t have the bugged mansion. I recorded it, but still have to edit the one with the bugged mansion, which will be coming out on Wednesday. I recorded this previous Saturday’s episode and Wednesday’s both on this past Friday, which is why I got confused.

[Here is a link to the playlist](https://www.youtube.com/watch?v=3ssXCtbL8cA&list=PLyJyBpGxoRnLhpl028AGAr7qwCg5f6x0x), my audio quality has gotten better since the first episode.