# Mail carrier profession and items

**URL:** <https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449>\
**Category:** The Lab\
**Created:** [December 10, 2013, 3:43am UTC](https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449 "2013-12-10T03:43:20Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![Vronkio](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/vronkio/32/55_2.png) [@Vronkio](https://discourse.cataclysmdda.org/u/Vronkio)\
**Post date:** [December 10, 2013, 3:43am UTC](https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449/1 "2013-12-10T03:43:20Z")

</div>

My first try at contributing something.

> <https://github.com/Vronkio/Cataclysm-DDA/commit/c08ba7217a57e72a9dd7f9f3cfc9997963fb9fd2>

> <https://github.com/Vronkio/Cataclysm-DDA/commit/f7930454525618d6fcf3e261edaa7f6f819a1074>

From what I see I have to make a pull request besides the commit, how do I do that?

---

<div class="post-metadata">

**Author:** ![Vronkio](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/vronkio/32/55_2.png) [@Vronkio](https://discourse.cataclysmdda.org/u/Vronkio)\
**Post date:** [December 10, 2013, 3:48am UTC](https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449/2 "2013-12-10T03:48:20Z")

</div>

Nevermind, got it!

> <https://github.com/CleverRaven/Cataclysm-DDA/pull/4979>

Scratch that. The pull request page says it failed. What did I do wrong? I can’t figure it out by the failure details report.

---

<div class="post-metadata">

**Author:** ![Vronkio](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/vronkio/32/55_2.png) [@Vronkio](https://discourse.cataclysmdda.org/u/Vronkio)\
**Post date:** [December 10, 2013, 4:47pm UTC](https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449/3 "2013-12-10T16:47:17Z")

</div>

It seems to be something on the professions file specifically but I can’t figure out what. Was the separation from the previous profession badly done? The change seems to be encompassing the }, from the previous one.

And I’m not sure how to go about adding them to the itemgroups file. Should I add them to existing categories or make a new category, like cops? Maybe one could later on implement a postal office and have postal office cloth spawn on zombies and in said offices. Some tips?

---

<div class="post-metadata">

**Author:** ![kevin.granade](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/kevin.granade/32/1316_2.png) [@kevin.granade](https://discourse.cataclysmdda.org/u/kevin.granade)\
**Post date:** [December 11, 2013, 4:14pm UTC](https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449/4 "2013-12-11T16:14:07Z")

</div>

I went ahead and merged it. I think the error it reported was a merge issue, the json files frequently have this problem. The best way to avoid it is to pick a random or category-based spot to stick your new content instead of at the end (for example put the mail carrier after the cop). This makes it less likely that two different people edit the same spot in the file, which is what causes conflicts.

In addition to that, there were some commas missing in the profession definition, but I just fixed that up in the merge.

It’s ok to have items only spawn with a profession, but if you think of somewhere else that it would make sense for those items to appear, by all means add them.

Thanks for the contribution 🙂

---

<div class="post-metadata">

**Author:** ![Vronkio](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/vronkio/32/55_2.png) [@Vronkio](https://discourse.cataclysmdda.org/u/Vronkio)\
**Post date:** [December 12, 2013, 12:57am UTC](https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449/5 "2013-12-12T00:57:10Z")

</div>

I will give a look over the itemgroups later to see where it would make sense.

And you’re very welcome, happy to be able to give something back to the community.

---

<div class="post-metadata">

**Author:** ![Vronkio](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/vronkio/32/55_2.png) [@Vronkio](https://discourse.cataclysmdda.org/u/Vronkio)\
**Post date:** [December 12, 2013, 2:21am UTC](https://discourse.cataclysmdda.org/t/mail-carrier-profession-and-items/4449/6 "2013-12-12T02:21:54Z")

</div>

> <https://github.com/CleverRaven/Cataclysm-DDA/pull/5005>

Would these work to make these appear together on zombies so as to simulate zombie mail carriers?