Invalid Colour Name

Aggregate · 2018-01-04T08:09:49.287Z

I’m attempting to apply colour to a monster but getting the following error:

I literally just copy-pasted it from COLOR.md, as far as I know it should work. I’ve also had problems with, I think, all of the colour combinations I’ve tried. Assistance would be appreciated.

Also, is there a way to stop COLOR.md from being turned into a link?

Not quite related, but is there a way to give a monster a reusable flashbang, akin to the Flashbang Generator CBM?

NuG · 2018-01-04T17:18:01.301Z

Colors were changed or something recently, I think light was changed to lt and dark to dk(better info in links below).
Error with some Mods is where I just got my info and/or
https://github.com/CleverRaven/Cataclysm-DDA/pull/22535 might be relevant .

Aggregate · 2018-01-04T22:02:14.080Z

They were actually changed from lt_ to light_ etc, and I’m fairly sure that the “COLOR.md” file was added around that time.

Zhilkin · 2018-01-04T22:54:18.942Z

invalid color name error will be thrown when color_from_string function returns c_unset.

Aggregate · 2018-01-04T23:03:23.311Z

Right, nice to know why the error’s thrown (even if I’m not code savvy enough to actually understand it), but it should be working. There are even existing working examples; the zombie hulk and dancer use “color”: “white_magenta”,.

Zhilkin · 2018-01-04T23:05:11.840Z

I agree, but it seems error is thrown for some valid combinations of foreground and background color.

Zhilkin · 2018-01-04T23:36:46.381Z

It seems all possible color combinations are hardcoded.

You can see them in Settings - Colors menu or in color_manager::load_default() function:

github.com

CleverRaven/Cataclysm-DDA/blob/master/src/color.cpp#L207


if( bg_name.empty() ) {  //c_black -> h_black
    hi_name = "h_" + name.substr( 2, name.length() - 2 );
} else {
    hi_name = name + "_" + bg_name;
}


color_id id = name_to_id( hi_name );
return color_array[id].color;
}


void color_manager::load_default()
{
static const auto color_pair = []( const int n ) {
    return nc_color::from_color_pair_index( n );
};
//        Color         Name      Color Pair      Invert
add_color( def_c_black, "c_black", color_pair( 30 ), def_i_black );
add_color( def_c_white, "c_white", color_pair( 1 ).bold(), def_i_white );
add_color( def_c_light_gray, "c_light_gray", color_pair( 1 ), def_i_light_gray );
add_color( def_c_dark_gray, "c_dark_gray", color_pair( 30 ).bold(), def_i_dark_gray );
add_color( def_c_red, "c_red", color_pair( 2 ), def_i_red );

Aggregate · 2018-01-05T01:10:31.286Z

That’s unfortunate. Still, thank you for the assistance.