How to properly run json-format through cygwin?

[John_Candlebury]

I got the program compiled and everything. Its not an install problem.

It seems however that the formatter changes every file from using “LF” to “CR LF” line endings. As a result the formatter is mostly useless as it changes and is stopped by every json file in the directory.

Wanted to ask if someone has gotten the formatter to run properly in cygwin, what setting or anything else should I change?

[mlangsdorf]

Just a hack suggestion, but have you tried running dos2unix or unix2dos on the files before or after the formatter to get the files in the right format?

Also, what editor are you using? I know I just wrote the blazemod vehicle part descriptions using vim and notepad++ on Windows, screwed up the commit sequence, pushed the mangled commits up to GitHub, pulled them back down to a Linux box, rebased them the correct way with git gui, and submitted them without any CRLF issues.

Now, I strongly suspect I’ve configured my notepad++ and vim on Windows to use Unix style LFs and forgot about it, but my second step would be to check if you can get your editor to do the right thing.

[John_Candlebury]

Yeah I just tried it, dos2unix works at reverting the change, thanks.

Im using notepad++ for editing. I think this shouldnt really matter, git should automatically change the CRLF to LF when commiting, thats what it says in .gitattributes at least.

Remaining problem is that the json formatter errors and stops everytime it chages a file (in this case it changes everyfile) so I have to run it a bazillion times before it actually reaches and formats the files that interest me. Any way around this?

[Zhilkin]

You need to update formatter code, like I did in https://github.com/CleverRaven/Cataclysm-DDA/commit/892f56fcf4581881363a4d13241c67edea539ab6, but with some MinGW flag.

[John_Candlebury]

Thanks Zhilkin!

Can I run only the formatter using MSYS, without needing to compile the whole game?

If yes I’ll rather just change to MSYS2

Edit: Nevermind I gave your PR a poper read, the answer is yes

[Zhilkin]

Sure. You can use MSYS for running format only, but I suggest using MSYS for compilation too using my recent instruction - https://github.com/CleverRaven/Cataclysm-DDA/blob/master/COMPILING-MSYS.md.

I am interested in updating MinGW instruction too, but didn’t take time to look into it yet. I guess it won’t be different much from MSYS.