Game literally unplayable due to this new NPC on fire crash

vassock · 2018-05-26T08:30:28.802Z

Well I can certainly test it since my current save seems to have it happen 100% of the time. How do I apply this fix to an existing installation?

budg3 · 2018-05-26T08:38:52.037Z

You will have to compile it yourself with the changes made to player.cpp and then copy your saves/mods etc over to the new custom build.

vassock · 2018-05-26T08:42:21.676Z

Is there a step-by-step process of what to download and how to do it?
Do I just download Cataclysm-DDA-0.6.zip, edit the parts that fix tells me to edit, and compile?

budg3 · 2018-05-26T08:49:36.790Z

If you’re on Windows I can share my compiling setup since the instructions in COMPILING.md didn’t work for me, or if you want to I can just give you the custom build I use, but it also has some other PRs in it (rebalanced fire and neutral traits) + a small personal edit that disables the kickstarter backer names.

BorkBorkGoesTheCode · 2018-05-26T08:56:12.617Z

@vassock Don’t download 0.6. Download a .zip from https://github.com/RadHazard/Cataclysm-DDA/tree/fix-clothes-dropping using the green “clone or download” button.

vassock · 2018-05-26T09:15:07.959Z

I got the file using the green button, extracted it, and made the two changes listed in the fix.

I also installed Git.

How do I compile it?

budg3 · 2018-05-26T09:41:54.221Z

Assuming you’re on Windows and already got git-bash (in case you don’t: git for windows) I downloaded MinGW-w64 - for 32 and 64 bit Windows, pkg-config-lite and then got the four SDL libraries:

https://www.libsdl.org/release/SDL2-devel-2.0.8-mingw.tar.gz
https://www.libsdl.org/projects/SDL_ttf/release/SDL2_ttf-devel-2.0.14-mingw.tar.gz
https://www.libsdl.org/projects/SDL_image/release/SDL2_image-devel-2.0.3-mingw.tar.gz
https://www.libsdl.org/projects/SDL_mixer/release/SDL2_mixer-devel-2.0.2-mingw.tar.gz

Finally you will need this edited makefile.

Extract MinGW to C:\ or wherever you want.
Extract the contents (bin, include, lib, share folders etc) of the various SDL libraries in the i686-w64-mingw32 (32bit) or x86_64-w64-mingw32 (64bit) folders to the MinGW folder.
Extract the bin and share folder from pkg-config-lite to the MinGW folder.
Extract the makefile to the CDDA source folder.
Open git bash in the CDDA source folder (right click on folder - Git Bash here).
Type export PATH=$PATH:/c/mingw32/bin where /c/mingw32/bin is where you extracted MinGW.
Type mingw32-make -j4 NATIVE=win32 RELEASE=1 DYNAMIC_LINKING=1 TILES=1 SOUND=1 LOCALIZE=0 BACKTRACE=0 and wait for up to an hour depending on your system. You can change win32 to win64 if you’re on 64bit.
When it’s done you should have an .exe in your CDDA source folder.
You will now have to paste all the SDL .DLL files (from i686-w64-mingw32\bin\ or x86_64-w64-mingw32\bin\) into your CDDA source folder. Note that SDL above 2.0.5 causes weird black lines for all the mshock based tilesets. If you want to use those tilesets, you will have to get SDL 2.0.5, SDL_mixer 2.0.1 and SDL_image 2.0.1 as well and use their .DLLs instead.

Note that this build will not include LUA or localization support. If you want those features you will have to get the required libraries for those.

BorkBorkGoesTheCode · 2018-05-26T10:12:43.558Z

narc0tiq has a dependency bundle named WinDepend-MSVC.zip here: http://dev.narc.ro/cataclysm/

vassock · 2018-05-26T16:58:47.186Z

There aren’t even any executables in that folder spelled “migw32-make”

vassock · 2018-05-26T17:53:17.654Z

So I compiled using this tutorial:

But I got the text, not tiles version and it crashes when minimized. Since I only changed two lines, is it possible to just copy from the compiled version one or two files to the bugged official version?

vassock · 2018-05-27T10:02:39.153Z

I’ve been going back and forth between instruction pieces, starting from scratch each time, and I keep running into roadblocks, like missing .h files (they’re there, but minGW stupidly doesn’t search in those directories, which raises the question of why the folder structures are there to begin with as MinGW finds the files if they are in the include dir without a folder). Even when I hunt down all the files, I then get errors with the compiler or like I mentioned I get a non-tiles version that crashes.

budg3 · 2018-05-27T10:04:06.346Z

The executables are in the mingw32\bin folder, which is what you setup to use with export PATH=$PATH:/c/mingw32/bin. mingw32-make is the program used to compile using the makefile.

I also remembered that I forgot to include that you need to make some changes to the makefile. I’ve uploaded the makefile here: https://drive.google.com/open?id=1GOSr1_qBik8yslWU43Q02et4vR0TVGIP

vassock · 2018-05-27T10:18:39.425Z

There is no “git bash” if I install it that way. I just get a mingw folder with the only executables being a shortcut and a .bat file. Running the bat file just opens cmd which doesn’t recognize export.

budg3 · 2018-05-27T10:27:35.195Z

Git bash should be included when you install git for windows, which I thought you already did. Here’s the one I got otherwise: https://github.com/git-for-windows/git/releases

Logen · 2018-05-27T12:04:19.137Z

I encountered same issue, downloaded and compiled source from https://github.com/RadHazard/Cataclysm-DDA/tree/fix-clothes-dropping but the bug still persists. What could be the problem? I’m on ubuntu 16.04 x64, did compilation following this guide https://github.com/CleverRaven/Cataclysm-DDA/blob/master/COMPILING.md#linux-native-sdl-builds

budg3 · 2018-05-27T12:43:43.395Z

Alternate fix to the same problem in here by Maeyanie. If this doesn’t work the burning crash bug might not be related to the item dropping crash bugs.

github.com/CleverRaven/Cataclysm-DDA

Issue: Unequipping NPC Clothing Causes a Crash To Desktop

opened by ChronicDankDisasterAlgorithm on 2018-04-06

Game version:
0.C-27229-gae5bdc0 Build 7286
Operating system:
Win 10 Home 64-bit
Tiles or curses:
Tiles
Mods active:
Mining Mod, More Survival Tools, StatsThroughSkills, Vehicle Additions Pack, Tanks and...

(S2 - Confirmed) <Crash / Freeze> Inventory / AIM / Zones NPC

Edit:
It seems like there might be two different bugs at play here. One is the crash that is related to NPCs dropping their items and the other has to do with how the game destroys items inside fires.

github.com/CleverRaven/Cataclysm-DDA

Issue: Crash bug (likely a side-effect of a nearby building burning)

opened by Maplevalley47 on 2018-05-19

closed by kevingranade on 2018-05-30

Game version: cataclysmdda-0.C-7399
Operating system: Windows console
Tiles or curses:
Mods active: More Buildings
Expected behavior
Not crashing (window locks up indefinitely)
Actual behavior
After loading into the...

(S1 - Need confirmation) <Crash / Freeze>

github.com/CleverRaven/Cataclysm-DDA

Issue: Crash while trying to burn the refugee center

opened by l29ah on 2017-12-04

closed by ZhilkinSerg on 2018-06-14

Game version:
0.C-25239-ge769923bc0-dirty
Operating system:
Gentoo
Tiles or curses:
curses
Mods active:
no_npc_food
Program terminated with signal SIGSEGV, Segmentation fault.
#0 __memcmp_sse4_1 () at ../sysdeps/x86_64/multiarch/memcmp-sse4.S:930
930 ../sysdeps/x86_64/multiarch/memcmp-sse4.S: No such file or...

Logen · 2018-05-27T13:48:08.120Z

Thanks! The solution from Maeyanie worked.

vassock · 2018-05-27T17:53:19.791Z

OK, and that has no such file in the install dir.

Cloest I see are
x86_64-w64-mingw32-agrep.exe
x86_64-w64-mingw32-deflatehd.exe
x86_64-w64-mingw32-inflatehd.exe

vassock · 2018-05-27T17:55:24.613Z

How do those “forks” work? Are they fixes made at a certain point in time, or do they continue to be update with any changes made to the main file, but keeping their particular fix/modification?

kevin.granade · 2018-05-30T07:29:47.728Z

Landed candidate fixes for both issues, let me know if that resolved it for you.

The various branches with fixes on them are managed with git, it has a system for resolving the vast majority of conflicts that arise due to the same files being modified by different people, and has tools to help the maintainers resolve conflicts when they aren’t trivial.
Basically it keeps track of the difference between the original code and all of the various edits to the code, and lets someone (me or another maintainer in this case) apply them in an arbitrary order.