Critique my Lore! (Work on Newspapers, Some Spoilers)

StopSignal · 2014-05-08T01:22:54.000Z

Could you take the “Code” section out? It makes reading impossible. So we can read!

Ice-o-metric · 2014-05-08T07:12:55.000Z

Done

infectedmochi · 2014-05-08T07:55:54.000Z

Not sure if you should reference the Granade in, it’s supposed to be a joke item and (should be) rare enough that player only find 1 in a play-through.

GlyphGryph · 2014-05-08T17:20:30.000Z

And the references to it are clearly joke entries. I think they’re great.

Only critique I would have here is about the teleportation stuff - from what I understand of the lore, it is supposed to be very hush hush and only a few months old at most.

I might write on of these myself, add an entry for some trashy tabloids and some parody newspapers. Could move the granade references to there. I love the writing and feel of these, though!

StopSignal · 2014-05-08T18:43:37.000Z

Really interesting and fun! More!

KA101 · 2014-05-08T23:36:48.000Z

Gonna have to go over these in chronological order. (There’s a timeline in the Lore section.)

Could probably do it quickly and easily as a PR. File one and I’ll check you up!

kilozombie · 2014-05-09T21:01:42.000Z

The fact that these are being implemented- and the pages upon pages of work in this thread aren’t- makes me shed infinite tears.

KA101 · 2014-05-09T21:14:48.000Z

kilozombie:

The fact that these are being implemented- and the pages upon pages of work in this thread aren’t- makes me shed infinite tears.

I don’t recall telling you not to file a PR? Feel free to do so, and I’ll review all of it.

shakes head

kilozombie · 2014-05-09T21:36:29.000Z

Oh- well. That’s handy. I kinda forgot we had an extremely active Github.

edit: Wait, a PR? Admittedly, I’m awful at git and bash and all that, and though the framework is there (the “note” item exists, fliers exist) I don’t have it actually coded and working. I’ll file an issue instead?

i2amroy · 2014-05-09T21:55:15.000Z

kilozombie:

I don’t have it actually coded and working. I’ll file an issue instead?

That’s… generally why things don’t get implemented. We only have a very limited number of devs, so the only real guaranteed way to get something implemented is for you to code it. That said this looks like it would just be a simple JSON thing, so probably the most difficult part of the process would just be setting up the github app (which is pretty easy). I think that if you look into it you’ll find making a PR for a change like this is really easy.

kilozombie · 2014-05-09T22:00:09.000Z

I’ll work on it, thanks. Sorry for completely derailing the thread!

Zireael · 2014-05-11T11:58:42.000Z

I love those newspapers, as I’ve already told ya

kevin.granade · 2014-05-12T04:01:03.000Z

kilozombie:

I’ll work on it, thanks. Sorry for completely derailing the thread!

Dude, if every thread derail resulted in someone making a PR for content we want in the game, I wouldn’t mind every thread in the forum having one

KA101 · 2014-05-12T22:28:04.000Z

OK, gave that lore another once-over. Right general idea, would like to tweak a lot of things, really looking for the PR.

Ice-o-metric · 2014-05-13T07:04:34.000Z

Uhm. Ok!.. Not really familiar with Github at all, but i’m a programmer by trade so if i can’t figure it out enough to do a pull request in a single night for code i’ve already got written, well… maybe i’m in the wrong profession :-p

(I had figured let the hashing out occur here on the forum rather than on Github, but i’m happy to do it the other way arround :-p)

kilozombie · 2014-05-13T08:22:47.000Z

You can actually edit code in github’s environment- on the front page of DDA’s github, you can see all the files (Data, etc.). Navigate normally to any text file, then click “edit” at the top. This’ll make a branch of DDA that is your own, and you can edit freely. Then, click “make a Pull Request” on the right when it’s all said and done.

Zireael · 2014-05-13T18:32:25.000Z

I’m not sure pressing Edit makes a new branch. I confirm that it does work, I’ve used it quite a lot of time with my own game.

kilozombie · 2014-05-13T19:20:27.000Z

Well, if you don’t have rights to the main repo, clicking edit will prompt you to make a new branch if you haven’t already, and it is (AFAIK) the only way to pull from upstream reliably without using a command line or UI.

KA101 · 2014-05-13T23:30:58.000Z

In general it’s bad luck to edit directly on the webpage. Tends to send formatting all over the place.

KA101’s workflow (WinXP):
open/log into webpage, windows GUI
open shell from the GUI, confirm in master branch
git pull upstream master
Change to target branch, usually via GUI
open relevant files in Notepad++, hack away
Compiler: CodeBlocks, open and compile as needed
Save, write up the commit message and commit (GUI)
Publish/sync (GUI seems to work better IME)
shift back to master branch
close everything

Zaweri_Runewright · 2014-05-14T12:33:04.000Z

Visit the IRC channel. Usually people would help you there. It’s:
irc.freenode.net
#CataclysmDDA