# Code diving, documentation correction for criticals

**URL:** <https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914>\
**Category:** The Garage\
**Created:** [October 7, 2018, 5:50am UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914 "2018-10-07T05:50:32Z")\
**Posts on this page:** 7\
**Page:** 1

<div class="post-metadata">

**Author:** ![Unawares](https://avatars.discourse-cdn.com/v4/letter/u/6de8d8/32.png) [@Unawares](https://discourse.cataclysmdda.org/u/Unawares)\
**Post date:** [October 7, 2018, 5:50am UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914/1 "2018-10-07T05:50:32Z")

</div>

Doesn’t affect gameplay at all, but the example cases for calculating critical hits in the code documentation has an error. The dexterity / perception “roll” (one of three rolls that work together) for a character with stats 20/20/20/20 would be at 85% not 100%. It starts at 25% and you would get an extra 20 from the Dex and an extra 40 from the Per.

Would be nice if someone could correct it just for better clarity.

---

<div class="post-metadata">

**Author:** ![mlangsdorf](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/mlangsdorf/32/2462_2.png) [@mlangsdorf](https://discourse.cataclysmdda.org/u/mlangsdorf)\
**Post date:** [October 7, 2018, 2:04pm UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914/2 "2018-10-07T14:04:33Z")

</div>

If you have enough knowledge to dive through the code to figure that you, you can open a PR with the fix yourself. This is an open source project and everyone is welcome to contribute.

---

<div class="post-metadata">

**Author:** ![Unawares](https://avatars.discourse-cdn.com/v4/letter/u/6de8d8/32.png) [@Unawares](https://discourse.cataclysmdda.org/u/Unawares)\
**Post date:** [October 7, 2018, 2:26pm UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914/3 "2018-10-07T14:26:53Z")

</div>

Ha, I’m not there yet. If I was already able to do that stuff it would be done, I’d have skipped the forum post. 🙂

---

<div class="post-metadata">

**Author:** ![mlangsdorf](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/mlangsdorf/32/2462_2.png) [@mlangsdorf](https://discourse.cataclysmdda.org/u/mlangsdorf)\
**Post date:** [October 7, 2018, 4:02pm UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914/4 "2018-10-07T16:02:56Z")

</div>

How hard is it to edit a comment string and open a PR? You can do it entirely through github’s web interface if you don’t feel up to dealing with git on your personal machine.

---

<div class="post-metadata">

**Author:** ![Unawares](https://avatars.discourse-cdn.com/v4/letter/u/6de8d8/32.png) [@Unawares](https://discourse.cataclysmdda.org/u/Unawares)\
**Post date:** [October 7, 2018, 9:49pm UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914/5 "2018-10-07T21:49:13Z")

</div>

Glad to hear it’s easy once you know how. Don’t know what a PR thingy is yet, but I’m sure I can figure it out at some point.

Happy Thanksgiving good sir \>salute\<

---

<div class="post-metadata">

**Author:** ![kevin.granade](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/kevin.granade/32/1316_2.png) [@kevin.granade](https://discourse.cataclysmdda.org/u/kevin.granade)\
**Post date:** [October 8, 2018, 5:04pm UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914/6 "2018-10-08T17:04:18Z")

</div>

Check out [https://github.com/help](https://github.com/help) and [https://github.com/CleverRaven/Cataclysm-DDA/blob/master/.github/CONTRIBUTING.md](https://github.com/CleverRaven/Cataclysm-DDA/blob/master/.github/CONTRIBUTING.md)

---

<div class="post-metadata">

**Author:** ![Unawares](https://avatars.discourse-cdn.com/v4/letter/u/6de8d8/32.png) [@Unawares](https://discourse.cataclysmdda.org/u/Unawares)\
**Post date:** [October 10, 2018, 1:17am UTC](https://discourse.cataclysmdda.org/t/code-diving-documentation-correction-for-criticals/16914/7 "2018-10-10T01:17:37Z")

</div>

Thanks Kevin, much appreciated