Broken bandit camp spawn? (Couldn't find bandit_camp_1)

Random_dragon · 2015-08-31T15:12:13.000Z

Oh shit. Do you have tanks mod on?

BeerBeer · 2015-08-31T18:30:09.000Z

Y… yes. W… why?

Thwap · 2015-08-31T19:44:03.000Z

Aiee, if it’s broken with tank mod on then it’s broken period. Tank mod is love.

Random_dragon · 2015-08-31T21:40:36.000Z

I should’ve known the mapgen hax would break SOMETHING. Removing that part and dummying out the mapgen stuff (and forklifts) in a PR: https://github.com/CleverRaven/Cataclysm-DDA/pull/13463

Thwap · 2015-08-31T21:58:24.000Z

What are these mapgen hacks exactly?

Random_dragon · 2015-08-31T22:16:03.000Z

Overwrites for mapgen made to allow special vehicle spawns, which as you can tell borks quests that reference them.

The reason for these is, well…normally if you have multiple mapgen files of the same name, it will pick one at random instead of allowing overwriting.

Wait…I COULD use the weight entry to make the modded version massively more likely to be picked. This would be awkward for multi-map-tile items, like the bandit camp. Less hassle to just dummy it out, as forklifts are the only vehicles TOTALLY depend on mapgen to exist.

JazzGuru · 2015-08-31T23:19:36.000Z

Hey Dragon, stop breaking our game man…

Random_dragon · 2015-08-31T23:23:11.000Z

In Soviet Russia, game breaks you!

;A;

Thwap · 2015-09-01T04:33:19.000Z

Random_dragon:

Overwrites for mapgen made to allow special vehicle spawns, which as you can tell borks quests that reference them.

Like what? Does this mean we won’t find tanks in the street? But my mini reactors!

Random_dragon · 2015-09-01T04:42:58.000Z

Tanks spawn in the streets just fine, that uses vehicle groups.

In any case, found another solution to make the modded mapgen entries EFFECTIVELY override the norm, in a way that doesn’t break quests.

EDIT: I’m dreading the moment when SilverDragon discovers this bug’ll royally fuck up the bandit-hunting quest chain in his playthrough. ;A;

sticks2681 · 2015-09-03T23:20:05.000Z

This just happened to me as well. Is there any way to fix it or does it mean anything to do with bandits or bandit camps is bugged for the entire playthrough?

Random_dragon · 2015-09-03T23:26:28.000Z

sticks2681:

This just happened to me as well. Is there any way to fix it or does it mean anything to do with bandits or bandit camps is bugged for the entire playthrough?

Sadly, they’re fucked. With those mapgens spawned, just removing the overwrite for them will create loads errors, hence why my present PR is dummying out the overwrites in favor of adding a less broken way of getting the new vehicles to spawn there.

And…oh wait, Silver’s still using Series 2, now that I think about it…

sticks2681 · 2015-09-03T23:30:10.000Z

sigh I was doing really well on this playthrough too. Oh well, unless I’m misreading things, there hasn’t been an actual fix pushed through yet, is that right? If so, if I start a new game, should I leave the tank mod off for now or what?

Random_dragon · 2015-09-03T23:35:01.000Z

It’s not merged yet, sadly. Sorry. x.x

You can copy-and-replace via getting it off Dropbox though, as it should be updated with the version I have PR’d. Link is on the first post of the mod thread (http://smf.cataclysmdda.com/index.php?topic=10771.0), or I can link it here. https://dl.dropboxusercontent.com/u/89427928/Tanks.zip

sticks2681 · 2015-09-03T23:41:29.000Z

Ok, thanks!

Random_dragon · 2015-09-03T23:52:52.000Z

And should even worked if dropped into an older save due to retaining the old mapgen files as dummied-out content, but I’ll want to test and further ensure it works as intended.

EDIT: Tested, seems to do so as intended.

sticks2681 · 2015-09-04T00:45:15.000Z

Sorry, I’m a bit brain-dead today so I’m not sure I understand. Do you mean if I update the files, and then go back to that save before given the bandit camp mission, it should work properly?

Random_dragon · 2015-09-04T00:51:50.000Z

In the sense that it’ll still load, yes. It won’t unbreak the already-broken quest though, because the modded mapgen has already spawned. ;A;

sticks2681 · 2015-09-04T00:59:36.000Z

Got it. Thanks again. I’ve only been playing for a couple weeks and I have very little knowledge of programming so I’m trying to learn more about the inner workings as I go along.

Random_dragon · 2015-09-04T01:04:40.000Z

Ah, hope that goes well. I’m still awful at PRing source changes, for example.