# Bases and NPC crafting

**URL:** <https://discourse.cataclysmdda.org/t/bases-and-npc-crafting/14225>\
**Category:** The Lab\
**Tags:** mod\
**Created:** [September 13, 2017, 1:48am UTC](https://discourse.cataclysmdda.org/t/bases-and-npc-crafting/14225 "2017-09-13T01:48:35Z")\
**Posts on this page:** 2\
**Page:** 3

<div class="post-metadata">

**Author:** ![Einstein\_Cross](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/einstein_cross/32/10564_2.png) [@Einstein\_Cross](https://discourse.cataclysmdda.org/u/Einstein_Cross)\
**Post date:** [February 4, 2018, 5:12am UTC](https://discourse.cataclysmdda.org/t/bases-and-npc-crafting/14225/41 "2018-02-04T05:12:55Z")

</div>

Is the Bases and NPC Crafting code ready to be merged? I don’t see how merge rights could be an issues yet unless the code is 100% ready to upload. If it’s not ready, I’d wait to cross that bridge when the project comes to it.

---

<div class="post-metadata">

**Author:** ![kevin.granade](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/kevin.granade/32/1316_2.png) [@kevin.granade](https://discourse.cataclysmdda.org/u/kevin.granade)\
**Post date:** [February 4, 2018, 11:49pm UTC](https://discourse.cataclysmdda.org/t/bases-and-npc-crafting/14225/42 "2018-02-04T23:49:29Z")

</div>

> [@Einstein\_Cross](#):
>
> Is the Bases and NPC Crafting code ready to be merged?

It is not. From what I can see it’s rather a long way off from working, and it’s going to need a ton of refactoring to get merged (the ~300-line per change limit Coolthulu pointed out is utterly ignored in the current PR, which is fine for review, but it’s going to need to be split a LOT in order to be merged), and it was last updated in November.

[Previous page](https://discourse.cataclysmdda.org/t/bases-and-npc-crafting/14225.md?page=2)
