# A script to make a mod out of uncommitted changes in data/json

**URL:** <https://discourse.cataclysmdda.org/t/a-script-to-make-a-mod-out-of-uncommitted-changes-in-data-json/15222>\
**Category:** The Lab\
**Tags:** mod\
**Created:** [April 1, 2018, 4:50pm UTC](https://discourse.cataclysmdda.org/t/a-script-to-make-a-mod-out-of-uncommitted-changes-in-data-json/15222 "2018-04-01T16:50:40Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![fungusakafungus](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/fungusakafungus/32/6772_2.png) [@fungusakafungus](https://discourse.cataclysmdda.org/u/fungusakafungus)\
**Post date:** [April 1, 2018, 4:50pm UTC](https://discourse.cataclysmdda.org/t/a-script-to-make-a-mod-out-of-uncommitted-changes-in-data-json/15222/1 "2018-04-01T16:50:40Z")

</div>

Hi! I was looking at the state of [Firearms Overhaul pull request](https://github.com/CleverRaven/Cataclysm-DDA/pull/22756) and noticed that it gets stale again and again, and that all proposed changes could as well be in a mod.

So I made this little script:

> <https://gist.github.com/fungusakafungus/eb2bdf39da73c03dcb2325b3350ff24b#file-gen-mod-from-diff-sh>

  
And here’s the mod: [https://github.com/fungusakafungus/Cataclysm-DDA/releases/tag/PR22756-v1.0](https://github.com/fungusakafungus/Cataclysm-DDA/releases/tag/PR22756-v1.0)

---

<div class="post-metadata">

**Author:** ![DeWolf](https://avatars.discourse-cdn.com/v4/letter/d/df705f/32.png) [@DeWolf](https://discourse.cataclysmdda.org/u/DeWolf)\
**Post date:** [April 1, 2018, 5:10pm UTC](https://discourse.cataclysmdda.org/t/a-script-to-make-a-mod-out-of-uncommitted-changes-in-data-json/15222/2 "2018-04-01T17:10:26Z")

</div>

So this mod implements the various changes that have been suggested or what?

---

<div class="post-metadata">

**Author:** ![fungusakafungus](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/fungusakafungus/32/6772_2.png) [@fungusakafungus](https://discourse.cataclysmdda.org/u/fungusakafungus)\
**Post date:** [April 1, 2018, 5:17pm UTC](https://discourse.cataclysmdda.org/t/a-script-to-make-a-mod-out-of-uncommitted-changes-in-data-json/15222/3 "2018-04-01T17:17:26Z")

</div>

Yes, the mod implements exactly the changes proposed in Firearms Overhaul pull request. It’s just an automatic conversion.

---

<div class="post-metadata">

**Author:** ![kevin.granade](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/kevin.granade/32/1316_2.png) [@kevin.granade](https://discourse.cataclysmdda.org/u/kevin.granade)\
**Post date:** [April 1, 2018, 6:41pm UTC](https://discourse.cataclysmdda.org/t/a-script-to-make-a-mod-out-of-uncommitted-changes-in-data-json/15222/4 "2018-04-01T18:41:44Z")

</div>

I appreciate your effort, but the PR doesn’t actually fix what it sets out to, which is one if the reasons it hasn’t been merged.  
[https://github.com/CleverRaven/Cataclysm-DDA/issues/22753](https://github.com/CleverRaven/Cataclysm-DDA/issues/22753) discusses what the balance _should_ be, but additionally setting the range on guns doesn’t set effective range, just a range cap.