5d24962-SDL: 2 Inventory related bugs

KA101 · 2014-12-26T05:12:13.000Z

Pretty confident it’s something in the active-item timing diff PR and BevapDin seems to have the issue pretty well in hand. Hols being what they are, it’ll probably be a bit to get it fixed. Worst case, I rip it out altogether.

Seemed to work, but I should have guessed that a significant fix landing before its author goes to see family would cause issues, and hit it harder. >_<

Goombah · 2014-12-26T07:26:30.000Z

No problem. I’ve shelved that particular character for the moment. Carnivore trait makes this one a pain. xD

RoboViking · 2014-12-27T09:26:07.000Z

Plenty food disappeared. I moved the food using the AIM.

96b050a
SDL
Win 8

Also M do not work to move stack

Jeff_Carr · 2014-12-28T22:00:50.000Z

I can verify this issue, it has stopped me playing with the nightly releases. It also appears that the containers disappear with the food items as well with this bug. If I can make a suggestion, many fresh items could be limited to checking their status once a day vs once an hour as the difference with canned goods and the like seems to be negligible.

KA101 · 2014-12-28T22:03:44.000Z

These with last night’s fixes?

vulkans · 2014-12-29T04:16:23.000Z

I’m up to about 5 hours of playtime on 2a99218, both bugs appear to have been fixed. No crashes either.

Goombah · 2014-12-29T15:05:49.000Z

I loaded up my old save and am still getting it. I suspect that’s just screwed up at this point so time to set it aside for good. Unfortunate, really. It was going so well.

Fengferth · 2014-12-29T15:14:06.000Z

Playing on wincurses 2566, this still appears to be a issue as I just transfered about 10 fresh tainted meat from my trunk cart to the floor of my evac shelter base, near the comp (I butchered about 30 minutes in game time before) via AIM and it appears to have vanished as soon as it’s transfered. It was summer time so I expected for it to rot quick, but not that quick ><. This was on a clean save today.

Goombah · 2014-12-29T15:50:14.000Z

…or not…

vulkans · 2014-12-29T16:22:39.000Z

It was all going fine 'til my fridge ran out of power- after that, things started to disappear again. Namely chunks of raw and tainted meat.

Not sure if it’s relevant at all but this bug isn’t unique to AIM either, using shift-D to drop your stuff on an adjacent tile is also affected.

Zipo · 2014-12-30T00:50:41.000Z

Yeah when I shift-D a lot of canned goods into the one tile some of them vanish. So I’ve just been dropping them into seperate tiles eg 2 tins of meat soup there, 7 tins of beans there, etc. So far they’ve been staying. Haven’t tried figuring out the number of things dropped into the same tile that causes them to begin vanishing thou.

KA101 · 2014-12-30T01:03:12.000Z

If you’ve got a watch, it’d be interesting to hit . before dropping, and then see if problem drops carry you into the next turn/over more than one turn (six seconds per turn).

Zipo · 2014-12-30T01:31:24.000Z

Figured out the point at which it does it with canned goods being dropped on the ground. Happens at 'aj. The last can dropped replaces the whatever was in 'aj over and over. Except when I try to drop in fruit or veg over the tin the fruit/veg just vanishes. But when I put a tin food on the veg/fruit the veg/fruit vanishes.
As for the seconds per turn it takes standard 6 seconds. Probably because it’s still dropping the item and replacing what’s last on the list most of the time.

Goombah · 2014-12-31T06:52:38.000Z

So it looks like this is still ongoing?

KA101 · 2014-12-31T07:31:34.000Z

Goombah:

So it looks like this is still ongoing?

I think so, unfortunately–Kevin got a fix up for flame/cookoff-related crashing but that’s not food. That said, it’s not precisely helpful to bump about it. We know.

AllisonW · 2014-12-31T20:11:58.000Z

A heads-up: I’ve been getting something like this with non-tinned nonperishables as well as perishables. Things like my stockpiles of granola, dehydrated meat, dehydrated fruit, and sugar–specifically, things I crafted, that were not in containers like cardboard boxes or plastic bags–went missing when I put them in a locker that was really, really overfilled. I’ve taken to placing them on their own counter where I hope they’re safe. (I’m glad I noticed this with 21 days of summer to go.)

KA101 · 2014-12-31T23:23:52.000Z

Ugh. Thanks.

Narc · 2015-01-01T00:21:38.000Z

Zipo:

[…] Happens at 'aj. […]

Coincidentally, that’s the 64th item in the tile. Interesting.

Narc · 2015-01-01T02:42:05.000Z

And by ‘coincidentally’, I, of course, meant ‘suspiciously’. It turns out the method being used to re-add active items back onto the map after they’ve been processed has an optional parameter that is called “maxitems”, and defaults to… 64. Whenever more than 64 items are in a tile, when an active item is processed (food counts, but also active lightstrips, etc.), the items get deleted instead of being put back.

Fix has been posted and should be merged whenever.

KA101 · 2015-01-01T03:03:24.000Z

[quote=“Narc, post:26, topic:8411”]And by ‘coincidentally’, I, of course, meant ‘suspiciously’. It turns out the method being used to re-add active items back onto the map after they’ve been processed has an optional parameter that is called “maxitems”, and defaults to… 64. Whenever more than 64 items are in a tile, when an active item is processed (food counts, but also active lightstrips, etc.), the items get deleted instead of being put back.

Fix has been posted and should be merged whenever.[/quote]

I’m test-compiling now. Update: merged. Give build 2580 a shot, if you please.