# 1799: Gallon Jug won't hold water

**URL:** <https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829>\
**Category:** The Garage\
**Created:** [July 18, 2014, 7:41pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829 "2014-07-18T19:41:31Z")\
**Posts on this page:** 16\
**Page:** 1

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/flex016/uploads/cataclysmdda/original/1X/21b5d044e8473b25d0bf905d60477e25f6fbe0cf.png) [@system](https://discourse.cataclysmdda.org/u/system)\
**Post date:** [July 18, 2014, 7:41pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/1 "2014-07-18T19:41:31Z")

</div>

I just emptied a gallon jug of ammonia then tried to fill it with water. It goes through the process of filling it with water, but when I look at it in my inventory it shows it to be empty.

---

<div class="post-metadata">

**Author:** ![qurvax](https://avatars.discourse-cdn.com/v4/letter/q/ecc23a/32.png) [@qurvax](https://discourse.cataclysmdda.org/u/qurvax)\
**Post date:** [July 19, 2014, 8:17pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/2 "2014-07-19T20:17:37Z")

</div>

Got this too. 1796

---

<div class="post-metadata">

**Author:** ![SuicideRey](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/suiciderey/32/913_2.png) [@SuicideRey](https://discourse.cataclysmdda.org/u/SuicideRey)\
**Post date:** [July 22, 2014, 5:11am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/3 "2014-07-22T05:11:41Z")

</div>

Still in 1806 it wastes the water and also works for gasoline and jerrycans I’m sure that this is an issue with all the liquids atm. However it works with regular bottles.

Unloading from a bottle to a gallon jug doesn’t work as well.

---

<div class="post-metadata">

**Author:** ![gcaliber](https://avatars.discourse-cdn.com/v4/letter/g/57b2e6/32.png) [@gcaliber](https://discourse.cataclysmdda.org/u/gcaliber)\
**Post date:** [July 23, 2014, 7:47am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/4 "2014-07-23T07:47:35Z")

</div>

I don’t have this problem in 1813 updated from 1774.

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/flex016/uploads/cataclysmdda/original/1X/21b5d044e8473b25d0bf905d60477e25f6fbe0cf.png) [@system](https://discourse.cataclysmdda.org/u/system)\
**Post date:** [July 23, 2014, 6:10pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/5 "2014-07-23T18:10:49Z")

</div>

Seems to be fixed now.

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/flex016/uploads/cataclysmdda/original/1X/21b5d044e8473b25d0bf905d60477e25f6fbe0cf.png) [@system](https://discourse.cataclysmdda.org/u/system)\
**Post date:** [July 24, 2014, 1:09am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/6 "2014-07-24T01:09:42Z")

</div>

Never mind, the jug holds water but the 55 gallon drum won’t.

---

<div class="post-metadata">

**Author:** ![Daidalon](https://avatars.discourse-cdn.com/v4/letter/d/77aa72/32.png) [@Daidalon](https://discourse.cataclysmdda.org/u/Daidalon)\
**Post date:** [July 24, 2014, 1:22am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/7 "2014-07-24T01:22:51Z")

</div>

> [@Repressive](#):
>
> Never mind, the jug holds water but the 55 gallon drum won’t.

Which version are you looking at? I just looked at the JSON and it appears to have all the flags it needs.

---

<div class="post-metadata">

**Author:** ![qurvax](https://avatars.discourse-cdn.com/v4/letter/q/ecc23a/32.png) [@qurvax](https://discourse.cataclysmdda.org/u/qurvax)\
**Post date:** [July 24, 2014, 5:12am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/8 "2014-07-24T05:12:00Z")

</div>

On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

---

<div class="post-metadata">

**Author:** ![kevin.granade](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/kevin.granade/32/1316_2.png) [@kevin.granade](https://discourse.cataclysmdda.org/u/kevin.granade)\
**Post date:** [July 24, 2014, 6:54am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/9 "2014-07-24T06:54:17Z")

</div>

That seems to be the issue, and I’m poking at it. The inventory code is seriously screwey, and interfering with a clean fix to the problem.

---

<div class="post-metadata">

**Author:** ![noname1208](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/noname1208/32/23_2.png) [@noname1208](https://discourse.cataclysmdda.org/u/noname1208)\
**Post date:** [July 24, 2014, 4:47pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/10 "2014-07-24T16:47:28Z")

</div>

I’m curious.

To anyone with this problem: Can you fill them using a funnel in the rain?

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/flex016/uploads/cataclysmdda/original/1X/21b5d044e8473b25d0bf905d60477e25f6fbe0cf.png) [@system](https://discourse.cataclysmdda.org/u/system)\
**Post date:** [July 25, 2014, 12:26am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/11 "2014-07-25T00:26:24Z")

</div>

> [@qurvax](#):
>
> On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

You mean wielded right? Because I was confused there for a second thinking that by welded you meant reinforced.

---

<div class="post-metadata">

**Author:** ![KA101](https://avatars.discourse-cdn.com/v4/letter/k/278dde/32.png) [@KA101](https://discourse.cataclysmdda.org/u/KA101)\
**Post date:** [July 25, 2014, 12:29am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/12 "2014-07-25T00:29:29Z")

</div>

Just merged a fix. Update and let us know if there’s still problems, please.

---

<div class="post-metadata">

**Author:** ![kevin.granade](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/kevin.granade/32/1316_2.png) [@kevin.granade](https://discourse.cataclysmdda.org/u/kevin.granade)\
**Post date:** [July 25, 2014, 2:02am UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/13 "2014-07-25T02:02:40Z")

</div>

The specific problem was that if you were wielding (holding in your hands) a container, it would fail to accept liquid you tried to pour into it.  
The technical issue was that the item the player is wielding (internally refered to as player::weapon) is treated specially, and the code that operates on inventory/weapon/clothes had a bug where it would make a _copy_ of player::weapon instead of storing a reference to it. Later on the code would try to act on this copy instead of on the real weapon.

---

<div class="post-metadata">

**Author:** ![qurvax](https://avatars.discourse-cdn.com/v4/letter/q/ecc23a/32.png) [@qurvax](https://discourse.cataclysmdda.org/u/qurvax)\
**Post date:** [July 26, 2014, 12:05pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/14 "2014-07-26T12:05:19Z")

</div>

> [@Repressive](#):
>
> [quote=“qurvax, post:8, topic:6829”]On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

You mean wielded right? Because I was confused there for a second thinking that by welded you meant reinforced.[/quote]

Yes, misstyped.

Tested galon jugs, plastic jerrycans and 3L jar’s - all working as they should. Thank you KA101.

---

<div class="post-metadata">

**Author:** ![KA101](https://avatars.discourse-cdn.com/v4/letter/k/278dde/32.png) [@KA101](https://discourse.cataclysmdda.org/u/KA101)\
**Post date:** [July 26, 2014, 3:05pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/15 "2014-07-26T15:05:24Z")

</div>

> [@qurvax](#):
>
> [quote=“Repressive, post:11, topic:6829”][quote=“qurvax, post:8, topic:6829”]On github there’s a issue about being unable to fill something, if container is welded. Seems that our case. Gonna test if fixed.

You mean wielded right? Because I was confused there for a second thinking that by welded you meant reinforced.[/quote]

Yes, misstyped.

Tested galon jugs, plastic jerrycans and 3L jar’s - all working as they should. Thank you KA101.[/quote]

Thank Kevin, he found and wrote the fix. 😉

---

<div class="post-metadata">

**Author:** ![qurvax](https://avatars.discourse-cdn.com/v4/letter/q/ecc23a/32.png) [@qurvax](https://discourse.cataclysmdda.org/u/qurvax)\
**Post date:** [July 26, 2014, 5:01pm UTC](https://discourse.cataclysmdda.org/t/1799-gallon-jug-wont-hold-water/6829/16 "2014-07-26T17:01:18Z")

</div>

> [@KA101](#):
>
> Thank Kevin, he found and wrote the fix. 😉

I express my gratitude to everyone involved in fixing that annoying bug 🙂