# \[0xB\] Useless piece of code

**URL:** <https://discourse.cataclysmdda.org/t/0xb-useless-piece-of-code/8190>\
**Category:** The Garage\
**Created:** [December 4, 2014, 11:32pm UTC](https://discourse.cataclysmdda.org/t/0xb-useless-piece-of-code/8190 "2014-12-04T23:32:25Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![EditorRUS](https://avatars.discourse-cdn.com/v4/letter/e/9fc29f/32.png) [@EditorRUS](https://discourse.cataclysmdda.org/u/EditorRUS)\
**Post date:** [December 4, 2014, 11:32pm UTC](https://discourse.cataclysmdda.org/t/0xb-useless-piece-of-code/8190/1 "2014-12-04T23:32:25Z")

</div>

[code]void iexamine::safe(player \*p, map \*m, int examx, int examy)  
{  
if (!p-\>has\_amount(“stethoscope”, 1)) {  
add\_msg(m\_info, \_(“You need a stethoscope for safecracking.”));  
return;  
}

```
if (query_yn(_("Attempt to crack the safe?"))) {
    bool success = true;
    if (p->is_deaf()) {
        add_msg(m_info, _("You can't crack a safe while deaf!"));
        return;
    }

    if (success) {
        m->furn_set(examx, examy, f_safe_o);
        add_msg(m_good, _("You successfully crack the safe!"));
    } else {
        add_msg(_("The safe resists your attempt at cracking it."));
    }
}

```

}  
[/code]  
What’s the point of having ELSE clause if it always successes?

---

<div class="post-metadata">

**Author:** ![EkarusRyndren](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/ekarusryndren/32/80_2.png) [@EkarusRyndren](https://discourse.cataclysmdda.org/u/EkarusRyndren)\
**Post date:** [December 4, 2014, 11:39pm UTC](https://discourse.cataclysmdda.org/t/0xb-useless-piece-of-code/8190/2 "2014-12-04T23:39:29Z")

</div>

Just a guess, but at some point in the future it probably won’t always succeed.

---

<div class="post-metadata">

**Author:** ![BevapDin](https://sea2.discourse-cdn.com/flex016/user_avatar/discourse.cataclysmdda.org/bevapdin/32/228_2.png) [@BevapDin](https://discourse.cataclysmdda.org/u/BevapDin)\
**Post date:** [December 5, 2014, 3:14pm UTC](https://discourse.cataclysmdda.org/t/0xb-useless-piece-of-code/8190/3 "2014-12-05T15:14:26Z")

</div>

That would be the issue listed at [https://github.com/CleverRaven/Cataclysm-DDA/issues/9695](https://github.com/CleverRaven/Cataclysm-DDA/issues/9695) - there are some solutions proposed, but nobody has implemented any of them.
